From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67088CFC288 for ; Tue, 15 Oct 2024 10:52:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0ABD6B0082; Tue, 15 Oct 2024 06:52:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBA786B0083; Tue, 15 Oct 2024 06:52:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83C46B0085; Tue, 15 Oct 2024 06:52:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 896066B0082 for ; Tue, 15 Oct 2024 06:52:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CA793AA113 for ; Tue, 15 Oct 2024 10:52:26 +0000 (UTC) X-FDA: 82675523280.16.45EED39 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf03.hostedemail.com (Postfix) with ESMTP id 8B7AD20002 for ; Tue, 15 Oct 2024 10:52:38 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Lz2Wllbq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=snovitoll@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728989530; a=rsa-sha256; cv=none; b=It3LGy51gcbj3bIwoLKosdxdAZPAI/O6JtjNJGFsVYf7h8btbdKLHDzvaDihHNudy2bazj 6WgiLxJ2y/wyU5QeoXVrf+zfq7z07T58/LpHv+kaN9HuteKq9X/Nb9w7ztZbMPRUyx47+A p/eIdXUaa+mSVUaYk4cQxZZ2TMClNQg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Lz2Wllbq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=snovitoll@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728989530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=miCofaLTCliOiaggNDs4P5r/0poFiwum/y0l9beo+ZU=; b=wyTNQhQ5KzXH/pPCFU2sDy3n/3K0FogCGCqOXG7Tj9FiP+wYgbc5NiOw17+XPB20MwJGYv 1+J7m0a9Vls3VM7rOkcmZSlmiiwHIBBDquEQA0p6VYnD9VveGTMZCz+F9JJLKX8aYPq9tj B0+PJeYJVhItCJ1ViMQnptzMud8VCG8= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5c949d60d84so4835918a12.1 for ; Tue, 15 Oct 2024 03:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728989561; x=1729594361; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=miCofaLTCliOiaggNDs4P5r/0poFiwum/y0l9beo+ZU=; b=Lz2WllbqJ8NzPAAHYdxV2c92kah7HqgCXjgOgms4nGzU69/Pbc8e/k0rzwc5WsbsWR AN5ypHICq0sx1Makb4VAH07rl9X4j5wClxmFaRTuaPHV9s8x/E7E33QkliCQx9pAUUws OJIh+fgo6mYurDKTzfyBbH9e7mrk3O9Eid9KDu3WG/8uO6IxElb5+FHLaXtO0XpOEGE0 DRBmDNNEr6q3hzTeIamCvpC9q2SWBvx0CNyNW9qv+SDdEHqqJ2MGOEKMK1V25kO6PTLf 8bI496DQIWFkQM5ZByErKl7XvLGRLUtWE2IkjOp84eWrifYa4zTZAR+e4OlZAaTrcK+q Ypfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728989561; x=1729594361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=miCofaLTCliOiaggNDs4P5r/0poFiwum/y0l9beo+ZU=; b=WzweO+0bysEQPWdcRq7dI1C2+bECStpp+pgg7OyX1TGNRy/IpQz3Nx6PGx0m7wOkUb xETsBBW5mWFZN7zkEPK+3+W8HT9aXJEWxoYCiazchmk1i9dnERS+2sPfI0SoOV1YyeH4 f7RJsL047yexPkFVR5kR2fkm+SN30Viq22Lw+R3vikciB5Hvm1UMoHnapNTJR6NZfocj 5xiMTqq5aKrxd+pOZU1c5siLs5J9KI3bqr9+jaYGxkKYpJ/3R+bKyXiNqZcMd8L6DWdz yqdLgB1h8oV7mFAV+S22D3OE75b/qijp3zHD32omrjbpu1yGJtIrWxM6kIwRRjqk3JpK 7pgA== X-Forwarded-Encrypted: i=1; AJvYcCWbrUX9GpiEHAZEeNjGQqgEYy02VHq0u18GNU5BqsnFUblUua+lAyluCRB516R8OFTEQ8RSmhoekw==@kvack.org X-Gm-Message-State: AOJu0Yz6lo6EU9oiTihYDkVtP8C1UBpaf7opYjy2j6owmVJcKAUp4ToI agjwB5C6AEFUp+AnUeltEjqmOQBSMuwtpiYpXWeh4tHecvzM6Pmr6aXvD51F4j+CT4kkYDsFpQ+ EH4v92ffSASW5SwXy+inVyBxkANA= X-Google-Smtp-Source: AGHT+IFk7BXffNv4e/2AjFYfCrgZ4ShdR5CLjDEp47QaCgk8TG/YKWt1pCpDQM8SNHkK1aqMaNGsGE8gyTU8KU9g23E= X-Received: by 2002:a05:6402:5188:b0:5c9:59e6:e908 with SMTP id 4fb4d7f45d1cf-5c959e6f56amr9476072a12.6.1728989560452; Tue, 15 Oct 2024 03:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20241014025701.3096253-1-snovitoll@gmail.com> <20241014025701.3096253-3-snovitoll@gmail.com> <20241014161042.885cf17fca7850b5bbf2f8e5@linux-foundation.org> In-Reply-To: From: Sabyrzhan Tasbolatov Date: Tue, 15 Oct 2024 15:53:35 +0500 Message-ID: Subject: Re: [PATCH RESEND v3 2/3] kasan: migrate copy_user_test to kunit To: Andrey Konovalov Cc: Andrew Morton , 2023002089@link.tyut.edu.cn, alexs@kernel.org, corbet@lwn.net, dvyukov@google.com, elver@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryabinin.a.a@gmail.com, siyanteng@loongson.cn, vincenzo.frascino@arm.com, workflows@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: j1z96qupyzgazagqgdgz1pemp9fbnr3d X-Rspamd-Queue-Id: 8B7AD20002 X-Rspamd-Server: rspam02 X-HE-Tag: 1728989558-196159 X-HE-Meta: U2FsdGVkX19P2PJgheaiYpgDSk/BPHaX2nSIjdL4/fHpwNuFUVlDFpN/FneG+Y0Xa8ifhlAcbIF0afLjSk8i0VIjyRCCBf1W5t2hrZSluqASsci7Zwa5z9gQ2hDHpcHEkEod2WjizY15AdpxxIuubgUym0YdW+wANSQz7a39+Z3prF4wI99r2lswo1Vls0Z1httU0qRcSgUbkv8j/+PolseyuhpiOgXD1qQsMRXNWjaWWvKmBbrRQPVKwSxP+a0pjCsDhH7eRCurAmLah1OnjP4bMwote4u9WJ3kbFQ0El+Z/Acxh4WrBn+9KTFHyKhw8eVXSXg6tP1SRH8ur6AAV4Dtczg8cceLfBYGe/BANORpu//pv8X/Lfm9TDUdvd5mXHHtSaKG64C8l3/t7iXyO/h6hAukz8JBEiXkQ8UTTLIkrMzF/9gC7UhDr2PI7IW3HAazOplQNArx92gea45sA+NkId3IR8o6U08IS/mSaSWXHjbOb1fqTKWB6hY1QZZUMYDdy/IU0ytuQpWoKbeGFgb0JmvWWXNm39t6hK7a1+xWdlDR2tZ2nBjPcNeHxrCNDseJ1BWYuEe7O9S7wxU7KDystz11PfAr+0TdgyaS6vYNq+G9Swpkvhp9r2LXBPtFc7/OfHRuJNn40V4NKE+FhB4Qct91pIXdRfwW83X3l60iY6Fqs0op++vL1JbEL0ChvxF1FkZzabPSy+GJoUQf4QtX3U/FaWKoYUIb/MRwXn9RlGrdQlcphLi+H/gI+DJlNmTGV2Aw7kEXScs9Rp6DO7lpNleL5ox+lZA3ZKxero03kfFgF75QPwQRgznLsDBKf41SHK1OAovSR3siQoBe3/hfnK5GOJGuZcAdznprs3O6LYpF2EJffVuoYK7nA4MxA9ke0mRzpJI8U0TMohTvi93c1zolu1XAIooUwEGl/G65ACfGurp1CSsmuLiJZDzKy5tPsT9cI/WyhtFeabC YA/cPfdt UXfNFGAvNxOVLwqaKMt4TcOUiRequxzbOfPiRpqLRfB7e0hYnDKqOfXFYQOQ1m0iJ2LHr3fhbnB1JtUQ4k+4w8zT6Dkh++WHOt4dBq2xXLM3ucu+MVAbiECCqIrLVRKYD0hyddU1asNBsLjx1GsrJL7XxZw1eEiG/zzoMJtZ3Otb4oik8/TUSa4oeB0R65YfpnmYavZejg3pIccZjPYdVBMSVUd38upVxS9SKCxqNao/GI3dUsWN/yEPLB/fejMng5MDRUNKEeWCfC/P5DgZFP/e+olpRCdSCrQOqkqtP0Ib+2kzFgmbdTJW0oZgwOoKYdm/FDU/5ULQEaHCoJB3Ud3bKGaJ/Kq4SS2/mzpBJmzG2QxLIUWPIOWxSvsc5M40gtNutR7mMprFQJt4AFbqlpH4kNVFnlzsZbwosW0ThMQJqvvkyMIdc7TzTL4Dw4iMwx8XANI8iewmojhsATBbL2dOs8tmg5yiClQ6XALTmqjbwq6MJPkBQQgfgBe/rpNtCJDxANSTs84Ky4Ic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 6:18=E2=80=AFAM Andrey Konovalov wrote: > > On Tue, Oct 15, 2024 at 1:10=E2=80=AFAM Andrew Morton wrote: > > > > On Mon, 14 Oct 2024 07:57:00 +0500 Sabyrzhan Tasbolatov wrote: > > > > > Migrate the copy_user_test to the KUnit framework to verify out-of-bo= und > > > detection via KASAN reports in copy_from_user(), copy_to_user() and > > > their static functions. > > > > > > This is the last migrated test in kasan_test_module.c, therefore dele= te > > > the file. > > > > > > > x86_64 allmodconfig produces: > > > > vmlinux.o: warning: objtool: strncpy_from_user+0x8a: call to __check_ob= ject_size() with UACCESS enabled I've missed this warning during x86_64 build, sorry. > > Too bad. I guess we have to duplicate both kasan_check_write and > check_object_size before both do_strncpy_from_user calls in > strncpy_from_user. Shall we do it once in strncpy_from_user() as I did in v1? Please let me know as I've tested in x86_64 and arm64 - there is no warning during kernel build with the diff below. These checks are for kernel pointer *dst only and size: kasan_check_write(dst, count); check_object_size(dst, count, false); And there are 2 calls of do_strncpy_from_user, which are implemented in x86 atm per commit 2865baf54077, and they are relevant to __user *src address, AFAIU. long strncpy_from_user() if (can_do_masked_user_access()) { src =3D masked_user_access_begin(src); retval =3D do_strncpy_from_user(dst, src, count, count); user_read_access_end(); } if (likely(src_addr < max_addr)) { if (user_read_access_begin(src, max)) { retval =3D do_strncpy_from_user(dst, src, count, max); user_read_access_end(); --- diff --git a/lib/strncpy_from_user.c b/lib/strncpy_from_user.c index 989a12a6787..6dc234913dd 100644 --- a/lib/strncpy_from_user.c +++ b/lib/strncpy_from_user.c @@ -120,6 +120,9 @@ long strncpy_from_user(char *dst, const char __user *src, long count) if (unlikely(count <=3D 0)) return 0; + kasan_check_write(dst, count); + check_object_size(dst, count, false); + if (can_do_masked_user_access()) { long retval; @@ -142,8 +145,6 @@ long strncpy_from_user(char *dst, const char __user *src, long count) if (max > count) max =3D count; - kasan_check_write(dst, count); - check_object_size(dst, count, false); if (user_read_access_begin(src, max)) { retval =3D do_strncpy_from_user(dst, src, count, ma= x); user_read_access_end();