* [PATCH] mm/zswap: add __init to some functions in zswap
@ 2014-11-09 12:23 Mahendran Ganesh
2014-11-13 2:55 ` Seth Jennings
0 siblings, 1 reply; 3+ messages in thread
From: Mahendran Ganesh @ 2014-11-09 12:23 UTC (permalink / raw)
To: sjennings, minchan; +Cc: ddstreet, linux-mm, linux-kernel, Mahendran Ganesh
zswap_cpu_init/zswap_comp_exit/zswap_entry_cache_create is only
called by __init init_zswap()
Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
---
mm/zswap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index 51a2c45..2e621fa 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -149,7 +149,7 @@ static int __init zswap_comp_init(void)
return 0;
}
-static void zswap_comp_exit(void)
+static void __init zswap_comp_exit(void)
{
/* free percpu transforms */
if (zswap_comp_pcpu_tfms)
@@ -206,7 +206,7 @@ static struct zswap_tree *zswap_trees[MAX_SWAPFILES];
**********************************/
static struct kmem_cache *zswap_entry_cache;
-static int zswap_entry_cache_create(void)
+static int __init zswap_entry_cache_create(void)
{
zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
return zswap_entry_cache == NULL;
@@ -389,7 +389,7 @@ static struct notifier_block zswap_cpu_notifier_block = {
.notifier_call = zswap_cpu_notifier
};
-static int zswap_cpu_init(void)
+static int __init zswap_cpu_init(void)
{
unsigned long cpu;
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/zswap: add __init to some functions in zswap
2014-11-09 12:23 [PATCH] mm/zswap: add __init to some functions in zswap Mahendran Ganesh
@ 2014-11-13 2:55 ` Seth Jennings
2014-11-13 14:16 ` Ganesh Mahendran
0 siblings, 1 reply; 3+ messages in thread
From: Seth Jennings @ 2014-11-13 2:55 UTC (permalink / raw)
To: Mahendran Ganesh; +Cc: minchan, ddstreet, linux-mm, linux-kernel
On Sun, Nov 09, 2014 at 08:23:52PM +0800, Mahendran Ganesh wrote:
> zswap_cpu_init/zswap_comp_exit/zswap_entry_cache_create is only
> called by __init init_zswap()
Thanks for the cleanup!
Acked-by: Seth Jennings <sjennings@variantweb.net>
>
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
> ---
> mm/zswap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 51a2c45..2e621fa 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -149,7 +149,7 @@ static int __init zswap_comp_init(void)
> return 0;
> }
>
> -static void zswap_comp_exit(void)
> +static void __init zswap_comp_exit(void)
> {
> /* free percpu transforms */
> if (zswap_comp_pcpu_tfms)
> @@ -206,7 +206,7 @@ static struct zswap_tree *zswap_trees[MAX_SWAPFILES];
> **********************************/
> static struct kmem_cache *zswap_entry_cache;
>
> -static int zswap_entry_cache_create(void)
> +static int __init zswap_entry_cache_create(void)
> {
> zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
> return zswap_entry_cache == NULL;
> @@ -389,7 +389,7 @@ static struct notifier_block zswap_cpu_notifier_block = {
> .notifier_call = zswap_cpu_notifier
> };
>
> -static int zswap_cpu_init(void)
> +static int __init zswap_cpu_init(void)
> {
> unsigned long cpu;
>
> --
> 1.7.9.5
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/zswap: add __init to some functions in zswap
2014-11-13 2:55 ` Seth Jennings
@ 2014-11-13 14:16 ` Ganesh Mahendran
0 siblings, 0 replies; 3+ messages in thread
From: Ganesh Mahendran @ 2014-11-13 14:16 UTC (permalink / raw)
To: Seth Jennings; +Cc: Minchan Kim, ddstreet, linux-mm, linux-kernel
2014-11-13 10:55 GMT+08:00 Seth Jennings <sjennings@variantweb.net>:
> On Sun, Nov 09, 2014 at 08:23:52PM +0800, Mahendran Ganesh wrote:
>> zswap_cpu_init/zswap_comp_exit/zswap_entry_cache_create is only
>> called by __init init_zswap()
>
> Thanks for the cleanup!
>
> Acked-by: Seth Jennings <sjennings@variantweb.net>
Thanks very much!
>
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
>> ---
>> mm/zswap.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/zswap.c b/mm/zswap.c
>> index 51a2c45..2e621fa 100644
>> --- a/mm/zswap.c
>> +++ b/mm/zswap.c
>> @@ -149,7 +149,7 @@ static int __init zswap_comp_init(void)
>> return 0;
>> }
>>
>> -static void zswap_comp_exit(void)
>> +static void __init zswap_comp_exit(void)
>> {
>> /* free percpu transforms */
>> if (zswap_comp_pcpu_tfms)
>> @@ -206,7 +206,7 @@ static struct zswap_tree *zswap_trees[MAX_SWAPFILES];
>> **********************************/
>> static struct kmem_cache *zswap_entry_cache;
>>
>> -static int zswap_entry_cache_create(void)
>> +static int __init zswap_entry_cache_create(void)
>> {
>> zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
>> return zswap_entry_cache == NULL;
>> @@ -389,7 +389,7 @@ static struct notifier_block zswap_cpu_notifier_block = {
>> .notifier_call = zswap_cpu_notifier
>> };
>>
>> -static int zswap_cpu_init(void)
>> +static int __init zswap_cpu_init(void)
>> {
>> unsigned long cpu;
>>
>> --
>> 1.7.9.5
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-13 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-09 12:23 [PATCH] mm/zswap: add __init to some functions in zswap Mahendran Ganesh
2014-11-13 2:55 ` Seth Jennings
2014-11-13 14:16 ` Ganesh Mahendran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).