From: Peter Xu <peterx@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>, Yang Shi <shy828301@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Kirill Shutemov <kirill@shutemov.name>,
Hugh Dickins <hughd@google.com>, Jann Horn <jannh@google.com>,
Michal Hocko <mhocko@suse.com>, Jan Kara <jack@suse.cz>,
Andrea Arcangeli <aarcange@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH v2 3/4] mm: Do early cow for pinned pages during fork() for ptes
Date: Sun, 27 Sep 2020 00:09:19 -0400 [thread overview]
Message-ID: <CADLect=7de6r7wAciqUOEC6HocnnpuzDbdpwHSpBejFtYcNFwQ@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wh5pE+gXTigysiGf4vf+6jG7K58gwdk8b7qk_QUeEgKWA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
Linus Torvalds <torvalds@linux-foundation.org> 于 2020年9月26日周六 20:05写道：
> > > + page_add_new_anon_rmap(new_page, new,
> addr, false);
> > > + rss[mm_counter(new_page)]++;
> > > + set_pte_at(dst_mm, addr, dst_pte, pte);
> >
> > Linus's patch had a lru_cache_add_inactive_or_unevictable() here, like
> > wp_page_copy()
>
> Yeah, I do think that is needed so that we have the new page on the
> LRU and it gets properly evicted under memory pressure.
>
Oops, yes we definitely need this one.
Thanks,
>
[-- Attachment #2: Type: text/html, Size: 1240 bytes --]
next prev parent reply other threads:[~2020-09-27 4:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:25 [PATCH v2 0/4] mm: Break COW for pinned pages during fork() Peter Xu
2020-09-25 22:25 ` [PATCH v2 1/4] mm: Introduce mm_struct.has_pinned Peter Xu
2020-09-25 22:25 ` [PATCH v2 2/4] mm/fork: Pass new vma pointer into copy_page_range() Peter Xu
2020-09-30 13:30 ` Kirill A. Shutemov
2020-09-30 17:05 ` Peter Xu
2020-09-25 22:25 ` [PATCH v2 3/4] mm: Do early cow for pinned pages during fork() for ptes Peter Xu
2020-09-26 23:23 ` Jason Gunthorpe
2020-09-27 0:04 ` Linus Torvalds
2020-09-27 4:09 ` Peter Xu [this message]
2020-09-25 22:26 ` [PATCH v2 4/4] mm/thp: Split huge pmds/puds if they're pinned when fork() Peter Xu
2020-09-27 19:35 ` [PATCH v2 0/4] mm: Break COW for pinned pages during fork() Linus Torvalds
2020-09-29 11:02 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADLect=7de6r7wAciqUOEC6HocnnpuzDbdpwHSpBejFtYcNFwQ@mail.gmail.com' \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kirill@shutemov.name \
--cc=ktkhai@virtuozzo.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=oleg@redhat.com \
--cc=shy828301@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).