[PATCH] mm: mmap: add missing space after comma in vma_expand_up macro

[PATCH] mm: mmap: add missing space after comma in vma_expand_up macro

[Giorgi Tchankvetadze]

Fix minor style inconsistency in macro parameter list to match
kernel coding style.

No functional change.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
 mm/mmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 843160946aa5..37414e4ea362 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1001,12 +1001,12 @@ struct vm_area_struct *find_extend_vma_locked(struct mm_struct *mm, unsigned lon
 
 #if defined(CONFIG_STACK_GROWSUP)
 
-#define vma_expand_up(vma,addr) expand_upwards(vma, addr)
+#define vma_expand_up(vma, addr) expand_upwards(vma, addr)
 #define vma_expand_down(vma, addr) (-EFAULT)
 
 #else
 
-#define vma_expand_up(vma,addr) (-EFAULT)
+#define vma_expand_up(vma, addr) (-EFAULT)
 #define vma_expand_down(vma, addr) expand_downwards(vma, addr)
 
 #endif
-- 
2.52.0

Re: [PATCH] mm: mmap: add missing space after comma in vma_expand_up macro

[Pedro Falcato]

On Tue, Mar 24, 2026 at 02:29:11PM +0400, Giorgi Tchankvetadze wrote:
> Fix minor style inconsistency in macro parameter list to match
> kernel coding style.
> 
> No functional change.
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>

Reviewed-by: Pedro Falcato <pfalcato@suse.de>

I understand this is your first patch, so I will be lenient here. But note
that generally style touchups are only done if you're already touching
something in the area :)

-- 
Pedro

Re: [PATCH] mm: mmap: add missing space after comma in vma_expand_up macro

[Lorenzo Stoakes (Oracle)]

On Tue, Mar 24, 2026 at 02:29:11PM +0400, Giorgi Tchankvetadze wrote:
> Fix minor style inconsistency in macro parameter list to match
> kernel coding style.
>
> No functional change.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>

This is fine as an early patch but as Pedro said we usualllly don't take these
unless you happen to be touching that bit of the code anyway (or code near it
etc.)

But it's fine so:

Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>

> ---
>  mm/mmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 843160946aa5..37414e4ea362 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1001,12 +1001,12 @@ struct vm_area_struct *find_extend_vma_locked(struct mm_struct *mm, unsigned lon
>
>  #if defined(CONFIG_STACK_GROWSUP)
>
> -#define vma_expand_up(vma,addr) expand_upwards(vma, addr)
> +#define vma_expand_up(vma, addr) expand_upwards(vma, addr)
>  #define vma_expand_down(vma, addr) (-EFAULT)
>
>  #else
>
> -#define vma_expand_up(vma,addr) (-EFAULT)
> +#define vma_expand_up(vma, addr) (-EFAULT)
>  #define vma_expand_down(vma, addr) expand_downwards(vma, addr)
>
>  #endif
> --
> 2.52.0
>

Cheers, Lorenzo

Re: [PATCH] mm: mmap: add missing space after comma in vma_expand_up macro

[Giorgi Tchankvetadze]

On Tue, Mar 24, 2026 at 3:07 PM Lorenzo Stoakes (Oracle) <ljs@kernel.org> wrote:
>
> This is fine as an early patch but as Pedro said we usualllly don't take these
> unless you happen to be touching that bit of the code anyway (or code near it
> etc.)
>
> But it's fine so:
>
> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
>

Thanks Lorenzo and Pedro, for the review!
Sorry for the noise, won't happen again.

Giorgi