From: Yinghai Lu <yinghai@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tang Chen <tangchen@cn.fujitsu.com>,
Bob Moore <robert.moore@intel.com>, Lv Zheng <lv.zheng@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Thomas Renninger <trenn@suse.de>,
Jiang Liu <jiang.liu@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>,
mina86@mina86.com, gong.chen@linux.intel.com,
Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>,
lwoodman@redhat.com, Rik van Riel <riel@redhat.com>,
jweiner@redhat.com, Prarit Bhargava <prarit@redhat.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
yanghy@cn.fujitsu.com, the arch/x86 maintainers <x86@kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH part4 4/4] x86, acpi, numa, mem_hotplug: Find hotpluggable memory in SRAT memory affinities.
Date: Fri, 9 Aug 2013 17:12:26 -0700 [thread overview]
Message-ID: <CAE9FiQW3+hrBA9e7DEeSLqwjaUzAkdox78aUpqEMxXEPH6onWQ@mail.gmail.com> (raw)
In-Reply-To: <520581BF.5080404@zytor.com>
On Fri, Aug 9, 2013 at 4:56 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 08/09/2013 04:53 PM, Yinghai Lu wrote:
>> On Fri, Aug 9, 2013 at 4:43 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>>> On 08/09/2013 04:39 PM, Yinghai Lu wrote:
>>>>>>
>>>>>> Also parse srat table two times looks silly.
>>>>>
>>>>> By parsing SRAT twice, I can avoid memory allocation for acpi_tables_addr
>>>>> in acpi_initrd_override_copy() procedure at such an early time. This memory
>>>>> could also be in hotpluggable area.
>>>>
>>>> You already mark kernel position to be not hot-plugged, so near the
>>>> kernel range should be safe to be put override acpi tables.
>>>>
>>>> also what I mean parse srat two times:
>>>> parse to get hotplug range, and late parse other numa info again.
>>>>
>>>
>>> Doing two passes over a small data structure (SRAT) would seem more
>>> sensible than allocating memory just to avoid that...
>>
>> for x86 there is some numa info discovery path, and there are chance
>> srat is wrong but still have hotplug range there, or numa finally is using other
>> way or not used. Inconsistency looks weird.
>>
>> numa_meminfo is static struct, we have way to get final numa info early enough
>> before we need use memblock to alloc buffer with it.
>>
>
> Now, for kernel-generated data if you can define a sensible maximum you
> can put it in brk, if not, you have a serious problem.
Yes, that could be even better, we just can numa_info parsing early but just
make them to use brk if it need extra buffer.
In the way we may not need to split things to two steps or two pass etc.
Yinghai
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-08-10 0:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 9:41 [PATCH part4 0/4] Parse SRAT memory affinities earlier Tang Chen
2013-08-08 9:41 ` [PATCH part4 1/4] x86: Make get_ramdisk_{image|size}() global Tang Chen
2013-08-12 14:25 ` Tejun Heo
2013-08-08 9:41 ` [PATCH part4 2/4] x86, acpica, acpi: Try to find if SRAT is overrided earlier Tang Chen
2013-08-08 9:41 ` [PATCH part4 3/4] x86, acpica, acpi: Try to find SRAT in firmware earlier Tang Chen
2013-08-08 9:41 ` [PATCH part4 4/4] x86, acpi, numa, mem_hotplug: Find hotpluggable memory in SRAT memory affinities Tang Chen
2013-08-08 16:41 ` Yinghai Lu
2013-08-09 9:32 ` Tang Chen
2013-08-09 23:39 ` Yinghai Lu
2013-08-09 23:43 ` H. Peter Anvin
2013-08-09 23:53 ` Yinghai Lu
2013-08-09 23:56 ` H. Peter Anvin
2013-08-10 0:12 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQW3+hrBA9e7DEeSLqwjaUzAkdox78aUpqEMxXEPH6onWQ@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=jweiner@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lv.zheng@intel.com \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=trenn@suse.de \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yanghy@cn.fujitsu.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).