From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84AFCC71136 for ; Fri, 13 Jun 2025 20:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2299E6B007B; Fri, 13 Jun 2025 16:36:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D9F16B0089; Fri, 13 Jun 2025 16:36:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C9256B0092; Fri, 13 Jun 2025 16:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E1DD96B007B for ; Fri, 13 Jun 2025 16:36:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8C5EC1A1237 for ; Fri, 13 Jun 2025 20:36:42 +0000 (UTC) X-FDA: 83551535844.11.A91CE5B Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf04.hostedemail.com (Postfix) with ESMTP id A47FF40005 for ; Fri, 13 Jun 2025 20:36:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=U2XuhCge; spf=pass (imf04.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749847000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9y/A/honPhmFr4lSoVYSv+uKbj6HRcW5lWe22QcZ78E=; b=OUSqnEkEPgo8lD/EjLwGEQ94r95XIsvsEIVtM0aLI0a2XFxHHuJHNa0clnCJOqUMuZDQjV NNzweJe0UvwfWBLOztS2BMU9m1+rWur5k5lyBrs87BAdhtg725hOfMOBDz6i8ID/nrJP1s CW8J9J2+WF7hU3Jtt7PjmfQhrKhYbbg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=U2XuhCge; spf=pass (imf04.hostedemail.com: domain of andrii.nakryiko@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=andrii.nakryiko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749847000; a=rsa-sha256; cv=none; b=zv5hVkziYEWQIjjQ0Z1PjsQv1ikCqdSNicwh6yF1eQdMOpnx2zTfEFb/wt+UB4dEb0L6wN ELWBUqIDw11HnqBhSndu3pjm/OemLTEzAfP7lsDcTF6aVQq77C82opD1F2q5XNuIMQvzBE zY9o/Y7GmyY6U5TFCqoFuu0HDYmNTs4= Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-b3182c6d03bso314787a12.0 for ; Fri, 13 Jun 2025 13:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749846999; x=1750451799; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9y/A/honPhmFr4lSoVYSv+uKbj6HRcW5lWe22QcZ78E=; b=U2XuhCgev85DX4DUnqcjpBtwmRz51jBQIdGpuqWe7biycqyJ/81Ug7tKpcAaQzHcwv cmvk9Y4KSCztfpOeAL5yG5xs6P9yXT2/cJi+MYEbFhSTYvlLGtjYM3bWVY0Zu1uT5u6H Ewq+kxjdTuYQ/lpAx8qhpaCl4LBfAo5/eKP0+uSbgLj3hHjyPD2hf2jCEQPHHYrYBunA 1Rw3gJCX+KJ9h51bqsQsaG0IlL3tvmLV+yBI6qX/5Kh3RZEEtKJbSL6b8hNI8M50xdjb 52t42ppyZLw3QrFUZ4HWqcHuZYMeCMvDVf2oxdlPktugN42BL7yKaz5xp+D7/D9+jG0R n9CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749846999; x=1750451799; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9y/A/honPhmFr4lSoVYSv+uKbj6HRcW5lWe22QcZ78E=; b=dqhfmC9v0rDjvyaoXtfruNizjV+2cwVSAD5pSwOFltpHDYcxcs8igsz2dQnV9G7ZI3 UJgN3QIY+O9K1lNuFf3YtLqmOYHAFku+bjdedWVU4Sj0h/hk8EWwkST875EHIDOGkAdk 7VJpo+6Ba9jDEx5uDVHOP6m9VCArY4gG/CiXChDYQEenRnDjGrS6OHcjJc83bNDRQnVa 6jTV0wRqFX892K9CrPDISGznMyybm3m773NYKjCXupCL82Y79uh9IoK8mAd0ddzgnEPl cQpCqKhujFWk8LH9WwhtJanOfhM0PGSL+4DP00te4pd6flArFU9PhGxpmDW9/6Cd2GrX ucQw== X-Forwarded-Encrypted: i=1; AJvYcCUxsTOoJMzMdYeqOe6tEpbUo+c4lW5NdHkAf17CViVIoZq8HktHDx06vtF0PesNu7skUKguQvgeqw==@kvack.org X-Gm-Message-State: AOJu0YwpWnPtXiG1e0bKMSMRAhwtjMHbV1zCoUJ1G8fzC66z4DAd0lda gxzCM6hEvwLBFoPZFaZhEfIw2/lcvbKuSUbIqcA9UzQAh+jDjXmvaPipTmOQtdX4CGVbNVoZNQh iKOWuCNDGA1RuqXvyvsMEs0QM4mPpA8g= X-Gm-Gg: ASbGncseOPJUwknG8uKLKga0oLWK/5h89zYP3+kH58zqfWqF4WuMwtp6kFNDV5pZI3A 94ZTv+d+sI8BLc8hUsAdvN4E0tPl/8+xyzNcJjn3CHa6K3dX4QPIMIKoAt4/aijd2WBXKMsDoeI XiSszVM3giltGKfmIwOmnLOi/d+akX8EuYzJc1m6ve4zLO7HOTlVXfXIDyFR4= X-Google-Smtp-Source: AGHT+IE+doNLPK7iQGfmHK2aMnyGWiCbAU7ZVE0TGsJ4ZiOD4WmzWHJdIsobeerDU3u3LIVga2Y0ZGSbz/IF/sJwSKQ= X-Received: by 2002:a05:6a20:734d:b0:1ee:efa5:6573 with SMTP id adf61e73a8af0-21fbd475bc7mr1113173637.8.1749846999305; Fri, 13 Jun 2025 13:36:39 -0700 (PDT) MIME-Version: 1.0 References: <20250604231151.799834-1-surenb@google.com> <20250604231151.799834-8-surenb@google.com> In-Reply-To: <20250604231151.799834-8-surenb@google.com> From: Andrii Nakryiko Date: Fri, 13 Jun 2025 13:36:26 -0700 X-Gm-Features: AX0GCFvv2DgZg91WNc7kjHPmacufJlE4-r5R7dF4S5nPd7EiZImIO8808EQSIdY Message-ID: Subject: Re: [PATCH v4 7/7] mm/maps: execute PROCMAP_QUERY ioctl under per-vma locks To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 94sd7wnnzir7y9ar378zxgbitdmhda6d X-Rspamd-Queue-Id: A47FF40005 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749847000-983928 X-HE-Meta: U2FsdGVkX1999d5aupabVtlvF41ksxZv+qsh2E3zzu7MKsCfgXTQ7O3sL3jJWQxeYC+nr30KtLlZc1mZQ2azO2ZhtkPMqdWzyZyFFkRmQOCtCYXezpsN+Jqa3nEXjkDvl+U7ZszQihwcxgqYXNWYbp6RH4nCSOQFyXFrkNLqZC/inn/MO6Mx9+LY5CvvkfvVWtP7ROlVdRFnATr861/UFLproyPn6BQL61F4jTY4qkhrFTjQupEjQ35RK9LhTanIiyXXTb+dw5oYwE0Rbr3CYbeevWWlqp3A5P8kem52canAoQV6cRlPCKHWAsCA+WCUyxfhp+UCoQ8QE19+LeJNtAJSREgdAu5xVmIEfJvOqMg+uggY+2f4sogHpAQahYSjhKPLzEzexUYaE/M9xsMIPW1zB9Jvz/BxOz88CXMUNhMLeL6wcfaQPmM/laJ7wBoCJaSpwkn6lQFosKP+3NnoO7/U4ujEMVIY+WOST/XXbVnOF856X1jlgsUZXRMEgcNYf819NUVJ7Sk2SezN6c326WiJpdrw0sJ5KPy/KFLYfiVycpouLkESGtrS8DNusMxyazQxoltlexE+IiCjKxnteplXuOSDr9TOTAtIj/MD6PDF22o97Ba6PBSkzSaYVoroxy2qrOrnTgKRVXMkDc++60Va3h5DhcW80gg7XgXlicepGySTWggVbNjo5h8TpraqQ/bjyn6H1OOcX5E/rbpfeRBXvSuDsNx6TdZlBX5gR77L39gVz9W3O6Nsda5XuHicN4CLRp+k4tUSjM0V2PqI8d2+HhTpzgcpmdpuV/289ZYg3xVUS/pJ9GPlY6KurN2VptcsJuJlwjGsV6WZgdFVVnfm+ENQQFrBQ+swoSTI7w9piNpW6seUiLt8IQ1myj8rNZ2gFUCPa6hGjS2h1DcGfYVPxCrZfbXyCybY6B1vZCuruvzxd+PaS0JpDQkqM2gR+WJls/6sdMge4E5VYqm eka6ebnx DEuMkMCH19WSPg0L76sw3EueXiOWRz0CUwenfZSGz9CQ+lNG3hsr6ItJliQ5bFnQV55oNqZtwVEogJbwj1unCP4lb4UXdgkNhNmRg6Z9mxPnwiQ0UmgT2NUa9T78l6eTItIcK9xoWjxCM77Wo01/jG6ezFR4PXXAKySu5P6aMHXsOqmyNYCigRffLYv3wZmB1dSTPSZHYo1/GCgeC3zaV9WuEoKuV4oBUVfUSecdkfbK90xAMUSX2ypDamIPF6Lm6DVc9fVp5nPpmYkw/npP/q8YYW4A0UuPY7ic0ROARHhpf+ngzMRXmZk5dp5Z3S7VBoJD7hzrJFRhhmY3n2rBpiKSyyRX18uD8L3f/YEQ8wNKrJ1jPW6K/7t56+qizAfwKfej+35rOtw320nzqNcmgPKJzM+27hdODVT2LQgcLJXsfSdnNFz6fFJTrk2KUK1Qx9lC7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 4, 2025 at 4:12=E2=80=AFPM Suren Baghdasaryan wrote: > > Utilize per-vma locks to stabilize vma after lookup without taking > mmap_lock during PROCMAP_QUERY ioctl execution. While we might take > mmap_lock for reading during contention, we do that momentarily only > to lock the vma. > This change is designed to reduce mmap_lock contention and prevent > PROCMAP_QUERY ioctl calls from blocking address space updates. > > Signed-off-by: Suren Baghdasaryan > --- > fs/proc/task_mmu.c | 56 ++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 44 insertions(+), 12 deletions(-) > The overall approach in this patch set looks good to me! PROCMAP_QUERY changes specifically are pretty straightforward, nice. LGTM: Acked-by: Andrii Nakryiko And for the rest of the changes you seem to be in good hands, so I'll just be waiting for the final thing to land, thanks for working on this!