From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id A251C6B004F for ; Sat, 17 Dec 2011 19:49:22 -0500 (EST) Received: by ghrr18 with SMTP id r18so3340442ghr.14 for ; Sat, 17 Dec 2011 16:49:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1323875693-3504-1-git-send-email-tm@tao.ma> References: <20111213164507.fbee477c.akpm@linux-foundation.org> <1323875693-3504-1-git-send-email-tm@tao.ma> Date: Sun, 18 Dec 2011 09:49:20 +0900 Message-ID: Subject: Re: [PATCH v3] vmscan/trace: Add 'file' info to trace_mm_vmscan_lru_isolate. From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Tao Ma Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton On Thu, Dec 15, 2011 at 12:14 AM, Tao Ma wrote: > From: Tao Ma > > In trace_mm_vmscan_lru_isolate, we don't output 'file' > information to the trace event and it is a bit inconvenient for the > user to get the real information(like pasted below). > mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32 > nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > > 'active' can be gotten by analyzing mode(Thanks go to Minchan and Mel), > So this patch adds 'file' to the trace event and it now looks like: > mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32 > nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 file=0 > > Cc: Mel Gorman > Cc: Minchan Kim > Cc: Rik van Riel > Cc: Johannes Weiner > Cc: KAMEZAWA Hiroyuki > Cc: KOSAKI Motohiro > Cc: Andrew Morton > Acked-by: KOSAKI Motohiro > Reviewed-by: KAMEZAWA Hiroyuki > Signed-off-by: Tao Ma Andrew pointed out that trace_mm_vmscan_memcg_isolate is out , Otherwise, Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org