From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8C9C61DA4 for ; Mon, 6 Feb 2023 06:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC6DE6B0074; Mon, 6 Feb 2023 01:17:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A76C76B0075; Mon, 6 Feb 2023 01:17:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93E186B0078; Mon, 6 Feb 2023 01:17:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 865646B0074 for ; Mon, 6 Feb 2023 01:17:46 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 54D35120B2B for ; Mon, 6 Feb 2023 06:17:46 +0000 (UTC) X-FDA: 80435860932.04.99A08F0 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf28.hostedemail.com (Postfix) with ESMTP id ACD8EC0002 for ; Mon, 6 Feb 2023 06:17:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=YXvWfgXK; spf=pass (imf28.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.217.41 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675664264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oCbIkGsR/i9GGED+PeoqWkhVcXF5/sJXuBW46dRtiTs=; b=AX2BBS1FyOe56f+fMNxVAhrCi1toC+9dzGLPfevrnHAHgstOU4HroJdQq4b1j9Hg2xRXZF ZRyM0Qb62hqoj4ByqzkUZMULdd6eqO1gWCmf0gAEBf9lAEtcbVOugrXLTLR8Zt4PFv7Rn0 C5IxZdArEmAzffBlwOa5NIrSr+p182E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=YXvWfgXK; spf=pass (imf28.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.217.41 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675664264; a=rsa-sha256; cv=none; b=rR728KfIfUFkP3DUmwm2wAsBHGmv2mP4Q3vQEUuovvAKMU7Z6tPJzj2wI68TilMNRoZ7FZ ewkuVcWoOk4gzpl+vUWUCjLNJMDRpIGdV57f5fhMt8TQ3HAeb1f7F5CYviz0muMYc9PyDO AicX/G9GiBhLlPRGsrPV/vxc5s7Tfsc= Received: by mail-vs1-f41.google.com with SMTP id m1so9728067vst.7 for ; Sun, 05 Feb 2023 22:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oCbIkGsR/i9GGED+PeoqWkhVcXF5/sJXuBW46dRtiTs=; b=YXvWfgXKCu0uIwCXxm4jAs6wezXdu3WB35GxfZGQseVFFmjxXbqqWBRwVyTzgMvdDA zXXpU8oXGVXRRMVfcrCWFPzo9vsv/0QMPnSiTgTq2ArJMLq4WKeWLnrYbC4Ob8nVcNVM K7DYXQxxBwBqmaehbWrU2w8gISgvZGT/I67Fs/E2ok9YlPJqOSrjxdTJt7t7JNpORTuY z4uMQbZcFWqPwjqKpxPheb4zqqvwf3oBz1JVQSThPHPK5mH/8gu+5jUg6KSpCPoZxtWl 9D05ZpVpG2yjgqZHW3Vbw6JFJFgVP8ejwQNiYvhelm3aVMD7VvOjIlfu7/Zq6aGCiZbV VIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oCbIkGsR/i9GGED+PeoqWkhVcXF5/sJXuBW46dRtiTs=; b=0rnUCqUECHWXR90BzgXr3tNGMwqUgIotXj78i3KBeRIG2A8KVTmJ9D7+mX184Cz5Qk gSeD9Z/UcjkksMqLo4OiXhHUPn9K9BSHCR32Rp/RLM/d3yyOMVKaLSAVdXFFqaxmuOcO JpGS405XPyx3ilvYCqD3SBoBJXJObfpn7ooj/wynOwEbphLTT9U7I14o8l34QNO5C/q3 JTPrSdn/3alVUIp/5COkJ/T5IPBJYzmiUtPl4DW7kD4Cc/UIJVFH2KKLJSqtaE777Yjx bZPZXripSjJncZWunWgRKzK6xvduA71vEs8H/vq0a5xQCWpMOTKOGoPf38H2Eysc9z78 7cUw== X-Gm-Message-State: AO0yUKWYRyMHAeIgnK3pyXVmfeEz2ep8k5HUgKKS/HnU5Wl+Tkg2tZ10 s6zJ7eH0GDx+ugTzgn4bxKAJy7TcqXPpcDvyqTNRlQ== X-Google-Smtp-Source: AK7set+QaKxOl5Eq1HyGyCzA9bpv05T31dNrk8Crvv6Cedn4iwLfdcd87Sby8mB58ngkwFbg0Pr/sraGEIL+mIdClek= X-Received: by 2002:a67:c599:0:b0:3f9:6368:48b8 with SMTP id h25-20020a67c599000000b003f9636848b8mr2582845vsk.41.1675664263811; Sun, 05 Feb 2023 22:17:43 -0800 (PST) MIME-Version: 1.0 References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> <20230203-get_kernel_pages-v2-4-f1dc4af273f1@intel.com> In-Reply-To: <20230203-get_kernel_pages-v2-4-f1dc4af273f1@intel.com> From: Sumit Garg Date: Mon, 6 Feb 2023 11:47:32 +0530 Message-ID: Subject: Re: [PATCH v2 4/4] mm: Remove get_kernel_pages() To: Ira Weiny Cc: Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, Jens Wiklander , "Fabio M. De Francesco" , John Hubbard , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: ACD8EC0002 X-Rspam-User: X-Stat-Signature: sskinz835ckt8346ngquas9q7esfj1h6 X-HE-Tag: 1675664264-215361 X-HE-Meta: U2FsdGVkX18sU4fTDtsLMWux8X39DzOTyvqa4tffA5GLJM21Wg81A1Iv1QZgnFeRE8SKPQRSHDur7DuaTJNGHl25HmVhPerdzfq+6CL/e3xv4MiZlLNbuusRVjUy5a6IFW+khkzyxAAzLM44ZDCRL0VPnRtm2s/5jG7FYjEToDB7EPDEQfCCgo7N/J0F3O+4zfQep7QClJvpTws6Iizs/tnVD0ZGo7KtsRxKfxQwlr60Rczh/BQiYPdIKT0P4RubExDoY26I6wnP0NoArB1lY6iezKZCeBdIcPTIYIQJ7aay6UJT4ov5TlJZjgTaWMBXuoY/TU9Trv8RR9mEvCcCtDPNcaGVbD6kECmpcvBgQGHGR4Z0tsb42ozgqPnuVKwcQjjcH2w5OEkvQDCZVqyTWeb3Oyw93dKOlKsT9K5dCM9YA67JSZm9yK2b/W5SVyV8YBqM1FhaimLWeIr9WuuZ9g/76hPs1dCoP8KRSmq9HvZLiIwwb1zZzHR2vCjc6FJEu3Q9pxjwkTtrpbBMGlaz2oA2nsZdqboleA+dBP4Dxtkuiv1yR1WUI0zbOSM3QSsr5k0FLXlY6oU18OAeqDwMSM9QDPZGEYoB7Z4jIcqLjDv8lJlIu2a+MU9OkcdopBDaJ5oqEwsAQuG3NMV/theB8wPrNORmZPhHEnqRq+wQkTQ2pvIz/nOT5ODHenpAJpjDE9ZCRsJqIoGYRIOdS7nHDNg8HvAjzyhLkLQKlLbG5N2YbvNed8zDs+6m99hlRtZ3CEwA09L8DXUzZ87WxdBfCylHChoggGpKAmIv64I8xXhs+kAeC2XdQ4P96y1KZaSfS5gdyfrnwN3SsgtoGUn/mMS9t+/B8u+jEiyG9JHeySt/x9RYqvoNDS+p59Bk7BX+hkqfop+A+AAaMYRPHFCyVJFF2aLHcRbGy6TDxsBhBKmAvV93wenbMyVUxlz//hncGFheLcoM+LcuwytFRtk hxGAYwyn tjhR6gKtPaEsG04vfJOt7NHBLZQx0TDNPf3G7ZnzueIbZet+2ESIoni2oEddFwaBPPMgHkRBz+tec1pYD7/a1Wt8RyF39gelT8PcTuAQeCrshjtaE2JypI98VNYkvSptru0pDFeZ/48TYdmHpv5sCOncbQQaVzSiqMBKBqv82W+UCqfdtnJGSmxX0tXED2lE9HCm/aQVRj8GgyCizz4nrRf6p9UWh9A88GlY4I9Okx9uJey8Hwym9u7ZhEqr8VHTK/fa5I/H/ADFzCpwWj2FM4UouQ/W0bM2s+WsU11sTSbAsa8xshE2RhtmUI3+8UWpB5TTDODHxDxkpu9XtkfmomkZhEIkxf7XOUDc5TRvpyvjcAfuX9IEp3Pt7mdMWmIYCyKVx/wFlvQoty2xpF7p5Ec+4aPJchjXEhE0r/+W6iFQdQqX2qDRMN5TuagqwAgtrax0tGdvuoEgoEX7c6ZVa45SkZI9Zb9R3ommDbG1rAsCQH6Q++PzP/mm4BeYbTh7LX1eQoLSop0Poo+FqcpAZm1mQXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Feb 2023 at 09:36, Ira Weiny wrote: > > The only caller to get_kernel_pages() [shm_get_kernel_pages()] has been > updated to not need it. > > Remove get_kernel_pages(). > > Cc: Mel Gorman > Cc: Al Viro > Cc: "Fabio M. De Francesco" > Cc: Christoph Hellwig > Cc: Andrew Morton > Acked-by: John Hubbard > Signed-off-by: Ira Weiny > --- > include/linux/mm.h | 2 -- > mm/swap.c | 30 ------------------------------ > 2 files changed, 32 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8f857163ac89..2041e6d4fa27 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2095,8 +2095,6 @@ int __account_locked_vm(struct mm_struct *mm, unsigned long pages, bool inc, > struct task_struct *task, bool bypass_rlim); > > struct kvec; > -int get_kernel_pages(const struct kvec *iov, int nr_pages, int write, > - struct page **pages); > struct page *get_dump_page(unsigned long addr); > > bool folio_mark_dirty(struct folio *folio); > diff --git a/mm/swap.c b/mm/swap.c > index 70e2063ef43a..4c03ecab698e 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -158,36 +158,6 @@ void put_pages_list(struct list_head *pages) > } > EXPORT_SYMBOL(put_pages_list); > > -/* > - * get_kernel_pages() - pin kernel pages in memory > - * @kiov: An array of struct kvec structures > - * @nr_segs: number of segments to pin > - * @write: pinning for read/write, currently ignored > - * @pages: array that receives pointers to the pages pinned. > - * Should be at least nr_segs long. > - * > - * Returns number of pages pinned. This may be fewer than the number requested. > - * If nr_segs is 0 or negative, returns 0. If no pages were pinned, returns 0. > - * Each page returned must be released with a put_page() call when it is > - * finished with. > - */ > -int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write, > - struct page **pages) > -{ > - int seg; > - > - for (seg = 0; seg < nr_segs; seg++) { > - if (WARN_ON(kiov[seg].iov_len != PAGE_SIZE)) > - return seg; > - > - pages[seg] = kmap_to_page(kiov[seg].iov_base); > - get_page(pages[seg]); > - } > - > - return seg; > -} > -EXPORT_SYMBOL_GPL(get_kernel_pages); > - > typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio); > > static void lru_add_fn(struct lruvec *lruvec, struct folio *folio) > > -- > 2.39.1