From: Sumit Garg <sumit.garg@linaro.org>
To: Will Deacon <will@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period'
Date: Thu, 3 Dec 2020 17:26:38 +0530 [thread overview]
Message-ID: <CAFA6WYNd_dp1a0Q3a9D5q2bpZqmVCT18oT5WwEMQ-e5oBfjk5Q@mail.gmail.com> (raw)
In-Reply-To: <20201203113801.GB31188@willie-the-truck>
On Thu, 3 Dec 2020 at 17:08, Will Deacon <will@kernel.org> wrote:
>
> On Thu, Dec 03, 2020 at 03:13:11PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 0eedceafd3a63fd082743c914853ef4b9247dbe6
> > commit: 367c820ef08082e68df8a3bc12e62393af21e4b5 [7808/9562] arm64: Enable perf events based hard lockup detector
> > config: arm64-randconfig-r023-20201203 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=367c820ef08082e68df8a3bc12e62393af21e4b5
> > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > git fetch --no-tags linux-next master
> > git checkout 367c820ef08082e68df8a3bc12e62393af21e4b5
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > aarch64-linux-ld: Unexpected GOT/PLT entries detected!
> > aarch64-linux-ld: Unexpected run-time procedure linkages detected!
> > aarch64-linux-ld: kernel/watchdog_hld.o: in function `hardlockup_detector_event_create':
> > >> watchdog_hld.c:(.text+0x68): undefined reference to `hw_nmi_get_sample_period'
>
> Looks like the Kconfig dependencies aren't quite right here.
>
> Sumit -- what do you think about the fix below?
>
Thanks Will for fixing this, it looks good to me.
-Sumit
> Will
>
> --->8
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7d3440770b14..fe0d30a749b6 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -170,7 +170,7 @@ config ARM64
> select HAVE_NMI
> select HAVE_PATA_PLATFORM
> select HAVE_PERF_EVENTS
> - select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI
> + select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI && HW_PERF_EVENTS
> select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && HAVE_PERF_EVENTS_NMI
> select HAVE_PERF_REGS
> select HAVE_PERF_USER_STACK_DUMP
prev parent reply other threads:[~2020-12-03 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 7:13 [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period' kernel test robot
2020-12-03 11:38 ` Will Deacon
2020-12-03 11:56 ` Sumit Garg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFA6WYNd_dp1a0Q3a9D5q2bpZqmVCT18oT5WwEMQ-e5oBfjk5Q@mail.gmail.com \
--to=sumit.garg@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).