linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period'
@ 2020-12-03  7:13 kernel test robot
  2020-12-03 11:38 ` Will Deacon
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-12-03  7:13 UTC (permalink / raw)
  To: Sumit Garg; +Cc: kbuild-all, Linux Memory Management List, Will Deacon

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   0eedceafd3a63fd082743c914853ef4b9247dbe6
commit: 367c820ef08082e68df8a3bc12e62393af21e4b5 [7808/9562] arm64: Enable perf events based hard lockup detector
config: arm64-randconfig-r023-20201203 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=367c820ef08082e68df8a3bc12e62393af21e4b5
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 367c820ef08082e68df8a3bc12e62393af21e4b5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   aarch64-linux-ld: Unexpected GOT/PLT entries detected!
   aarch64-linux-ld: Unexpected run-time procedure linkages detected!
   aarch64-linux-ld: kernel/watchdog_hld.o: in function `hardlockup_detector_event_create':
>> watchdog_hld.c:(.text+0x68): undefined reference to `hw_nmi_get_sample_period'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31365 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period'
  2020-12-03  7:13 [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period' kernel test robot
@ 2020-12-03 11:38 ` Will Deacon
  2020-12-03 11:56   ` Sumit Garg
  0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2020-12-03 11:38 UTC (permalink / raw)
  To: kernel test robot; +Cc: Sumit Garg, kbuild-all, Linux Memory Management List

On Thu, Dec 03, 2020 at 03:13:11PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   0eedceafd3a63fd082743c914853ef4b9247dbe6
> commit: 367c820ef08082e68df8a3bc12e62393af21e4b5 [7808/9562] arm64: Enable perf events based hard lockup detector
> config: arm64-randconfig-r023-20201203 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=367c820ef08082e68df8a3bc12e62393af21e4b5
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 367c820ef08082e68df8a3bc12e62393af21e4b5
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    aarch64-linux-ld: Unexpected GOT/PLT entries detected!
>    aarch64-linux-ld: Unexpected run-time procedure linkages detected!
>    aarch64-linux-ld: kernel/watchdog_hld.o: in function `hardlockup_detector_event_create':
> >> watchdog_hld.c:(.text+0x68): undefined reference to `hw_nmi_get_sample_period'

Looks like the Kconfig dependencies aren't quite right here.

Sumit -- what do you think about the fix below?

Will

--->8

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 7d3440770b14..fe0d30a749b6 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -170,7 +170,7 @@ config ARM64
 	select HAVE_NMI
 	select HAVE_PATA_PLATFORM
 	select HAVE_PERF_EVENTS
-	select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI
+	select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI && HW_PERF_EVENTS
 	select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && HAVE_PERF_EVENTS_NMI
 	select HAVE_PERF_REGS
 	select HAVE_PERF_USER_STACK_DUMP


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period'
  2020-12-03 11:38 ` Will Deacon
@ 2020-12-03 11:56   ` Sumit Garg
  0 siblings, 0 replies; 3+ messages in thread
From: Sumit Garg @ 2020-12-03 11:56 UTC (permalink / raw)
  To: Will Deacon; +Cc: kernel test robot, kbuild-all, Linux Memory Management List

On Thu, 3 Dec 2020 at 17:08, Will Deacon <will@kernel.org> wrote:
>
> On Thu, Dec 03, 2020 at 03:13:11PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   0eedceafd3a63fd082743c914853ef4b9247dbe6
> > commit: 367c820ef08082e68df8a3bc12e62393af21e4b5 [7808/9562] arm64: Enable perf events based hard lockup detector
> > config: arm64-randconfig-r023-20201203 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=367c820ef08082e68df8a3bc12e62393af21e4b5
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 367c820ef08082e68df8a3bc12e62393af21e4b5
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    aarch64-linux-ld: Unexpected GOT/PLT entries detected!
> >    aarch64-linux-ld: Unexpected run-time procedure linkages detected!
> >    aarch64-linux-ld: kernel/watchdog_hld.o: in function `hardlockup_detector_event_create':
> > >> watchdog_hld.c:(.text+0x68): undefined reference to `hw_nmi_get_sample_period'
>
> Looks like the Kconfig dependencies aren't quite right here.
>
> Sumit -- what do you think about the fix below?
>

Thanks Will for fixing this, it looks good to me.

-Sumit

> Will
>
> --->8
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7d3440770b14..fe0d30a749b6 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -170,7 +170,7 @@ config ARM64
>         select HAVE_NMI
>         select HAVE_PATA_PLATFORM
>         select HAVE_PERF_EVENTS
> -       select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI
> +       select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI && HW_PERF_EVENTS
>         select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && HAVE_PERF_EVENTS_NMI
>         select HAVE_PERF_REGS
>         select HAVE_PERF_USER_STACK_DUMP


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-03 11:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-03  7:13 [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period' kernel test robot
2020-12-03 11:38 ` Will Deacon
2020-12-03 11:56   ` Sumit Garg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).