From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC857C77B7A for ; Wed, 17 May 2023 07:53:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46E01900005; Wed, 17 May 2023 03:53:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F773900003; Wed, 17 May 2023 03:53:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BFAE900005; Wed, 17 May 2023 03:53:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 18C5B900003 for ; Wed, 17 May 2023 03:53:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D674D1C6FBB for ; Wed, 17 May 2023 07:53:04 +0000 (UTC) X-FDA: 80798981088.19.A08A18E Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 1533720002 for ; Wed, 17 May 2023 07:53:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=q8TwWLY7; spf=pass (imf13.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.222.53 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684309983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WyFLOiSt+FtzfE39FeHW08WFhb9J+jn2vWhFKPP6Mwg=; b=A+f3nNZnSCRVuBGxyoWPRLjReLlkPI9K1ERaBME8vuqNoX1OmQJXR06FO/g5WC6FJoLTUr m8TjISOMfvr9o27ROSeO5fTz8m35zoyxyh9bf3kYk/ZdDzOHiebHiknNRGKfIBSXbnzbMK LUB0VVfQ5hyeDsO/hH57bP+WIV0ge8w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684309983; a=rsa-sha256; cv=none; b=zpbdvZXVgWUvWn3hHOw7BiMsjyvR2ugIWwPTEbQbJ8BwgFYf13y16XkhfE7SUIkkekzupH uw0mRT9bwP07rZSY9vUU+AaMEMBAYdFNtISTAtZv7WTX6XiLJqxYo8epVH1jJNjI3YLwAO nURFmDG2SVXzdUQr9w9tBES0+38junw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=q8TwWLY7; spf=pass (imf13.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.222.53 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-77d508ba6faso186564241.2 for ; Wed, 17 May 2023 00:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684309982; x=1686901982; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WyFLOiSt+FtzfE39FeHW08WFhb9J+jn2vWhFKPP6Mwg=; b=q8TwWLY79Hyh3bjyTmB1ysfHFO1zMQYNMRu8iCGOMn/jUkAXM80ceXbdrj9PIy6Npf Kid149tAN7SKvMEEGX+yt3CRBD6/EBuIrXa/6RNYjdX2u69WObMU6SMdqGb++SKhp12X hgVFwidPFtTj16pO3vGJbt8a+gh8aKF6OwStMms+fAcsGHQtD8FWiZ8lt3zA0lZ18Wbo saA/ZZNAhj3k3j17r5MPynbxkPMengIXzx7uSDqD/sxLXKZiK6h+1UqVgr9biHPD7MOY +W2gTmQ+lO24NaFgCVi9NAIuzNEQP0SCbyzaq06Iljhb95I+fVKP1DxFAfwb3DdkW1D2 4EMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684309982; x=1686901982; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WyFLOiSt+FtzfE39FeHW08WFhb9J+jn2vWhFKPP6Mwg=; b=jDp1vhBzmyT9p7L45vp+WUVQwP9hGLi/3thYJD5D4SVlUcXfME4O/Rwex0a4/hjjzF DKFTYh0v5sj5Ei98u1HUZjG41/Fvjr23ioTWDsw7cNtx7aR4I20Q5Lw6944SBMkIjPks yMq92uJh1A7qk+vfmFt5b+xvER9stHzAsV9IG4e2lprIUEqIpT0egN6uA2mHiu4b6gDm yHEvlkKFwyxvUczuCojdSJPc+PbrxMGhFlbzDjh1oXoHQEDONPX1veT5yFWuL1Wd9ia7 BEM1HONNR5Q575V/TFbjCQSfAeqKLcmbV3nHbeqG+ypSPXIns0e/SY7K5OWA6StBpSD6 uTBg== X-Gm-Message-State: AC+VfDwRm/+NAtqYTJDBVfh5hMaF729zsaf4gqkYIfU8KJOVoxdZHSPK pt8dBL59ssBrOTf3ZZ3z6/wE21QOlkYC4/Nz/1BpAw== X-Google-Smtp-Source: ACHHUZ7kdvCoiYGUDRXA0VpQ2rWsFU9JNMqBnmgZ0GZ6s8Q8KbJFCObn7U8FF6wlDvvnPZKguwQbMHKXd0vg3TnGxSE= X-Received: by 2002:a67:fc05:0:b0:436:105d:91f9 with SMTP id o5-20020a67fc05000000b00436105d91f9mr12642224vsq.21.1684309982106; Wed, 17 May 2023 00:53:02 -0700 (PDT) MIME-Version: 1.0 References: <20230517031856.19660-1-xiaoming.ding@mediatek.com> In-Reply-To: From: Sumit Garg Date: Wed, 17 May 2023 13:22:51 +0530 Message-ID: Subject: Re: [PATCH] tee: add FOLL_LONGTERM for CMA case when alloc shm To: Christoph Hellwig Cc: Xiaoming Ding , Jens Wiklander , Matthias Brugger , AngeloGioacchino Del Regno , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fei.xu@mediatek.com, srv_heupstream@mediatek.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1533720002 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: g1zqouz9k5i69qkakkg6gwgmkmx5rmzh X-HE-Tag: 1684309982-871765 X-HE-Meta: U2FsdGVkX1/6cLMg2BpLva5YqsgGlLe4ovu7KwG++QFokm3/CZcLDfQDtqxJZE5qTZQ0M0Qo55mCTKx4lnC+/1/MbNE0yBXReWhwgouuWuEYL7HMhV9+fGgHCKXVz/SoY2E2Gq7KEf4ViX8QbEuLkHShYeJ96KJZdvpryhc5wdxUmYWY0qI8ZkrcCM4AvJEJAiYcAUOXHjbGaGMYT75mD6+xWNR5dT9IvSXUoir40fnmmxPP1B2QbVWAw7tPxArh+yxT5X8Fe2D7jEPzXF4MNC1fVcJTkLTmzZvHtg3eRPkWbR75NjihVUZEz9uDPPhMs96IAZMr92RVwuWZ97sB1jGFsCUCdX7110VER2k9Db2tAJXwMRN47seSwRn673G5feeSQ9ifIRFTc0pCQfQd2uixzrjAjOLw3FoU7PWYaol+TdK2xal69Gh8c5yOoB98rSiYBB4EFJlKrfHYpdd+torU7s9morPrLozCAskSH4KCwnep+KnzZdWzjCx6tmONAX04YGsQNjKpL2vpzNAI6d2scHr/YCTC2JDfTX55iho7YTuJywiiZoy/nyzJbptO+UMf3iNKKNtLA9R3Dpl3YufbyevCLioWBdTgPtn6zomzqHjE4LagUp1McRipiw1yUAdtP1bB0VWoANa1m7CqXcqEK0iVHkvqoFyXyI8+l7N+eBtcz/XZEddX5WCom8+ajuwWDnPwnpYFhy6XppG00jrzVYhkOwH5pzU7aEPkW0TutCGpgGHUEufbXSStSb5JEC97z1Ao27ITsn+RdQgEC7XOqa3TCrdOd15Ozw0Ci3ndPb2Rkg5sJQTyYUtNOY4FYM3J/9TLFjphkUW4eybzis7jqX4+blFG393zbadaVyBAMKqdUZYjSa+1Qu2VZlc2uN+F8HaI8I8xGmJG/OaEhKFTwtDjuzEoZsw+LhmPUoPZUkGejksifoX4oGYN0osvtK8+f/dA3+gF/kvNxn0 rDL2eEq+ rqzXWjb568TOh8gEbrDQWiS7GNoSahcuDIsimO6ykaTIWqsZB9/pzL0jktOyb3RBPzmP7LAjh6h9wd3Ft+cvvwn4mcntJwTl9CBA3UUL1djsW6NTYWEKZoswt2icUqK3h+iegBH+0WqaGpyyY0cHRx9z+BgvkU6ZsD7UYmaF4VafqjO8qP51U3CDjUBgHGMnrQA/ZQCIlSMdMPrYua4F3qvjM+eCPQ4Iz7tsIxmwcHW6Do48WciW5NV1xXGVDOncUYTpMu5ZunXodUXtX+Rje2OLrpBWpIlMT5gJfnzpjc4vmt4tSYwosiJ0ugcKhun1LGk8xPvO5ueUS9S0IvLaA4ibe06sXEWdzpXY0WODvwc4kQ1BDuOnROU/g4crHN4dJASoYNPo+ajHqYFtAwY2BD+jmCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 17 May 2023 at 13:04, Christoph Hellwig wrote: > > > + u32 page_flag = FOLL_WRITE; > > > > if (!tee_device_get(teedev)) > > return ERR_PTR(-EINVAL); > > @@ -255,9 +256,11 @@ register_shm_helper(struct tee_context *ctx, unsigned long addr, > > ret = ERR_PTR(-ENOMEM); > > goto err_free_shm; > > } > > - > > +#if IS_ENABLED(CONFIG_CMA) > > + page_flag |= FOLL_LONGTERM; > > +#endif > > if (flags & TEE_SHM_USER_MAPPED) > > If this mapping is long live it should always use FOLL_LONGTERM. It depends on the userspace application needs. However, I think it should be safe to use FOLL_LONGTERM by default to serve cases like secure media playback. > > The ifdef does not make sense. Agree. -Sumit