From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85CFC5B559 for ; Fri, 6 Jun 2025 09:27:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ECED6B007B; Fri, 6 Jun 2025 05:27:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49E696B0088; Fri, 6 Jun 2025 05:27:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B3BB6B0089; Fri, 6 Jun 2025 05:27:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D0A96B007B for ; Fri, 6 Jun 2025 05:27:28 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5EFF85F8F0 for ; Fri, 6 Jun 2025 09:27:27 +0000 (UTC) X-FDA: 83524447734.06.C3FB392 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 676E14000B for ; Fri, 6 Jun 2025 09:27:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EdvVmRTe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ubizjak@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749202045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qAQ8mJSWYlTfWRB8Ep92WYLN2lrT5PO+Q1r4q7E7lCQ=; b=Hd0ILEx49cQ0Okwb/uQjMTwb4PaAJXfkNds7/VmvkSsqYt1x3zrEUQVU1Fn2KajPpQUO31 UJfONcNP/i5xWhBO1yRuFjfvGwZWNeASn41w3ReVVYKyVsPHVLm5s+IIqN4uQIJhq8zDGa FqjbDya7UgTUPepY1P4VNpqnFBgQACo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EdvVmRTe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ubizjak@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749202045; a=rsa-sha256; cv=none; b=eZ8Vpuo0Cnf5NDqkCF02MK294gzjoc7Y/6xvlMkK4CFCuWVoNRgZGxO0R1gro/ALjgG5ya 8Wd8sHDXzBBNbtP0X+wHhjKGtlr+vjsc+cVMJGrFjNEqob0i6PIXkD8WcmOQtMxoE91Pc8 3hSf7x3u/VnnKrK8ZiNcRWONYV6m8ao= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-32ade3723adso9071521fa.0 for ; Fri, 06 Jun 2025 02:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749202043; x=1749806843; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qAQ8mJSWYlTfWRB8Ep92WYLN2lrT5PO+Q1r4q7E7lCQ=; b=EdvVmRTevLeo7s7k5nh1W6SP/JrC4uxfHIzt057dLinyc9Kisl4Z0XIpfKqQVAGw/n BmTIJiukFHUCXbQb2Wi8+zwOeogbkBE3+6/ZhvQFB9RO5lH0q8sIPew0KB2yiMbPYqIV OffVyvrP0UZ3cQqmY0KaLwS846by1ZRRjxoQn7VKkCS/+ZNIyYxgvObz1cwnukcv7CmY 13c0NBeaC38rnREEuTUurT612IDvHlm8RdSOHQaS4x41iHCJNxeNTB/SfEV0P666X4pz q9JXB371e8RnLXEBVCL1pfH8TyAoYD/wx1aSQ0p5qyGugGbWKNOrnMCa/B6cYMHh2rIj eXAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749202043; x=1749806843; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qAQ8mJSWYlTfWRB8Ep92WYLN2lrT5PO+Q1r4q7E7lCQ=; b=NmXBnLoSq6o05Mz5iGZZS7vd43/eUITxFSgTVYY6BkCbXyWejSq2Jz3sFrmv5GC7UC Uw2+QCfc6SxfZc+Sc/ZetrWFY1EFr+rZTXVQKBBAVnnGzJhWqdi8gD+VlQSIE+yYlElv 80RETBki8OHB3fpV6cauU6FQbqEe8Txhjvo0xDaGuLNDftzNe5NiZvZoJoj5EBZeAKRy cvkA2vzdhNSnyQcPP7TxolREsUF6omanW4aSnFKjwTs9LqzPXwDaBGVbk+Q7M5IXZX2a vWuC9ezpo++CQx57GEw6DS7yIA8cIyX1xNLTd0kTGzszDG7qJKCwJG+PneFn/6lQyWj0 RSRw== X-Forwarded-Encrypted: i=1; AJvYcCUuj4OeHPcO2fyj/496zlY4r+qvYc/RI/+VLiu9X4+AlukhOpwkc/Yj2eXs2b9kHvCFHp8Y6o13YQ==@kvack.org X-Gm-Message-State: AOJu0Yzuu3Y+4MPHuWFF8kQE0N+CxNavRlHZc6cighcnlB9MmgcPy0QF ye28vFdydeX+2EiHAbZUmQCBxvlyu4SqvACjfmkzK/9C6X4PVNwBptmF6bvREkq9MKE94nDkBYl p4b1dhoFjJhOSwFhMaYl2yEm2kL2YuTs= X-Gm-Gg: ASbGnctrdkCNZTlOQi/JRH1DyGXFMeRVLnLgi0LLRrcwbZM3GgN7CxgdLHC07bMW0td GC9yLNFbyDDWK2Cw8V+3Z6BZZ+P4TQzBHDpqwAej3GhDEn+zVNCUZpkN9rA5NAGNH9Yshx4d+yX uPGQ+AhldOR6XNa4MECXUn0aE4GUwNDr0i X-Google-Smtp-Source: AGHT+IGUeijlpBN1uonipWsqdJg+nWSH/xMPJaX4H/+mQ0DOM4jhgZHNPYVM8V0AevFO7SK/JVaeJNVvlpd396frMbw= X-Received: by 2002:a05:651c:220a:b0:32a:8591:668f with SMTP id 38308e7fff4ca-32adfdd88abmr6163341fa.31.1749202043172; Fri, 06 Jun 2025 02:27:23 -0700 (PDT) MIME-Version: 1.0 References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> <9767d411-81dc-491b-b6da-419240065ffe@kernel.org> In-Reply-To: <9767d411-81dc-491b-b6da-419240065ffe@kernel.org> From: Uros Bizjak Date: Fri, 6 Jun 2025 11:27:11 +0200 X-Gm-Features: AX0GCFsBhLxdX-uCBdNC6NAFJUOZLU2V-9ugVfL-X7mjzETyRN9kjHa3cvoik3c Message-ID: Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] To: Jiri Slaby Cc: Dave Hansen , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu , Alexei Starovoitov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 676E14000B X-Stat-Signature: nk5mam9jeuxrgt8cmhpaocegsd1e4s6y X-Rspam-User: X-HE-Tag: 1749202045-490292 X-HE-Meta: U2FsdGVkX1/baflZHLFphRzQqXUFtOYrVBqQWwMPKBQRee+TrQneSAPhGcqgXTbvuQNa04f798lVLHDbzjl6izD0WvG4zXprkUfozNrKi8noh/EZyoKAqWnsCYjlBSLW4oO4Nreq74ZaK+OLf0zrMDIKpVrqKV9YDq8rBksHEAEMII/gjCZjKJQC9FWoLBKZPvSKPInha2Z2P+1SzPXWVGdhtu7XEM8O3pKz3FXpxiMNypBL32xJMUrLVOYV4MECNXDxjOHZu8ai4dFqMmimUPD3hIW0Xjlscwr4DJGcAqSkWf0vC0DkLtDg/ZgOLg+nf0+D5d5ITGcRRovS7md2V7xJ4WW4adbR18j1LNE6LSmDvGlK/Ofz2cLPJ/xqC1lDd2ZV8pVJon9NRv0S6b5I1ResvPSGAb2TRmBT+OF4tJqSkAsPzwLcwWA/stnmvwMwT9J0uAMxoC5AqGqxiO/8VRD/RIEssfNvJi+z9lhtZ7vAm6vB+UFSWvozTcShlLIgJOQCMlpJOAq5nmF2UdFqI3rTUT27rXGb7OgQjGyKF58bfz5gHdfJdg4xeeGnw/Ut3V0emNXtchnkZatMgCKaWZG3ymE1IzmPTJTbS1tPjl/pwvfIOWt/vd6QF8UMlZmOmA43FCQKb87FQr28HYqC5Bpp8RVPUD8SPFJ7VsFIFeTwNtXqJQpn3O4DKpEGUoL9EmT+a6HCoyxoIpadDDELWtjdrQkJGTbpGtGNK1P8f1UpGkc0UhEDzZqsS1rjl9s6f0MT2HY2pctpF/p0vTeCijLgljxNYoS7vjlDgwBPzroyhKIbDx0P+ALIR/I5JJ0F6POfUat4y1K3UHDNdWVAso+ogPvHK+ljCqQFv8glBWHq+fVAPjB7hCI8wktKBL90wonTH+kZ1Z0ARNvzhwdraBFMD/LKpBI1O8sFaGLH6g6Rm9D170PkYHSf095j4tIy4HVXRukK7K4Rv3JCt0X IXhr7AvK GmghkOeqbTUjkpYUkw+Z5uNCG/GDMd6E+c/WRq7roBUdsGWnEY5XCUbmBZECnSVuQiPbZeu7cH30SwXJuDCVKjEkz2BOhUj2KRfy39d0SfBefgZMMMPd+c2keD1BKiobcMwC7U6/F6MmL6j2tfihoQvzNsbnMmlHcSLpSuHGtIui82O1neGklobBywXJj77++i3VGbxCRQ3/rnq2kusYT4ae3Re9ASr4bZ6IYLSy6jLy8OGYuaLmksAEsCXcR86E72dkLq71OJFJHTJVVdHUdq3okW5vXPsmjHn7L4XMCv/nV/LqAyN5rm3KbYJIbXqM+tJb8DKWFUOtTqtbwubRiklXf8A4bm2WLFlhL+6jxjWplk+riStflY5jvo/RrpD97qcIrPnw6qXJ6CxZkf2gxtogZJfZ/sLPFIjpnpfwCGaaJyrWLVUb3ffTLcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 6, 2025 at 11:17=E2=80=AFAM Jiri Slaby w= rote: > > On 05. 06. 25, 19:31, Uros Bizjak wrote: > > On Thu, Jun 5, 2025 at 7:15=E2=80=AFPM Dave Hansen wrote: > >> > >> On 6/5/25 07:27, Jiri Slaby wrote: > >>> Reverting this gives me back to normal sizes. > >>> > >>> Any ideas? > >> > >> I don't see any reason not to revert it. The benefits weren't exactly > >> clear from the changelogs or cover letter. Enabling "various compiler > >> checks" doesn't exactly scream that this is critical to end users in > >> some way. > >> > >> The only question is if we revert just this last patch or the whole se= ries. > >> > >> Uros, is there an alternative to reverting? > > > > This functionality can easily be disabled in include/linux/compiler.h > > by not defining USE_TYPEOF_UNQUAL: > > > > #if CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__) > > # define USE_TYPEOF_UNQUAL 1 > > #endif > > > > (support for typeof_unqual keyword is required to handle __seg_gs > > qualifiers), but ... > > > > ... the issue is reportedly fixed, please see [1], and ... > > Confirmed, I need a patched userspace (libbpf). > > > ... you will disable much sought of feature, just ask tglx (and please > > read his rant at [2]): > > Given this is the second time I hit a bug with this, perhaps introduce > an EXPERIMENTAL CONFIG option, so that random users can simply disable > it if an issue occurs? Without the need of patching random userspace and > changing random kernel headers? In both cases, the patch *exposed* a bug in a related utility software, it is not that the patch itself is buggy. IMO, waving off the issue by disabling the feature you just risk the bug in the related software to hit even harder in some not too distant future. Uros.