From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA966C3F2D1 for ; Mon, 2 Mar 2020 02:38:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 957552468D for ; Mon, 2 Mar 2020 02:38:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GoJ/hSIh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 957552468D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 410746B0005; Sun, 1 Mar 2020 21:38:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39A866B0006; Sun, 1 Mar 2020 21:38:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2618B6B0007; Sun, 1 Mar 2020 21:38:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 06FB46B0005 for ; Sun, 1 Mar 2020 21:38:40 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A0541824805A for ; Mon, 2 Mar 2020 02:38:39 +0000 (UTC) X-FDA: 76548863958.10.pest82_68aff6a777d18 X-HE-Tag: pest82_68aff6a777d18 X-Filterd-Recvd-Size: 5627 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 02:38:39 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id w69so7999836ilk.6 for ; Sun, 01 Mar 2020 18:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hMBtZKtRWZnuY7I2gHV8O0aP4O5vGYjUt387++HUGg0=; b=GoJ/hSIhtzmyK1XJGrqO7MByCX/BqrUWQv4z+ueuUJNbrzqFtG8bW4JIDPsvIncAeW 3EjWVRw8A9l0UnxL4ahWx2hqUN45nEZCU0OrNvHP2Rmr4yAczOyEco3SmvhCzIRTEWzg 2nWiizNIf/13Mdewd0VigJmlCLnX6T+A19iPEjrGeXSjp7R2r5tku7Dy/mIQmD3Q0e4n HaNXKT9TAXhpb4zovKnrtzB7MwPxHau+Ie8umdopdU79mjJCMTI+uorDlbTVm/jKs0Ys bcuX6zU2BaabHoKiplMLkDK99a906rlv7NDo0MsARJNMPSPQKdDvsr+/KYWm0yH4Avn/ dzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hMBtZKtRWZnuY7I2gHV8O0aP4O5vGYjUt387++HUGg0=; b=gn2mM3AwqB/2rJugGki8GPr7KkH0JvHRpI0AytYhygABKY748XfsAzssdJADdPbwNw rB8Flm5Pf7j7FlLhwEgLKbAmZkyN+/ODx0f7Lpwfxxmfe9WVoeKWEdSctS2kMtDcTxut bG3y6Y6EQE+65iNta08v41xxnIhLB/wc8nh/kvi+4rkBG8/v8GuKP6/6iew4dl3Rmc9b 2bhRBo1diMCc/M5pROatu/eJ3IiGLu9LZRfJiR51f2XE0AJ4bEDt3DhvI/HdSrgiaicI +lkYb9O7FhdyRW26BmeDO9tnmJY0hYiegdKqmrbE3hSa3Ys7rKyedHHZV3UiVxNb/r3r o6Tg== X-Gm-Message-State: APjAAAUvkl44wGJHWJLKonZt+8Tc4EnRVLUJMprmmQtAMS3mrWKNEnNy w+vpcVMe9NMVO6fGOJ9+uxCmRWriKJzQoFY2KQ== X-Google-Smtp-Source: APXvYqwDyaP6Qn0pUWmDTtkqgW8emavOCeHLkeDP9XbwTbCJicqdnj0l+jIsvnqly0DAdgsCYBkmoZe1/psRu3keFaE= X-Received: by 2002:a92:194c:: with SMTP id e12mr13324399ilm.12.1583116718718; Sun, 01 Mar 2020 18:38:38 -0800 (PST) MIME-Version: 1.0 References: <1582889550-9101-1-git-send-email-kernelfans@gmail.com> <1582889550-9101-4-git-send-email-kernelfans@gmail.com> In-Reply-To: From: Pingfan Liu Date: Mon, 2 Mar 2020 10:38:27 +0800 Message-ID: Subject: Re: [PATCHv5 3/3] mm/gup_benchemark: add LONGTERM_BENCHMARK test in gup fast path To: Alexander Duyck Cc: linux-mm , Ira Weiny , Andrew Morton , Mike Rapoport , Dan Williams , Matthew Wilcox , John Hubbard , "Aneesh Kumar K.V" , Keith Busch , Christoph Hellwig , Shuah Khan , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 28, 2020 at 11:43 PM Alexander Duyck wrote: > > On Fri, Feb 28, 2020 at 3:35 AM Pingfan Liu wrote: > > > > Introduce a GUP_LONGTERM_BENCHMARK ioctl to test longterm pin in gup fast > > path. > > The title of the patch has a typo in it. There is only one 'e' in "benchmark". Yes, it should be GUP_FAST_LONGTERM_BENCHMARK > > > Signed-off-by: Pingfan Liu > > Cc: Ira Weiny > > Cc: Andrew Morton > > Cc: Mike Rapoport > > Cc: Dan Williams > > Cc: Matthew Wilcox > > Cc: John Hubbard > > Cc: "Aneesh Kumar K.V" > > Cc: Keith Busch > > Cc: Christoph Hellwig > > Cc: Shuah Khan > > To: linux-mm@kvack.org > > Cc: linux-kernel@vger.kernel.org > > --- > > mm/gup_benchmark.c | 7 +++++++ > > tools/testing/selftests/vm/gup_benchmark.c | 6 +++++- > > 2 files changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c > > index 8dba38e..bf61e7a 100644 > > --- a/mm/gup_benchmark.c > > +++ b/mm/gup_benchmark.c > > @@ -8,6 +8,7 @@ > > #define GUP_FAST_BENCHMARK _IOWR('g', 1, struct gup_benchmark) > > #define GUP_LONGTERM_BENCHMARK _IOWR('g', 2, struct gup_benchmark) > > #define GUP_BENCHMARK _IOWR('g', 3, struct gup_benchmark) > > +#define GUP_FAST_LONGTERM_BENCHMARK _IOWR('g', 4, struct gup_benchmark) > > > > struct gup_benchmark { > > __u64 get_delta_usec; > > @@ -57,6 +58,11 @@ static int __gup_benchmark_ioctl(unsigned int cmd, > > nr = get_user_pages_fast(addr, nr, gup->flags, > > pages + i); > > break; > > + case GUP_FAST_LONGTERM_BENCHMARK: > > + nr = get_user_pages_fast(addr, nr, > > + (gup->flags & 1) | FOLL_LONGTERM, > > + pages + i); > > + break; > > If I am not mistaken the mask of gup->flags is redundant. It is > already masked by FOLL_WRITE several lines before this switch > statement. Yes, you are right. Thanks for your kind review. Regards, Pingfan