From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE3EC433EF for ; Wed, 20 Jul 2022 08:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D8D56B0072; Wed, 20 Jul 2022 04:57:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4873A6B0073; Wed, 20 Jul 2022 04:57:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3764C6B0074; Wed, 20 Jul 2022 04:57:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 280A46B0072 for ; Wed, 20 Jul 2022 04:57:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E5A6AA04F5 for ; Wed, 20 Jul 2022 08:57:38 +0000 (UTC) X-FDA: 79706874996.28.CA3CBD8 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 97B0440098 for ; Wed, 20 Jul 2022 08:57:38 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id 6so31014527ybc.8 for ; Wed, 20 Jul 2022 01:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pCmF+7gOKupa+PsFrKqJcnPGIHHy1V9PA29ImLA4kE=; b=k1b0oNdyAPyKppu26soAvwI1DTLaUOuzVZL1OJUREWpzg99kCQHlJ3mGB9+fRSdKZ2 WgGeggybcfpJ5PsclC9OLSHyK2Mi14seCCJCYwYfZ/u1KPOT8ce9WtFHpPCxDLEx6pI9 Vxwz3xWWl//RNMDhU9pPggpBqUGAVUimQs1YzaDeGwiXEdotfA8mZx3k+0hyPeOHyVZb vNVcZnbsn9V+5bB7N9eEnmYEsxd1NLGVh67+0SmMELw0OSbuQQSu1leVLC+QVk8NuxlU tpmrh+pZlnKtk5miszbWS9lR9ycJYLLsVGuZ/tJ8CTyAZOOO5+IqLIPCMwHhSCZZ6ogf CdMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pCmF+7gOKupa+PsFrKqJcnPGIHHy1V9PA29ImLA4kE=; b=bFPsqFcaf4+HTAH6z3CGO5wF88dq4TGhccwXmS9PCyrIyyjvsfiWhO63er7CwdKfxu BWiTGU29iCfDwhJZgIoKRATkFvjwEav0Xy8bfKgVB62u9iPFSV7HH//dx4vGHCX3SCV/ zX3+tsxPtkorEOtmi861VEKnbFrFzNp1bJvdhS0Z+mIoWiGrM2N8wTk4oO08iaNESH9C MHscnaQgm4GPyo7BWa4Doqrx8OR3ksHG0ygutqPKKkz2xeORo9exDzDNEkvvRisQFIlB lBVSN47oQe0qsAjDTseDCrNDJd0/Vk6nIgQPxl0dSyKJ+o2DzIwPrgg94pLazOAwKRF+ W4zQ== X-Gm-Message-State: AJIora89pIWkId9JPiwHAJSGetSpc8+WkP+ofJAn9Exggnl+RCLtaOVP f0r60+r7YfHBpGTYHNreLquEyVXOzRDg6hbPdGz8ig== X-Google-Smtp-Source: AGRyM1v+Q9OYjm34O3xxK2nJl712afZfGnQd156RF/2egoZC2mPPCZsW9ObspHJIA6fRWa3fzUnLH6ZabeYZQZHfH2E= X-Received: by 2002:a25:6847:0:b0:66e:b676:834c with SMTP id d68-20020a256847000000b0066eb676834cmr35990047ybc.5.1658307457762; Wed, 20 Jul 2022 01:57:37 -0700 (PDT) MIME-Version: 1.0 References: <20220712231328.5294-6-kirill.shutemov@linux.intel.com> <20220713150200.17080-1-kirill.shutemov@linux.intel.com> In-Reply-To: <20220713150200.17080-1-kirill.shutemov@linux.intel.com> From: Alexander Potapenko Date: Wed, 20 Jul 2022 10:57:01 +0200 Message-ID: Subject: Re: [PATCHv5.1 04/13] x86/mm: Handle LAM on context switch To: "Kirill A. Shutemov" Cc: Andi Kleen , Andrey Konovalov , Dave Hansen , Dmitriy Vyukov , "H.J. Lu" , Kostya Serebryany , LKML , Linux Memory Management List , Andy Lutomirski , Peter Zijlstra , Rick Edgecombe , Andrey Ryabinin , Taras Madan , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k1b0oNdy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of glider@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658307458; a=rsa-sha256; cv=none; b=l8K4Ulg1iNJYOF/JhHkx//H6ufJwd+SfZ9pdMCFGLwPohH155xzg+7m8fh4I3aIPtgImXO isuXKCbaqzrF/LdH/FE09/1pT3HjuPE7fByL2hftkOI1G1zUKxWZCFv0O6rOdMal6PlEhA Fp6oL+txRIs8MOwP36YFuCD4gG6MrIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658307458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1pCmF+7gOKupa+PsFrKqJcnPGIHHy1V9PA29ImLA4kE=; b=WkJC36NMs39J5+gFjJ0UkXZkBMr8Zd7B23q6/qiZYjX8FVhj0/PXUvlngEsZQtGHkZGE3P uClHa7rirBT3z0F0lTyHG5LOj4pEkVBna1EGV0DQABDK9vAT4xD3Ela+8+4S5iH4bH2xbX Q6gmLu+F+QC7ycqI8TJBMPkhdf/Le0g= X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 97B0440098 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k1b0oNdy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of glider@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=glider@google.com X-Stat-Signature: mzf39ccdds5p4jzophkheq6jq7ifu8g6 X-HE-Tag: 1658307458-615842 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > /* > @@ -491,6 +493,8 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, > { > struct mm_struct *real_prev = this_cpu_read(cpu_tlbstate.loaded_mm); > u16 prev_asid = this_cpu_read(cpu_tlbstate.loaded_mm_asid); > + unsigned long prev_lam = tlbstate_lam_cr3_mask(); Note: this variable is never used if CONFIG_DEBUG_VM is off. > #ifdef CONFIG_DEBUG_VM > - if (WARN_ON_ONCE(__read_cr3() != build_cr3(real_prev->pgd, prev_asid))) { > + if (WARN_ON_ONCE(__read_cr3() != build_cr3(real_prev->pgd, prev_asid, prev_lam))) { > /* > * If we were to BUG here, we'd be very likely to kill > * the system so hard that we don't see the call trace.