From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA16BC636D7 for ; Mon, 13 Feb 2023 11:04:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 434846B0074; Mon, 13 Feb 2023 06:04:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E5086B0075; Mon, 13 Feb 2023 06:04:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AFDE6B0078; Mon, 13 Feb 2023 06:04:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 195DC6B0074 for ; Mon, 13 Feb 2023 06:04:17 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD4071A0811 for ; Mon, 13 Feb 2023 11:04:16 +0000 (UTC) X-FDA: 80461984512.28.191445E Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf18.hostedemail.com (Postfix) with ESMTP id 2B5E91C000F for ; Mon, 13 Feb 2023 11:04:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=j4ZA5Qa3; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676286255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NYx2AyPU7S06WvalHgphXS88wTsCd0bUzbIYrlIqVZc=; b=2whQ/zkhX7verv3UA2HVD4hKpUTkfFrGX5xDrFXKNw2WsaAeSV0bJ7qnUyN7J29ieN6K39 gZj1JCFXicBdsIq01RVZK+2tphhclyBH7WEtkPacyODdiBHYTDP1lNpUyPmj49Mk8Q0f4v qvTZVR3zn2VvBDbqQNTSQarIVn7G+bc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=j4ZA5Qa3; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676286255; a=rsa-sha256; cv=none; b=fNbsYN+Bf+U7e9dj9pVnW3iw/B5pgqD3IysJG8TqWgy+YQC6BxFUhJIbKw54U1XJ2vGtEu NCMOxnjU1d8JIc/E5sKKjPGBcBujOYjeUFssV0bNDvLP/nLEn4Fgn4hvNHwyPBmm82qzYt YHIiTG3dzqfGlu5m/rHHgJC0Fch/Ojg= Received: by mail-io1-f47.google.com with SMTP id 65so4325832iou.3 for ; Mon, 13 Feb 2023 03:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NYx2AyPU7S06WvalHgphXS88wTsCd0bUzbIYrlIqVZc=; b=j4ZA5Qa3HBuJDnuS3BIhYWxTSQ0G8BigeWlM/UGuXFspIEHa/EhA4sD2fdEK3SxEVO 3CjQI6d+pShg6Ai0+dEDidMiB2gOdAUThhaULzgv26CNcZByKNJ6FlnbNi/vMRcBJUAA boECQ5jgiZghhC+otn3eCIkTTl7ROgQAnXTQFWxZD3mi0MHc5rFPyj4wdTvKAa6Pm5Ml 1gMN4iXV5sE/I19Os9vulAX6dZM6Xj7H4Iz7rq/Rw57sOwBOEshJeE9EgkG+meRKHz84 LEZhaEo3yvxRjrh/r1Ve5cQzBBRfn6AnFNmhpMY+WMJwIMR3LDbSrUexjnVg7yRXBU99 kVeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NYx2AyPU7S06WvalHgphXS88wTsCd0bUzbIYrlIqVZc=; b=zfHDVaEvxvdHvf1GX34GpyceUBIM+aSiqQ8RlswLlEjCEsJTaaM8zprba0VWEyLjBA zsZPZqOAPSAC41sdjywUNAYBR+RHFttL6NcZrk20lzkodt4eVXp3ntJeGxcve33PjwVb jbBxVHkn2BXnKMRkoYcHidKEuwWL/6CL8+xi94M0B+gw1WsBz5cRetcZrXt6h2VAS9H2 O0bum2qs7KkEeeKxEU5q6wY1+CU5i2vjZ7qsQ+Asfh1C+vu8Jw+5hYRLaJETWAiad+zJ tFtTYe9L/KDQ79ueiUQzHM78HorE94Gi0Z5Is6mlSP93fGoCyEeL7W4kxohA+dAe0x+c p5/Q== X-Gm-Message-State: AO0yUKXD8xhhUaISgfnDlEs3HU9y3tAumowokKtJPJnPKfZIYGg56/Co aTCVQKHqxXwMaBY6Ll05/J40Jl0qkcu4NlwONqwgUQ== X-Google-Smtp-Source: AK7set8Qh/DGdvxd4bpiG1wb/ltPuFD5pb3Sk4w8im377pG5vnagqX8FCB4QXIOQ6F2/ypfqFqOt4n5FPKT92cng2mk= X-Received: by 2002:a02:a794:0:b0:3ad:3cae:6378 with SMTP id e20-20020a02a794000000b003ad3cae6378mr12249003jaj.16.1676286254268; Mon, 13 Feb 2023 03:04:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Mon, 13 Feb 2023 12:03:35 +0100 Message-ID: Subject: Re: [PATCH v2 13/18] lib/stackdepot: annotate depot_init_pool and depot_alloc_stack To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2B5E91C000F X-Stat-Signature: 5gi51w8cu8tqsi8rdhbirz69quztxe73 X-Rspam-User: X-HE-Tag: 1676286255-862652 X-HE-Meta: U2FsdGVkX18IC4PFa0Bou/nEHfdx1Ym4RF3xw0Uxh0G3WDsHdxiVcOoMbwS4gYqDA6D2HFaN/tti7ROxklABY+Hl8e6GDzNLircIFyUgwFjArZNLT25IU6lw7pduQl3vOGVEJDScQ8yQn+FKgE/d1zfGb325zGLJPJWM6zRJAShqC1H5YyNhD8PoIOeJXABVNnv/fFWHlFySGeWsB4jh3yVC82NOJ+zunM75nIzJGyyxWRZO79R8BVKpgE5UqIcdtkBN6+WjvXOKVg6ipLSBJRHAjcOurZgJcXq6+uZLzkLtmfb8dbaS4vLGYu4NL0eCxE8ZWOnKAX/m3yn6htf5lYer8jn+YvDUXc1oNKfSK2dVeEMvaS61g+gkLHrQTA4/2fCAqvMyNEZGBf9uSZnkHUxmXUVVseX9PNbPUpuufoMc6+8LmI8YyFcdJHjoIrhsWI0dxNo72BWIqlgZKKST4bruHNaXVf0dvwzkm0J5150baWB8nUGb0RbRyL63M1L4KhVISfH4Uye0NROkvirqfuOgHvaQQv6M/HXF4FVVGgRONlbQw/fSKk4RXbuhnGmXhzX7QcvsmcMwVI89G06q8w+Si0xuTB/+ZOQpBOm5RPzZXdlc3dg2q5ldsdsGORXbX7uIa7KSqgTFIKt256IiW0l/axNSBpPQ9euiBVrHoQfLh0IK+jpS6p+jqKNLQrrGkoj/ZVHuWa1lvHy9RMQLwYJ7XT0rouii2WqzCg6QLbJJSBSWDmSBJ2773zemS99B0Tyds3DnMu+Sujs2vAjKcfgrepTH0hmrc7M6C2NiW0mx+eLSMgGvLHm7j8s7iuiskvVPKBqv2Me5dAAVzhynfWDJ8BSiXB9c5jTBWYbunvZa9O+uE0VFvJqNwvK1ejO98zA4Sm5UUAFOSyiPqabdUCMMYwYrN4ONu5b+goyeHEs6Ge/d4UykT7ivTF3nA21RUvYn2Bs2MM5mtsB4kQ5 tUE0PU1v yu0k1djucS6Mc0zQ7z09ZE8L3F6HfI5ztNDmvgZi+FuyYUnHn5JZ1dCiLd7KPsmMOB7+/cgP0zLS86Rag+W6OcbJI/fOCYXl5fGQDqFJDG4drrkyff1kNOqLIs05doSGj8HjnPx2Gi832zCFAy/kNx62tPsZGVFX2DF3KEi9jWLAjnTJi1c31194FVUtUBy/9ltQBG+nDJVv+x0xcqEGQ+vdTFfDnwy6Je2x1zk61YHQAjBOuuADIbClk1ufUu1ixt9geYS/yQAxSfq5O2fzFQN5ZoyWcyGYT/1coeSjZML6hxI/lr9BFPpYYeATVGD5s28iEq5jwlm3uELDICEDyrEM2kaYiblwKZV+P X-Bogosity: Ham, tests=bogofilter, spamicity=0.001780, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 10, 2023 at 10:18 PM wrote: > > From: Andrey Konovalov > > Clean up the exisiting comments and add new ones to depot_init_pool and > depot_alloc_stack. > > As a part of the clean-up, remove mentions of which variable is accessed > by smp_store_release and smp_load_acquire: it is clear as is from the > code. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko Thanks for the cleanup!