From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22A5ECAAA3 for ; Fri, 26 Aug 2022 21:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24EA8940008; Fri, 26 Aug 2022 17:06:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FD68940007; Fri, 26 Aug 2022 17:06:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5F6940008; Fri, 26 Aug 2022 17:06:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F0ECA940007 for ; Fri, 26 Aug 2022 17:06:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D4791403BF for ; Fri, 26 Aug 2022 21:06:25 +0000 (UTC) X-FDA: 79842977130.18.507C25F Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 4394220024 for ; Fri, 26 Aug 2022 21:06:25 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id u9so5346723ejy.5 for ; Fri, 26 Aug 2022 14:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=5PwylQXedxDhkWafpzB4KIy3NiEnlvim/yfJsbpjDbQ=; b=Yf9PjWlfL1r7eT/c/0AIKUjx+BKquW/wJnHvOD5xraOs6Zq6+qgnX0MvaVZZirGA29 MiCEjgTCWVH6qERy3ErADS+pQlFu0JZM6MMkgMyDzjmYTl7pzcjuduPfCeYXe62wir+R F/0AJRGshM9LobezTNYiztGwD4ALx554BVYmphaKX7b/HqjkDb7yE0CapdGKprLHC+uD NVhp5BNbj7GtIsj4wHzXNKBXu/nBCo5/+AtMQFMoQTJGxpubM3Nl1C2nlDuiKCFTD0OA rUPDJDe2Jk6Y9NkE7s0OgIZFirU9LpSK8tGo9v+OA4I+pXOc2aqEI54hnwrbByRa3Csa 4lMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=5PwylQXedxDhkWafpzB4KIy3NiEnlvim/yfJsbpjDbQ=; b=mQ1qT55OOcQ9zPa80yYj0uD87+2I2nStzj1w2Kr1pKTYJBn6eq4/oy8ZKTtOCstw8J m2uBA6TbhSiQ49AwByCy82JCwe0Vl+qetA4PbLInhc1oOMR6heyAnaw8jSIxRhqR5Bbv XFjlFPsmdj9q7Ubz+GsCj6v73vr/an78NiOWtEJdiDYsNFdTIOdeLBBYMhSz0QP/9MVM 2fGYCP4N1D5lXOoM2qcH2soHLiRFOU5lw4s5ckxP64Ukwo6EsWyYE0/VkX1g9UALaJBn rERIDOCIyaV2g8V5ZUIaeIfs/ZJxZbyfPVAqnNp0dHvXB/rgf8BeebS38Q2Ptc8Jyr0i Q6Zg== X-Gm-Message-State: ACgBeo21NLz8zWNMqch8ae3Z8OUr8Rim/YBYIpGLE7dnjUxqvFXx6wL/ 3RKIE8gPftaDjloLIcM8+B18axFhhtwjLPgCIA== X-Google-Smtp-Source: AA6agR6Ncxwh8sZisapap17QKB0vCPLvZPFGD64SjhSRwQj5pNJD2743vRLKzk92RbbdMrcFnobg9pLitg0Rbm61fT0= X-Received: by 2002:a17:907:6096:b0:73d:9d12:4b04 with SMTP id ht22-20020a170907609600b0073d9d124b04mr6717363ejc.745.1661547983987; Fri, 26 Aug 2022 14:06:23 -0700 (PDT) MIME-Version: 1.0 References: <1661502678-19336-3-git-send-email-kaixuxia@tencent.com> <20220826171629.50210-1-sj@kernel.org> In-Reply-To: <20220826171629.50210-1-sj@kernel.org> From: Kaixu Xia Date: Sat, 27 Aug 2022 05:06:12 +0800 Message-ID: Subject: Re: [PATCH 2/2] mm/damon/vaddr: remove comparison between mm and last_mm when checking region accesses To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, LKML , Kaixu Xia Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661547985; a=rsa-sha256; cv=none; b=PI0Eorscjx+a1w2v2Er0oA7ecYNuxspKlFhRgIQ/VxyVZpSH8U7zv7RgRTQldSxy7pvx61 QZF3xsIVm4QUAX8vdDZLpLr8JrO/TWI+JL9NjG3gtD/MmGqlPykmRUVj5Dxic3Iaofj0d/ LPY2k1KF7PstX14FWX8HDoYb3kFxQ6o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Yf9PjWlf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661547985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5PwylQXedxDhkWafpzB4KIy3NiEnlvim/yfJsbpjDbQ=; b=WeDRQVE/iyJgWZhS4yoK2FPzoJWxLgv9ndTwtaAbhEjCOMFv/OnjsRfr/oiGKOktCl+5Gl MiOixWWTh6dwUAE+E9GMFwqkOml/pPEWJ5sAPLdw37UweHxxeQ1G/CnnShQCZcRNK1xu7p V5y2olXxupbY/DGP3WdmFyiLXkOqorY= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Yf9PjWlf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jys1je4oydiusxmcn15gw5ffyq9ck337 X-Rspamd-Queue-Id: 4394220024 X-HE-Tag: 1661547985-123042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.032317, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 27, 2022 at 1:16 AM SeongJae Park wrote: > > Hi Kaixu, > > On Fri, 26 Aug 2022 16:31:18 +0800 xiakaixu1987@gmail.com wrote: > > > From: Kaixu Xia > > > > The damon regions that belong to the same damon target have the same > > 'struct mm_struct *mm', so it's unnecessary to compare the mm and last_mm > > objects among the damon regions in one damon target when checking accesses. > > There could be multiple targets, and 'damon_va_check_accesses()' calls > '__damon_va_check_accesses()' for all the targets. However, > 'damon_va_check_accesses()' doesn't note if '__damon_va_check_accesses()' is > called with a target that same to the target it was called with for the last > time. Hence the check is necessary. There could be many regions(1000 max limit) in one target and the mm is same within the target, maybe we don't need to maintain the 'last_mm' and do the check every time when the target is same. But yes, the check is necessary when the target changed in '__damon_va_check_accesses()', this RFC patch missed this case :) will fix it. > > If I'm missing something, please let me know. > > > Thanks, > SJ > > [...]