From: Barry Song <21cnbao@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: SeongJae Park <sj@kernel.org>, Chris Li <chrisl@kernel.org>,
Nhat Pham <nphamcs@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Takero Funaki <flintglass@gmail.com>,
David Hildenbrand <david@redhat.com>, Baoquan He <bhe@redhat.com>,
Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH v4] mm/zswap: store <PAGE_SIZE compression failed page as-is
Date: Fri, 22 Aug 2025 15:30:07 +0800 [thread overview]
Message-ID: <CAGsJ_4xR3bvWTEfbu_navPHGiVacAJTY-87BvOH2QQd4xAM4VA@mail.gmail.com> (raw)
In-Reply-To: <aKgF_uJT99rBiyDd@gondor.apana.org.au>
On Fri, Aug 22, 2025 at 1:54 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Fri, Aug 22, 2025 at 12:48:27PM +1200, Barry Song wrote:
> >
> > Is it even possible for crypto_wait_req() to return -EINPROGRESS, since
> > crypto_req_done() will not call complete(&wait->completion) in that case at
> > all?
>
> Of course crypto_wait_req cannot return -EINPROGRESS. However,
> I was responding to a request to make the crypto_acomp_compress
> call return a boolean instead of an error code. That is not
> possible because it has to be able to return -EINPROGRESS.
>
> Nor is it possible to change crypto_wait_req to be boolean since
> other Crypto API operations (including decompression) can indeed
> fail.
>
Ok. zswap only cares about the return value of crypto_wait_req(),
not crypto_acomp_compress(). So it’s clear now—any error return
means the page is incompressible.
Thanks
Barry
next prev parent reply other threads:[~2025-08-22 7:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 19:34 [PATCH v4] mm/zswap: store <PAGE_SIZE compression failed page as-is SeongJae Park
2025-08-20 1:13 ` Barry Song
2025-08-20 1:20 ` Herbert Xu
2025-08-20 1:34 ` Barry Song
2025-08-20 1:37 ` Herbert Xu
2025-08-20 17:32 ` Nhat Pham
2025-08-21 10:27 ` Barry Song
2025-08-21 16:42 ` SeongJae Park
2025-08-21 20:49 ` Chris Li
2025-08-21 21:36 ` SeongJae Park
2025-08-22 0:48 ` Barry Song
2025-08-22 5:54 ` Herbert Xu
2025-08-22 7:30 ` Barry Song [this message]
2025-08-22 16:44 ` SeongJae Park
2025-08-20 5:07 ` Chris Li
2025-08-20 5:10 ` Herbert Xu
2025-08-20 5:20 ` Chris Li
2025-08-20 5:22 ` Herbert Xu
2025-08-21 20:42 ` Chris Li
2025-08-20 4:55 ` Chris Li
2025-08-20 4:49 ` Chris Li
2025-08-21 16:17 ` SeongJae Park
2025-08-21 21:21 ` Chris Li
2025-08-21 21:41 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4xR3bvWTEfbu_navPHGiVacAJTY-87BvOH2QQd4xAM4VA@mail.gmail.com \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sj@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).