From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5FFC3DA7F for ; Wed, 31 Jul 2024 06:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C97F6B0082; Wed, 31 Jul 2024 02:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4795C6B0083; Wed, 31 Jul 2024 02:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3406E6B0085; Wed, 31 Jul 2024 02:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1650E6B0082 for ; Wed, 31 Jul 2024 02:18:17 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5800B140143 for ; Wed, 31 Jul 2024 06:18:16 +0000 (UTC) X-FDA: 82399042992.24.B513EC0 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 7D59F14001A for ; Wed, 31 Jul 2024 06:18:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ozq3ArJB; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722406638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XQOA432Rv2c5W9i9LzMUmIPMyKCH0QxKTf51rYbywUs=; b=3JCd9rfyHb46dL00nY4+tny4IOMFFSksq5oVq7nzR/67BtFV0AUdE8x2L6EhXjyPqSaZ1B kBliuGR4QlEHhG97aBLQEmG4Tj2uoKyqW7fI25YFaPDGn4UNxHcoL+qnou4FizkGGaZFiP ITmGOD3SeVZ/GP3G7+qqPvB0AtKCnTo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722406638; a=rsa-sha256; cv=none; b=6WU3Y2EPXsCHvfOS6FrRbIl/CgqI1RgcKNNTIEXnwrCvFitTu7MCA7nwJ4mdH8SvmiyMBv MEecz3A4S9RKHTKQHxgFtKG+2eovkzMmDT5SBDqPXD5mrUKbk5iY3x70RKE5JfBKmrJkqp RyyKtda+QuQa9Ji56WbLH76CzWn7Lmc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ozq3ArJB; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-4929fd67c7bso1147136137.0 for ; Tue, 30 Jul 2024 23:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722406693; x=1723011493; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XQOA432Rv2c5W9i9LzMUmIPMyKCH0QxKTf51rYbywUs=; b=Ozq3ArJBNB8YSk2zAY/r5/BzSc5sbdTDSXoZNvV7+TqSZV0iF1E3Qjpngs59CTJpKZ piTwK8G8JQBwVgsHCZvrHiOTBxF3WeLXmUQJoFGy3JrBb2K0PtUDPPVhpbAVhrB30ALw O1epiIuIvTbQjX1ndWsbecMU0QkMMfCjx/wYLwPtzlb2V8vb/5RKhdj0GRLaMwYNjK3j 5kiXpobSAWb1VLwR19Efg9XcISr0UknL6VHJn32G4viCUcMPpvRxGHAZuC2IIf26odpb qwrzAprPPWNBkq07Iijo5aAx/gqBCDGc5ehtXH1BeW2z6eMHCkJW5ojuIHthMafwoDQj eQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722406693; x=1723011493; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XQOA432Rv2c5W9i9LzMUmIPMyKCH0QxKTf51rYbywUs=; b=sCY4geJVfIS2wGQwvtD/GqicLzbx3cGYhEp6N3gngixFCOY0oTQ/Kbvktd1gIMKu9h PcrnqBPSVe/trNS6+lekjRJIaZWQqzkVGRQcN7/kFTQkzI3wdgKcC2ni/14dYwqy8Ked FHkkDnbvlTEfzXPacIketig54whMAxCjEddpJnSmIwMfGfxJzQ75fJNAZthz697yBmwr V4IPf6sIameWlD6q2F/woIKj4QHZ3vR86pU0tJPTPcnFItujqga07uj0RvQdroI7xnAK XH49k6vzaxzdTPo+fc+SpNBaNwlrd9s11g5W+D/HWxQbdUXBby2LuQ14bv5C5hfP8P6q r50A== X-Forwarded-Encrypted: i=1; AJvYcCWtB7UZFBHBr3C1wBCeFTacjQ+uEr5V1J4ovh32WzknVGRBWam0KMVDrMZmemxRCZCZvi2Ha88Hp+IEa0u8NGpjBZ8= X-Gm-Message-State: AOJu0YwVnYnZc0/NKfE21wzmfOpq6oH5bJvYrjM8dLUhoWISV1/0dSqc oia8PcMK1q9it4/ozzUM8VZW5rRs2bgHGZbNrBpGYhroJV/OPOB7ZsjmTMnf5LBomv5quv+RdGM 4mnmV2Af0ox310Nn/Hy6TGkmZrc4= X-Google-Smtp-Source: AGHT+IFxlvDFGFPzwYiaEvEcfgvj+lJ/K4qT6SPGE+9amWJjxCy0bEBUZfNtT5zuXRffrH77Ich77/Bb8zEE2vazO5s= X-Received: by 2002:a05:6102:3589:b0:48f:e5d1:241d with SMTP id ada2fe7eead31-493faa40575mr16294359137.14.1722406693487; Tue, 30 Jul 2024 23:18:13 -0700 (PDT) MIME-Version: 1.0 References: <117121665254442c3c7f585248296495e5e2b45c.1722404078.git.baolin.wang@linux.alibaba.com> In-Reply-To: <117121665254442c3c7f585248296495e5e2b45c.1722404078.git.baolin.wang@linux.alibaba.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 31 Jul 2024 14:18:02 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: shmem: avoid allocating huge pages larger than MAX_PAGECACHE_ORDER for shmem To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, ryan.roberts@arm.com, ziy@nvidia.com, gshan@redhat.com, ioworker0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: rzidezd5apmed4tzdjucejdjj6zcedfq X-Rspamd-Queue-Id: 7D59F14001A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722406694-99386 X-HE-Meta: U2FsdGVkX1/mSLavbBQ5YSVDbE4Wh9yhYcFbO0Detjw+twEN8p+Chs8nKMfvuU89deaf6IWo4HdfcidEZu+I6ZrufLPotcrrFDE0occMvszW0w0uEsOXQMsBCP68sWxcmvBJ3zLesVuy0EqE8SqzXZDgRvN/0w8+UQ8rwBTf0KYMIlUFwHInTv/QPeJxrn4DvvN1MhUMMOMV/t+l16liMXPg4npG43ksifNxXoaDfd3/bc62zoXE2eXXYDtzmF0DdaesUyQfgSw60jeomkDfgTUwBd17j58KVacoQ1zLNPUa8/WNeExPKlux3ijLdQ1phNwrHj61n/YgOUP2Yqh7A6gjwOTQB5Fm6fXlXcOvxJs5pRa58/QsM29HOjyLcjcjvl4em1jmeUCMEnBJSdZFhKmhAzicIFuB0PRbex+dHaCjgroMOtvL2Vk8SYSbozPWpKgAzhcYn7h696FWIh+yAnGYPa10RF7PmXk8AM/v13G06zD4NkxhQdM4SdYMqt9H2UAw81h3SDE31Au2jayjtyyWijc1B0sKrnuTPFxSRGFERfzaAyLDcshOCYtE5AeCza0j+zWb10AZchRT+OGpAJrRUEssXv4pgZZ9fjjywAP05flTdl/IFr7zwowfsZXkAmrhz0+F/Wpdy8hcstjjh3g+h3vRHCikrgzRSbgcbshhnCjSMO1+PhW7Wmi/1Cb7we4dMB8R0VXAIDKiBVUt5rgluyVrNTuVj4O2MbXbZmPPXQI2P2ipqDysEPbm5vJndYyZD6N9BL8HJKE42tlR7tQiKkPtVMl1B/SQwZYJugLiGqoETyHMZhgz3KJRHoEmr5FpTZOd6HV+KoucqTF9TaK86lBAiHfYxffH0/gWD7FD8ikh6dbLLmG/v1ABjA0eZKKo39FWSDrDgtwdIYZ4c0kG3jpCE3bizmb98ENhuYa2M3NciRfbcKiMIWtLiZfT/QCHdwxQMbmznefpqJg hxQuegSz VafW/P7+uyXTW6BW8dZNGQkR/6kDKnnpRol4w1kBEFevR+CfakRlF7WuxEaB1nr4cQE2C7tzQmKyBAUaYxhFcvhhSOq4AS62KbcIJH0frQVVnJRBURDyAaFUzymU2luloZ5k44X82XkMAzvKnGsmBuuceVDA0R5QUf4zXcy/9qyb/a/dMuGl+HlDaI5nUgSRA4zEeUoCjMbaIW0O+bw56L52MiuaC+xFnErnFWdTSlEFWGSX0GwAjOo+CacbuEoPtXo6ybDI1Bcb+zIY3QUEfEUwJt2OoH4XrBnzeQy8STvQTV09Uvea/wodWFGkHJ/wL/47LlXKVCLcYTVEyGsvN4EY2HLNdU+E73YddyNSO6J3/+WPTEsB6p0HwOnmHj1OIW6Gk/SFnWVsb5sZmOZZ7mxxVFduBd9JnqO888/A/xL8drho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 31, 2024 at 1:46=E2=80=AFPM Baolin Wang wrote: > > Similar to commit d659b715e94ac ("mm/huge_memory: avoid PMD-size page cac= he > if needed"), ARM64 can support 512MB PMD-sized THP when the base page siz= e is > 64KB, which is larger than the maximum supported page cache size MAX_PAGE= CACHE_ORDER. > This is not expected. To fix this issue, use THP_ORDERS_ALL_FILE_DEFAULT = for > shmem to filter allowable huge orders. > > Fixes: e7a2ab7b3bb5 ("mm: shmem: add mTHP support for anonymous shmem") > Signed-off-by: Baolin Wang Reviewed-by: Barry Song > --- > mm/shmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 2faa9daaf54b..a4332a97558c 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1630,10 +1630,10 @@ unsigned long shmem_allowable_huge_orders(struct = inode *inode, > unsigned long within_size_orders =3D READ_ONCE(huge_shmem_orders_= within_size); > unsigned long vm_flags =3D vma->vm_flags; > /* > - * Check all the (large) orders below HPAGE_PMD_ORDER + 1 that > + * Check all the (large) orders below MAX_PAGECACHE_ORDER + 1 tha= t > * are enabled for this vma. Nit: THP_ORDERS_ALL_FILE_DEFAULT should be self-explanatory enough. I feel we don't need this comment? > */ > - unsigned long orders =3D BIT(PMD_ORDER + 1) - 1; > + unsigned long orders =3D THP_ORDERS_ALL_FILE_DEFAULT; > loff_t i_size; > int order; > > -- > 2.39.3 > Thanks Barry