From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0845EC00A94 for ; Mon, 15 Apr 2024 22:51:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577ED6B0083; Mon, 15 Apr 2024 18:51:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527536B0085; Mon, 15 Apr 2024 18:51:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EFA66B0087; Mon, 15 Apr 2024 18:51:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1FECD6B0083 for ; Mon, 15 Apr 2024 18:51:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D2ED1A1310 for ; Mon, 15 Apr 2024 22:51:43 +0000 (UTC) X-FDA: 82013264886.25.FA09A16 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf10.hostedemail.com (Postfix) with ESMTP id 29CA6C0002 for ; Mon, 15 Apr 2024 22:51:41 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="AFbM/Exp"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713221502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=63WuSgSRy34JNOa9pVcP0sGLwbzNT5xJkZeCbwGkCUE=; b=u9R30l9BzAo7Mr0q+yWlOokBb185rY8OcN2pl1UvHM3ytKuDrb8D74fGBoOU3GVaF1Zt+Z mpe+lU4rdy5Q1vs8DRUkpLlNgnTm1QPe6B6WpC0RyyH+1hd38MgactuqmCGi12LAnZeH4B 92FYOx59oUjsiPbbHzJMb2BQGJpud+E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="AFbM/Exp"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=smfrench@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713221502; a=rsa-sha256; cv=none; b=WL7swswFltyr0gga+G4xyYhfM5ExhMNAnJVC2OjzYIqJEKJu/FVRbwGGe33rfYNhRlTzHi 1I4iGt3cArpyh8sPSR2+Bw1zyPDa6IbRYaatPtPlY2pdKMPe81Qg5aLr3Srjda3e/K0hZB EuoxyGqdfGL4YjlnsbdUi424qgXYjVY= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-516d0c004b1so4937875e87.2 for ; Mon, 15 Apr 2024 15:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713221500; x=1713826300; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=63WuSgSRy34JNOa9pVcP0sGLwbzNT5xJkZeCbwGkCUE=; b=AFbM/ExpkbAPdAYp6HtgClrhe/adfEsV4saJBYqx4QJEeLJEFkOgMEnFDy27bxuiwO EpeM0+zCUJebTfcgW9H/T9MEGU3EzlAAjjb3ySD1uX1QxmrDhg2tXhAVyVD1qDfbbJrO 2f7+HPkmfliJnRkRteLrhDvNMzTphFJYe5/CfjqmUmE1G0eMTAuGjMc/x6UjGVhvASzY vgjEr/cjkxRIYrOAI9dZneEGvNSLySVUORa+LvPhOZEzU9bJIwjO+8TqRWQFJT1Bq60K teubuKi/GDnJ9N17wYA8tH7xGvZ6lk7Xzoq0p7OZsKtp1O3JwX87hT0xuUW3eceT33Vo cmmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713221500; x=1713826300; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=63WuSgSRy34JNOa9pVcP0sGLwbzNT5xJkZeCbwGkCUE=; b=Eny0KBaHIj1apolMiz6nq0vNu1uxKw8K9LK5Z69zAcqQwUlyWZX2aClLodY7eowoHy EKUah2p4dQfucp7j2GAVD9UjYayiiT2QdGBXBP9OsFwNf7Ias6ztfl9fJDGqKFxFTeJm U+lNcxo6dRicevjNROzHUz4rkM9v0IaXiypM9p61Kd5BAns1xntlPm3GoN8tbxpUETUB YMEc0KEV3N54RVi+ArXpvjGuMbKwSj25uuK3XMb0ofgib5W9H9Ga6dJlkpbBgtaPdqOu e91iwjsRy48cIMlUT55/kAJc7geO2xYpZoz7hronJSiw96URxO/AQc2Rnpi1lcNrKR1o m4Xg== X-Forwarded-Encrypted: i=1; AJvYcCXrIZ1qpKQzj6ABpoNPeqll96JfCpC53YZhDtU4oDvZ/7Fd5f48rpWj1C+AGYRIt/0pp1yu8uW4uBS5A2w18ZTbGZE= X-Gm-Message-State: AOJu0YwaKnk7fKP+GlX+ZX5K5+QHAhI/yXyKwYk0rGyPy4sVANjjmYvi eYa61ef6/vrrsCH8YCsGkwLaTbKy7UVu0TEvppEd2IwxXqP16uhQxItB9hjyi/t2FAMEdgh2ih3 wBiLDq3ava7oEW5m3yhDmabw127U= X-Google-Smtp-Source: AGHT+IF8RFFMQuN5vGtuRwBPhuh0oAZccy2g38TQjUdEv5QNHmaH/Tohq78D8IN9/9jH1PsE9dc35dj2/YRmRw43rn8= X-Received: by 2002:a19:5f1e:0:b0:516:b07a:5b62 with SMTP id t30-20020a195f1e000000b00516b07a5b62mr8309996lfb.54.1713221500147; Mon, 15 Apr 2024 15:51:40 -0700 (PDT) MIME-Version: 1.0 References: <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-2-dhowells@redhat.com> <39de1e2ac2ae6a535e23faccd304d7c5459054a2.camel@kernel.org> <2345944.1713186234@warthog.procyon.org.uk> In-Reply-To: <2345944.1713186234@warthog.procyon.org.uk> From: Steve French Date: Mon, 15 Apr 2024 17:51:30 -0500 Message-ID: Subject: Re: [PATCH 01/26] cifs: Fix duplicate fscache cookie warnings To: David Howells Cc: Jeff Layton , Christian Brauner , Gao Xiang , Dominique Martinet , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 29CA6C0002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ubkjq68c8rkubtjt4gwaazn5bskucmi6 X-HE-Tag: 1713221501-622711 X-HE-Meta: U2FsdGVkX19cMQn0udlF47VOB76kFBFLkuKATFHgeaieO4KOJKDSU/7zpJn1JkTCd0BuCEaXDTKSBbZSSAnGvehE2qeKoiCqWyBISFKsLNBFhNMHLFq9EzCUO84WC+UQVk8aPbHKhkj7fTZyyK2lFlUyx+heTOmfPbgK0VVGde5OsSNhUGXMaptQmpD3czfhiP7wrs6Iu2LLImUdkHUoPlO+vnOq8ODlF3puL5QQAhb4cJ8tbJgjGfJej7Dt9Uac02VnT4xhq4K5SoHjIZUWfhd8unaz/Gh9SbLv/N15akZO5l07/0cdT4YgIvDPjhXA8LW+ZBnrY514wWVfGzQa6P6wRAyCnBuP7Qtd/yzwDQ7IBLiz0p48U3KHeOJmcddDQY4iw3+a+jIo6TOf+prNFXCi4ukl2K5LV8DMzDdtBwuzhx0QNYvjM2War4yDuWhxCDQyOC80Y5dkGiGy8JUE3N8e9T1o4FN9ya54JmQNkHuBy3n4dg7rxtQOtyhX0MmE1YmIyBKsVlYVETeMw19znmjlzKmrXGxuhwCODpVGOMjKAd+CPc6VGll1wdm1irdhv5GWKf+rIfA1onjj6A2Aplm6E6UZplgokgKq8VZF/ggg7MOS7VfuW52xsSWMTaBgnoY3qe/9plb6HPv1UDsA7DZs9vuBRJNXpiKVDAhFPKgzLX8bNAexb13SGE1/2Y8h29tAy2gpiYrDPfQX4k1Cr9X3ThJLgO8eFoLzEapSabLrQLBzBSH+nF5HherrrOogI0L3MtUolKoSX6EHyGKsJRpdb2kYknN4/yrmTqUuMy5v1a0zmATdVJHmXl1k0jzd1ykmON3vdGlItacsORn5aFKQbHTonWlrZHIyA4jK8HxhKGP4pr8nXbBgPcX7hZ2TWEoSrohNQcWvMAXBf0W4IHx1BvLUWh3eHQF+UJVgvCnD/DbTCeO/ufyG3h339r34NgrQX5GvW69X0eyIdw8 kO1cv1uF VyxxVAMugIMavToc2F1LGp1GFNC+0sqS6eR1p0JiZekRklhwnv9A+DXZptVZ3G58vlVTELJqs1uV2qBv+gVi0mQyAhVkOyMwao8nns3NugFbLOVY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001947, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Should this be merged independently (and sooner? in rc5?) On Mon, Apr 15, 2024 at 8:04=E2=80=AFAM David Howells = wrote: > > Jeff Layton wrote: > > > > +struct cifs_fscache_inode_key { > > > + > > > + __le64 uniqueid; /* server inode number */ > > > + __le64 createtime; /* creation time on server */ > > > + u8 type; /* S_IFMT file type */ > > > +} __packed; > > > + > > > > Interesting. So the uniqueid of the inode is not unique within the fs? > > Or are the clients are mounting shares that span multiple filesystems? > > Or, are we looking at a situation where the uniqueid is being quickly > > reused for new inodes after the original inode is unlinked? > > The problem is that it's not unique over time. creat(); unlink(); creat(= ); > may yield a repeat of the uniqueid. It's like i_ino in that respect. > > David > --=20 Thanks, Steve