Re: [PATCH 3/7] rust: mm: update ARef and AlwaysRefCounted imports from sync::aref

[Alice Ryhl <aliceryhl@google.com>]

On Wed, Jul 16, 2025 at 11:16 AM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
> Update call sites in the mm subsystem to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
>
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>

Andrew, would you be able to pick up this patch? Thanks!

Acked-by: Alice Ryhl <aliceryhl@google.com>

> It part of a subsystem-wise split series, as suggested in:
> https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> This split series is intended to ease review and subsystem-level maintenance.
>
> The original moving patch is here:
> https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/
>
> Gradually the re-export from types.rs will be eliminated in the
> future cycle.
> ---
>  rust/kernel/mm.rs             | 3 ++-
>  rust/kernel/mm/mmput_async.rs | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/mm.rs b/rust/kernel/mm.rs
> index 43f525c0d16c..4764d7b68f2a 100644
> --- a/rust/kernel/mm.rs
> +++ b/rust/kernel/mm.rs
> @@ -13,7 +13,8 @@
>
>  use crate::{
>      bindings,
> -    types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque},
> +    sync::aref::{ARef, AlwaysRefCounted},
> +    types::{NotThreadSafe, Opaque},
>  };
>  use core::{ops::Deref, ptr::NonNull};
>
> diff --git a/rust/kernel/mm/mmput_async.rs b/rust/kernel/mm/mmput_async.rs
> index 9289e05f7a67..b8d2f051225c 100644
> --- a/rust/kernel/mm/mmput_async.rs
> +++ b/rust/kernel/mm/mmput_async.rs
> @@ -10,7 +10,7 @@
>  use crate::{
>      bindings,
>      mm::MmWithUser,
> -    types::{ARef, AlwaysRefCounted},
> +    sync::aref::{ARef, AlwaysRefCounted},
>  };
>  use core::{ops::Deref, ptr::NonNull};
>
> --
> 2.34.1
>