From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx134.postini.com [74.125.245.134]) by kanga.kvack.org (Postfix) with SMTP id 582C36B00B2 for ; Mon, 4 Feb 2013 18:52:03 -0500 (EST) Received: by mail-ie0-f169.google.com with SMTP id 13so4610674iea.0 for ; Mon, 04 Feb 2013 15:52:02 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20130204234358.GB2610@blaptop> References: <1359973626-3900-1-git-send-email-m.szyprowski@samsung.com> <20130204150657.6d05f76a.akpm@linux-foundation.org> <20130204234358.GB2610@blaptop> Date: Tue, 5 Feb 2013 08:52:02 +0900 Message-ID: Subject: Re: [PATCH] mm: cma: fix accounting of CMA pages placed in high memory From: Kyungmin Park Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , Marek Szyprowski , linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@suse.de Hi, On Tue, Feb 5, 2013 at 8:43 AM, Minchan Kim wrote: > Hello, > > On Tue, Feb 05, 2013 at 08:29:26AM +0900, Kyungmin Park wrote: >> On Tue, Feb 5, 2013 at 8:06 AM, Andrew Morton wrote: >> > On Mon, 04 Feb 2013 11:27:05 +0100 >> > Marek Szyprowski wrote: >> > >> >> The total number of low memory pages is determined as >> >> totalram_pages - totalhigh_pages, so without this patch all CMA >> >> pageblocks placed in highmem were accounted to low memory. >> > >> > What are the end-user-visible effects of this bug? >> >> Even though CMA is located at highmem. LowTotal has more than lowmem >> address spaces. >> >> e.g., >> lowmem : 0xc0000000 - 0xdf000000 ( 496 MB) >> LowTotal: 555788 kB >> >> > >> > (This information is needed so that others can make patch-scheduling >> > decisions and should be included in all bugfix changelogs unless it is >> > obvious). >> >> CMA Highmem support is new feature. so don't need to go stable tree. > > I would like to clarify it because I remembered alloc_migrate_target have considered > CMA pages could be highmem. Is it really new feature? If so, could you point out > enabling patches for the new feature? > Here's related patch. http://www.spinics.net/lists/arm-kernel/msg222369.html Previous time, it's not fully tested and now we checked it with highmem support patches. Thank you, Kyungmin Park > struct page *alloc_migrate_target(struct page *page, unsigned long private, > int **resultp) > { > gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE; > > if (PageHighMem(page)) > gfp_mask |= __GFP_HIGHMEM; > > return alloc_page(gfp_mask); > } > > Thanks. > >> >> Thank you, >> Kyungmin Park >> > >> > -- >> > To unsubscribe, send a message with 'unsubscribe linux-mm' in >> > the body to majordomo@kvack.org. For more info on Linux MM, >> > see: http://www.linux-mm.org/ . >> > Don't email: email@kvack.org >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: email@kvack.org > > -- > Kind regards, > Minchan Kim > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org