From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by kanga.kvack.org (Postfix) with ESMTP id 5602D6B2F8D for ; Fri, 23 Nov 2018 01:11:23 -0500 (EST) Received: by mail-lj1-f198.google.com with SMTP id e8-v6so3112416ljg.22 for ; Thu, 22 Nov 2018 22:11:23 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a22-v6sor9938989ljd.6.2018.11.22.22.11.21 for (Google Transport Security); Thu, 22 Nov 2018 22:11:21 -0800 (PST) MIME-Version: 1.0 References: <1542799799-36184-1-git-send-email-ufo19890607@gmail.com> <1542799799-36184-2-git-send-email-ufo19890607@gmail.com> <20181122133954.GI18011@dhcp22.suse.cz> In-Reply-To: <20181122133954.GI18011@dhcp22.suse.cz> From: =?UTF-8?B?56a56Iif6ZSu?= Date: Fri, 23 Nov 2018 14:11:09 +0800 Message-ID: Subject: Re: [PATCH v15 2/2] Add oom victim's memcg to the oom context information Content-Type: multipart/alternative; boundary="00000000000024b275057b4eda1a" Sender: owner-linux-mm@kvack.org List-ID: To: mhocko@kernel.org Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu --00000000000024b275057b4eda1a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Michal I just rebase the patch from the latest version. Michal Hocko =E4=BA=8E2018=E5=B9=B411=E6=9C=8822=E6=97= =A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=889:39=E5=86=99=E9=81=93=EF=BC=9A > On Wed 21-11-18 19:29:59, ufo19890607@gmail.com wrote: > > From: yuzhoujian > > > > The current oom report doesn't display victim's memcg context during th= e > > global OOM situation. While this information is not strictly needed, it > > can be really helpful for containerized environments to locate which > > container has lost a process. Now that we have a single line for the oo= m > > context, we can trivially add both the oom memcg (this can be either > > global_oom or a specific memcg which hits its hard limits) and task_mem= cg > > which is the victim's memcg. > > > > Below is the single line output in the oom report after this patch. > > - global oom context information: > > > oom-kill:constraint=3D,nodemask=3D,cpuset=3D,mems_allowed=3D,global_oom,task_memcg=3D,task=3D,pid=3D,uid=3D > > - memcg oom context information: > > > oom-kill:constraint=3D,nodemask=3D,cpuset=3D,mems_allowed=3D,oom_memcg=3D,task_memcg=3D,ta= sk=3D,pid=3D,uid=3D > > > > Signed-off-by: yuzhoujian > > I thought I have acked this one already. > Acked-by: Michal Hocko > -- > Michal Hocko > SUSE Labs > --00000000000024b275057b4eda1a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Michal
I just rebase the patch from the latest vers= ion.


Michal = Hocko <mhocko@kernel.org> = =E4=BA=8E2018=E5=B9=B411=E6=9C=8822=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5= =8D=889:39=E5=86=99=E9=81=93=EF=BC=9A
On Wed 21-11-18 19:29:59, ufo19890607@gmail.com wrote:
> From: yuzhoujian <yuzhoujian@didichuxing.com>
>
> The current oom report doesn't display victim's memcg context = during the
> global OOM situation. While this information is not strictly needed, i= t
> can be really helpful for containerized environments to locate which > container has lost a process. Now that we have a single line for the o= om
> context, we can trivially add both the oom memcg (this can be either > global_oom or a specific memcg which hits its hard limits) and task_me= mcg
> which is the victim's memcg.
>
> Below is the single line output in the oom report after this patch. > - global oom context information:
> oom-kill:constraint=3D<constraint>,nodemask=3D<nodemask>,c= puset=3D<cpuset>,mems_allowed=3D<mems_allowed>,global_oom,task_= memcg=3D<memcg>,task=3D<comm>,pid=3D<pid>,uid=3D<uid&g= t;
> - memcg oom context information:
> oom-kill:constraint=3D<constraint>,nodemask=3D<nodemask>,c= puset=3D<cpuset>,mems_allowed=3D<mems_allowed>,oom_memcg=3D<= memcg>,task_memcg=3D<memcg>,task=3D<comm>,pid=3D<pid>,= uid=3D<uid>
>
> Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>

I thought I have acked this one already.
Acked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
--00000000000024b275057b4eda1a--