linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: 禹舟键 <ufo19890607@gmail.com>
To: willy@infradead.org
Cc: akpm@linux-foundation.org, mhocko@suse.com, rientjes@google.com,
	kirill.shutemov@linux.intel.com, aarcange@redhat.com,
	penguin-kernel@i-love.sakura.ne.jp, guro@fb.com,
	yang.s@alibaba-inc.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Wind Yu <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v7 1/2] Add an array of const char and enum oom_constraint in memcontrol.h
Date: Sat, 2 Jun 2018 19:22:23 +0800	[thread overview]
Message-ID: <CAHCio2iHGd6BF2jBHWWAbvtu38OY=Hs2EikWdESzELW_h47EoA@mail.gmail.com> (raw)
In-Reply-To: <20180602111940.GA31754@bombadil.infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

Hi Mattew
Please discard this email, and I will send another email again.

Thanks

Matthew Wilcox <willy@infradead.org> 于2018年6月2日周六 下午7:19写道：

> On Sat, Jun 02, 2018 at 07:06:44PM +0800, 禹舟键 wrote:
> > From: yuzhoujian <yuzhoujian@didichuxing.com>
> >
> > This patch will make some preparation for the follow-up patch: Refactor
> > part of the oom report in dump_header. It puts enum oom_constraint in
> > memcontrol.h and adds an array of const char for each constraint.
>
> This patch is whitespace damaged.  See the instructions for using git
> send-email with gmail: https://git-scm.com/docs/git-send-email
>
> > +static const char * const oom_constraint_text[] = {
> > + [CONSTRAINT_NONE] = "CONSTRAINT_NONE",
> > + [CONSTRAINT_CPUSET] = "CONSTRAINT_CPUSET",
> > + [CONSTRAINT_MEMORY_POLICY] = "CONSTRAINT_MEMORY_POLICY",
> > + [CONSTRAINT_MEMCG] = "CONSTRAINT_MEMCG",
> > +};
> > +
>
> Um, isn't this going to put the strings in every file which includes
> memcontrol.h?
>

[-- Attachment #2: Type: text/html, Size: 1585 bytes --]

  reply	other threads:[~2018-06-02 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-02 11:06 [PATCH v7 1/2] Add an array of const char and enum oom_constraint in memcontrol.h 禹舟键
2018-06-02 11:19 ` Matthew Wilcox
2018-06-02 11:22   ` 禹舟键 [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-06-02 11:58 ufo19890607
2018-06-02 11:58 ` ufo19890607
2018-06-04  6:48 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHCio2iHGd6BF2jBHWWAbvtu38OY=Hs2EikWdESzELW_h47EoA@mail.gmail.com' \
    --to=ufo19890607@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rientjes@google.com \
    --cc=willy@infradead.org \
    --cc=yang.s@alibaba-inc.com \
    --cc=yuzhoujian@didichuxing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).