From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B68C83F21 for ; Thu, 10 Jul 2025 18:25:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 845796B009A; Thu, 10 Jul 2025 14:25:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F6246B009B; Thu, 10 Jul 2025 14:25:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 733566B009C; Thu, 10 Jul 2025 14:25:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 65B7F6B009A for ; Thu, 10 Jul 2025 14:25:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E10FCBC372 for ; Thu, 10 Jul 2025 18:25:30 +0000 (UTC) X-FDA: 83649182820.23.99DEF5C Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf15.hostedemail.com (Postfix) with ESMTP id E6877A0008 for ; Thu, 10 Jul 2025 18:25:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f+IhH5bl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of almasrymina@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=almasrymina@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752171929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MGttGecOUfnj2vDKboTFLlNArn06kYu+jY7WB+vGDSo=; b=UZwGm8B2YJjH/sD32nkb9b7dB5ZCuxdEHmMCMrF1RK8siaIqsL34BChFagm+Mu5JpAr05J qHvfsKZOIoH6uYSwakUiwQ+nsqU18CXWhYTNZcq/sLm92gYaeYX4Hwi2F4wzAJPD6oumH/ adlBEV2fVf6f+0sOHM5J1+Rxi91Kmho= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752171929; a=rsa-sha256; cv=none; b=ej2bzfqOsKMLpM33OquWiJ9EOJaIcy4RJ9jl+xDwlPudUM+/8IEyQqX0KsEGb/Pltm9R1b vVs05nYiB+sj7qpbB1GT2qSwK1JYuQNBTzMeM4zkx5hhqAGoLaUM4rhHm4IHC1+pjkUuZa jxoVw6vKPTaGMDlDJ1HA9EdTzsDd3Jc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f+IhH5bl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of almasrymina@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=almasrymina@google.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-60b86fc4b47so1631a12.1 for ; Thu, 10 Jul 2025 11:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752171927; x=1752776727; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MGttGecOUfnj2vDKboTFLlNArn06kYu+jY7WB+vGDSo=; b=f+IhH5blLHubTddqvrvt6hYpMVrvflMfL484RguHPB8aX8Oq014PXXiEbJoQh4S+2i eqlcKuO9Ml8ig0Wssq+QnvIo0CfJrZWVS4IQqze1l+mpKzHDoZnsTtoiGm5+bVATXbMj 2iUO1t3/9Z1Qe2ykX3ObrnFfrzuacHKbfqi/MG1W8/8l29MH6zoai4szXQAZXxmIvYJv 420MZyEZsh+iuRlj+Isqv5EkTggoY1P16eZZMmnnKT38aGycA2g0cORbHkLYignKxs0Y TY6UfZCYtKRHIL1F0lDP42s/pSX6F8ahIvF79Yk5nFMJdFDC0JU5yTX2bx0yd3BiBtZ8 +9+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752171927; x=1752776727; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MGttGecOUfnj2vDKboTFLlNArn06kYu+jY7WB+vGDSo=; b=LG6gpwnXldlFgIh+XTMYi3xfMfWI6FaSMQNwHFXZS9nM/KrNQwc4XvMB7D7xM1KU4d JdZP6Wa7bJ/d1p1ZfRQbh96gMOtGZzmr2WZ5KRc5CeD3tnPhHBGGcS4rJTfxqp+x06QR Xf1Ganro4SeeSNk5zf4tKmsbEMR0kJ7BIeZoSTnGeVvFgd55JxcIvqoLospDxrLyfKW8 cG9mHzgbBZNv+zF6eJHM8lLo1TFhyJ3pdhN/JffY/kxhtkgUJ7DISkQ88OlhvWdim2so /LkQ8WnwGl0tOk+uH9TYM9i8jvOyF3SBgnsXwJWk70xP4QUyD66g+gn0+NZ4d9/eqERn QEww== X-Forwarded-Encrypted: i=1; AJvYcCUkA4j4UubI7hZPr7cAsBpf+2+N7zM7c2CwhAsOhHnDC/zY4qHZj6YSyPsbnUSmy+DQPzvFybNX4A==@kvack.org X-Gm-Message-State: AOJu0YwVT5f+AkowsBEKvzzO4wKTaWwWlIdpq3AzRT+1SQJuDe1EbN4U yI8Otp+fOSqQ19KIDFYhPwY1+/Efby1kdHXHJmjX3gvCy3r6lenzB1maBu7Y839uQxjeIky77Ux 3AFzt9vy5tmPUsGm+Uo32Z1zR8K0YuC6unOBMt6QE X-Gm-Gg: ASbGnctzuaa+LlbkwpU9G3zpAfjtFlTR8OAnM3QaiqQtcXIZNyPZGM5259oxCixPdrn 1gP8PIu/By25grW1F2d4PoTrM6pt+dM7nwL2G8NYKQ4UgTKoZGLo9PefsCK5vq/5McgwhYna1Hh rE7swsKfyVsrwWnmXtm80RGpia7hOtlYsHFLEQTRjn8WocLLW/zeOw0Qpq28sPFhiIBHdm2og= X-Google-Smtp-Source: AGHT+IFYbu4F77iXBeAnMl5OLLUNqSyy6NKKa5nSrUrX3MSMLO1UBBwllp1ZZ2m2gbUJ8CJrAGBesZolk6+61YYGeCs= X-Received: by 2002:a05:6402:30a6:b0:606:b6da:5028 with SMTP id 4fb4d7f45d1cf-611e66aa77bmr9269a12.0.1752171927040; Thu, 10 Jul 2025 11:25:27 -0700 (PDT) MIME-Version: 1.0 References: <20250710082807.27402-1-byungchul@sk.com> <20250710082807.27402-5-byungchul@sk.com> In-Reply-To: <20250710082807.27402-5-byungchul@sk.com> From: Mina Almasry Date: Thu, 10 Jul 2025 11:25:12 -0700 X-Gm-Features: Ac12FXxKh5TJZHgIcSqvUZXVnJGYFBLJKrIZOv19NnRAZsweNKYOtzi0atTHg_c Message-ID: Subject: Re: [PATCH net-next v9 4/8] netmem: use netmem_desc instead of page to access ->pp in __netmem_get_pp() To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E6877A0008 X-Stat-Signature: k8qza5xfa9c5hos5xrw64ywyi1yk7yi4 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752171928-855605 X-HE-Meta: U2FsdGVkX1+MjjL9DkNooQmKZnLpyzOjhAaUZSCJqfUHgaI1I2QzujPIRNm5DjiXdNlZvSsOlWrd6QJ/L0HyFpf5sqZm80dm/FxD81Lywfz8Rqv5V830KKqxLf35VR0qxApYubLFE2kJHhF1ix0/HzjCFjGIV6Sd0IAoVoH9nvH2Hx3Fulns3ggJuLmqSDCEVbsj1PDxAFGOwwgn0viMtl/tps6deQ0wVYiVO2zfhrGq+H4YkKbpV8/ut2AJym2VWp3adLDKxXjrSEjL5dwTwo21qfYJZL5ekeuk8zpxTfG8YODOz4dkrRNdgk4QIUGjg4Z6gf39JhY93GihMNwdOgwrv1gjyftQUvhXovKZt+VTgBNlEaXLAaPqpvFAwo8i4T0xRA67j0h+1JQohv7lo2G2E+n7h8lMB5hGAQBQgdImCa14x9EraMyw/o8SCVXgfL5B+vX8TFm4SopFUS1JOsBiDp04AXdgvmKTgkebpBZ69Mjix5IIfiOA7L2mGMJnDwE6e1NF6mqp0KqumnHVk4sKgrMjbGc898TlZN/DLyHr+KwBNW92q9THdzf4pfOE/nYiqfsSmpfs7HvS2Yy0Nwd00hysXspoy81QRJGaBOSSetglmnp6BONHPPjL1EXgckTse/REheBACX3ILdjbb/TyfiVzuD9WIF49qlcAFpH+1i+IUrjeqNQnSVJgsgnAVAGjmSQlY9p4ZFp7J0pj5qlkW3+JSuFAKjAu9jEWUKTnjMs/r3FeEJyF/VvHpKKdRYD+Xc5wlvpiTQ3S6f4iPmRZSaa6PO+3YeouYLJAN6cI/1ya10FlGVP4Smh8Aaodxo1hWU/tRioMJoVMMZgDfrVgqCYEzpSWU1Aep6KizcVIugR7NmHNdbqOiZ6F+NsYUcWxFTcT0Rh1RekZUz7lbBpWxWRpQgwli0S+haBuvWPqHl/vwhqtHDB2m0l5U8H6eVkulSQzf8/kps42/kv uVHUG4mY QGciVipxUWUljcVMgPzsvBwib8ejFPhcp2UdRvH4g2ce5PT7tBvFiLrjMrRZfJI4aN3XJXdmjl/EegndiNDA/ZdwZfRVQ07AAc06eYKtv+yrXHCpwSgshJhoFIHdB7OBqS7EF2z0FPBLcJO0UsDJhjWfOp0pH9TWlMLMrgF4c2oDzrB3mjatdE8ndzY8ox20jdajKpICwrsjCMScrjBOzOZSoGQxCGfU49GtJxoUzH9Uo++oZBxOisXCFRgaQtVzPXN5UVHSWnCe1T3ZD64me58jDzyrgmdvX54iKONo1EkttDXQTYSH0qJJSF8wY4UU8CmASD6Q9NtIzYI/5UH02urhL0lLGc3nyuPi0UPuTVcqyPqU//VwIi5XrJFiJBrCe8Jqj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 1:28=E2=80=AFAM Byungchul Park w= rote: > > To eliminate the use of the page pool fields in struct page, the page > pool code should use netmem descriptor and APIs instead. > > However, __netmem_get_pp() still accesses ->pp via struct page. So > change it to use struct netmem_desc instead, since ->pp no longer will > be available in struct page. > > Signed-off-by: Byungchul Park > --- > include/net/netmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/netmem.h b/include/net/netmem.h > index 11e9de45efcb..283b4a997fbc 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -306,7 +306,7 @@ static inline struct net_iov *__netmem_clear_lsb(netm= em_ref netmem) > */ > static inline struct page_pool *__netmem_get_pp(netmem_ref netmem) > { > - return __netmem_to_page(netmem)->pp; > + return __netmem_to_nmdesc(netmem)->pp; > } > __netmem_to_nmdesc should introduced with this patch. But also, I wonder why not modify all the callsites of __netmem_to_page to the new __netmem_to_nmdesc and delete the __nemem_to_page helper? --=20 Thanks, Mina