From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F42DC33CB3 for ; Tue, 14 Jan 2020 22:56:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C2B60214AF for ; Tue, 14 Jan 2020 22:56:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BXtYSede" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2B60214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D99C8E0006; Tue, 14 Jan 2020 17:56:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58AA08E0003; Tue, 14 Jan 2020 17:56:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C7758E0006; Tue, 14 Jan 2020 17:56:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 373E78E0003 for ; Tue, 14 Jan 2020 17:56:07 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 6C8C8181AEF00 for ; Tue, 14 Jan 2020 22:56:06 +0000 (UTC) X-FDA: 76377749532.29.grass29_525e210f10221 X-HE-Tag: grass29_525e210f10221 X-Filterd-Recvd-Size: 3617 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jan 2020 22:56:05 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id m2so9501723otq.3 for ; Tue, 14 Jan 2020 14:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ipIhJjAH0mlgj9mgI3WhoNWssFh6GjBw0YOeerhZCcU=; b=BXtYSedeHXcXqhdhhWIbtaBy54tVxbI3e9loIGv5zhO5CDgbahYX7y+Orjx6CD4zCZ 0VhZIf5F4aluPlRU7PpNhbbEGba3pmcWe+cL3CBi5DKya+w5q6G9eUjD6Y6LZi3IlJ3t DrJUFTIu5BCbGGqB1F/xwGxS7UBhnEduOl7KTKpELe4ehBWkmis+mzbELNb1lGuQU++3 QqqpluWfbXgvT/3D7WUNnyrjmuuZFxOwFtqlIlsp5tc9+S7eipRPEcevYerqbyHWNTNb Hhqn87JV86nkgRWq1rMf/JsZJIoYLMVRDfzRbSZxDqafJRFy4Ttng/Rd5qCfuV8koCw1 S2/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ipIhJjAH0mlgj9mgI3WhoNWssFh6GjBw0YOeerhZCcU=; b=nSSVo13DyCxBE23boJ07y2Daizd/CrsgE3+hT0lFqMCrkWFND8nH8roAlVVsplwDWv KXYIZ8YobXHxKR9vKlPVOpv69naj1kIWGVuekz0/Z+KPD5dSH7q/5O+AK3ymIT5hG0nB u1RORuP5mkLIqxafYWLmM3NPkAuadMDOWFv7gq6+hro46vmOmqIws3QmoENeKonueARZ wzlyQNMfiq01T/BmnHt4NoBCZQzZYpG8TNDOqduWsmH9xpU9JxJSl9uV2YxVTXXxLohz I7pQUBakEx0g4/KJgUIeIFFOX61XZZtwk/N5U/Qw1lWpdAgTpAi5Iozn3vKfKp74nnRN rCfw== X-Gm-Message-State: APjAAAVqvqF14Zvr9qSAx5XvvCNlITY8g8G8uqCQfGdd+lxon/W8aBWz V5I/R0Bq0JsdtGBjF9JcSrcSX3Ctuz7xMLClJQdjeg== X-Google-Smtp-Source: APXvYqyQmL6MY3CQ5veK4yvMgm0Vfzi0RP3qvYcRSIpcE0TmezTJR9GdGI42+n8t1PA73eDd8usJHxZikf9yyvXL7gA= X-Received: by 2002:a9d:7b4e:: with SMTP id f14mr557782oto.355.1579042565055; Tue, 14 Jan 2020 14:56:05 -0800 (PST) MIME-Version: 1.0 References: <20191217231615.164161-1-almasrymina@google.com> <20191217231615.164161-2-almasrymina@google.com> <0855cae0-872e-0727-aa7c-55051d8f0871@oracle.com> In-Reply-To: <0855cae0-872e-0727-aa7c-55051d8f0871@oracle.com> From: Mina Almasry Date: Tue, 14 Jan 2020 14:55:53 -0800 Message-ID: Subject: Re: [PATCH v9 2/8] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations To: Mike Kravetz Cc: shuah , David Rientjes , Shakeel Butt , Greg Thelen , Andrew Morton , open list , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, Aneesh Kumar , =?UTF-8?Q?Michal_Koutn=C3=BD?= Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 13, 2020 at 2:14 PM Mike Kravetz wrote: > > +extern void hugetlb_cgroup_uncharge_counter(struct page_counter *p, > > + unsigned long nr_pages, > > + struct cgroup_subsys_state *css); > > + > > Do we need a corresponding stub for the !CONFIG_CGROUP_HUGETLB case? > Not necessary AFAICT because the code is only called from code guarded by CONFIG_CGROUP_HUGETLB. Addressing comments from you and David in v10 shortly. Thanks for the review!