From: Mina Almasry <almasrymina@google.com>
To: David Howells <dhowells@redhat.com>
Cc: willy@infradead.org, hch@infradead.org,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: Device mem changes vs pinning/zerocopy changes
Date: Thu, 5 Jun 2025 12:30:26 -0700 [thread overview]
Message-ID: <CAHS8izPOonh6E3B+xHRSsfXpo_jHXymVyNOZOUc_1LjOtT9wow@mail.gmail.com> (raw)
In-Reply-To: <1099957.1749052763@warthog.procyon.org.uk>
On Wed, Jun 4, 2025 at 8:59 AM David Howells <dhowells@redhat.com> wrote:
>
> (Apologies, I accidentally sent the incomplete email)
>
> > I think you need to modify the existing sk_buff. I think adding
> > a new struct and migrating the entire net stack to use that is a bit
> > too ambitious. But up to you. Just my 2 cents here.
>
> It may come down to that, and if it does, we'll need to handle frags
> differently. Basically, for zerocopy, the following will all apply or come to
> apply sometime in the future:
>
> (1) We're going to be getting arrays of {physaddr,len} from the higher
> layers. I think Christoph's idea is that this makes DMA mapping easier.
> We will need to retain this.
>
I would punt this to a follow up project. Currently the net stack uses
pages extensively; replacing them with scatterlist-like {physaddr,
len} sounds like a huge undertaking. Especially with the conversion to
netmem_desc happening in parallel with Byungchul's series. Just my 2
cents.
--
Thanks,
Mina
prev parent reply other threads:[~2025-06-05 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 15:14 Device mem changes vs pinning/zerocopy changes David Howells
2025-05-30 15:50 ` Stanislav Fomichev
2025-05-30 16:22 ` Mina Almasry
2025-06-04 14:56 ` David Howells
2025-06-05 18:59 ` Mina Almasry
2025-06-04 15:34 ` David Howells
2025-06-05 19:27 ` Mina Almasry
2025-06-04 15:59 ` David Howells
2025-06-05 19:30 ` Mina Almasry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHS8izPOonh6E3B+xHRSsfXpo_jHXymVyNOZOUc_1LjOtT9wow@mail.gmail.com \
--to=almasrymina@google.com \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).