From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B073DC19F53 for ; Sat, 27 Apr 2024 02:11:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4C46B0082; Fri, 26 Apr 2024 22:11:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3C716B0083; Fri, 26 Apr 2024 22:11:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB6286B0085; Fri, 26 Apr 2024 22:11:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9A2176B0082 for ; Fri, 26 Apr 2024 22:11:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1D2711608D4 for ; Sat, 27 Apr 2024 02:11:25 +0000 (UTC) X-FDA: 82053684930.11.8C4E11D Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf18.hostedemail.com (Postfix) with ESMTP id 461E51C0006 for ; Sat, 27 Apr 2024 02:11:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aEcOCA0v; spf=pass (imf18.hostedemail.com: domain of almasrymina@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714183882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VCqXmA+0tJPmuPol3Ypy0jPmfZ3hkXnnk0DE4uLAUwU=; b=ctcLADdJJVcEYkwLviSCwiB4zsJWZXFDMO7T7BQ2vqAfFv7kjz8PS9auy8RNVwCUzrVoEh dVUberjZakJLeSEl4BdP2xWWo25qyNvJs2ZDKZ+iPlHP7tVrPFJvr0gjRWBSiKSh7lAHf9 dPmHVUxIzE/F8M2JqeohlepdY5OTKMY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aEcOCA0v; spf=pass (imf18.hostedemail.com: domain of almasrymina@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=almasrymina@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714183882; a=rsa-sha256; cv=none; b=3mZ/4VEcoIVhiiklmX3tKojt8XYLkfApiSJ8vZtjRrshGtY2xq3L9I8iKu1a13y5fnJL8w jSw/4fsnTcegW1toQKUtY/oS6UfK3KT5DHERjR9bt3/ADor+V/wD227NCUWqjqFF6SZe8p tWv1LdQB0P9xtZKFt0Zjm74QtQ/mPAg= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a58e787130fso18625766b.0 for ; Fri, 26 Apr 2024 19:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714183880; x=1714788680; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VCqXmA+0tJPmuPol3Ypy0jPmfZ3hkXnnk0DE4uLAUwU=; b=aEcOCA0vuA//FId9UXtGgrGNX8UEadGnOf+3REE/qWBO1NrAtVOIrlAhW6z3kEbVNI 0mzBg+SKQm+a4kkOEFOVariG9ZEfTHbxqr5VaYE3mjO5TbnoNvTeU4wz1Ap0ivokfXel /3p4UnPYQmyfA+iXywlgevfOQ9yLDxDhZPNePvhiUeYCg1qwoPX5iULgtzMufkfN+dWy yfYpJlc601SBxfzSXf7DecjD5fSptLlKxxgxNUMx7/XAcZeJ1pF5GhaBMLen8jmRIA+S PYAF+85jlc5Wnch3nK129axlFfFOk9vA26O6RlQpVPtcsafqbAYXWg2Yik23ibVwgj6k zs0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714183880; x=1714788680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VCqXmA+0tJPmuPol3Ypy0jPmfZ3hkXnnk0DE4uLAUwU=; b=Bfh9cQuWKl9sxik/jpGFyzg7Hg5MJ+P7zUSN2lYoVjDO2Z5w6S/Band+5fQQtXQ0Ni WViAeFXoJnbmhCF+kpCc/aQCVE6B25boUY0Ga8e52o8jq++/xLIz7tcJh8iaow9QQOXG 36WAZDPXa9JuPHGX5uV1sbsOSzl5j86LsyGLNvwZodRNujBRDDC0GUI6i0PStpPpSVo2 fcuwyCVxy8VgwWLM4r8a8sypilaGLbw2akmDGr5v8jnb09oDlp2kK1y97MPnQpEKuHDe NWDQCdXiMO9Vc0QW179F/fHGKdzRjjbkHgbNt8dI+MnMloOmK3X/g9YIKsjSpt0I/jZf GPJg== X-Forwarded-Encrypted: i=1; AJvYcCXPUiznH4iZkH9/WEVutQgRWhU8nXsBKjkOBglG66ID+njqoJdXVaU9bjgZh6DXU3Bo92JaGCNJ8rI6lvdJ26OOr7o= X-Gm-Message-State: AOJu0YzVqWScfsMUt4yWfBJOupSSar27ZCqu7j0pwNOg7P9VHnf7O02z pS6NMH2ZjaX3srTXbA1xSdm7o5mOThdFlgYqfw0o0v+djYhSy7/1R9lCXcwRTFGdT445XdZrt9A CjtSzyxU55TZciOYWn1xUfAQnOyymYcF1X0I/ X-Google-Smtp-Source: AGHT+IGYpMq0S7NMYmgbheltdqICqswpFYbRt1nWr9f34ViEhM+DD9iOxk080j42Jd8vuPQgs8NIkJRSPoJ58AydrBw= X-Received: by 2002:a17:907:a49:b0:a58:c550:a102 with SMTP id be9-20020a1709070a4900b00a58c550a102mr4510853ejc.29.1714183880204; Fri, 26 Apr 2024 19:11:20 -0700 (PDT) MIME-Version: 1.0 References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-8-almasrymina@google.com> <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> In-Reply-To: <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> From: Mina Almasry Date: Fri, 26 Apr 2024 19:11:07 -0700 Message-ID: Subject: Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support To: David Wei Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Amritha Nambiar , Maciej Fijalkowski , Alexander Mikhalitsyn , Kaiyuan Zhang , Christian Brauner , Simon Horman , David Howells , Florian Westphal , Yunsheng Lin , Kuniyuki Iwashima , Jens Axboe , Arseniy Krasnov , Aleksander Lobakin , Michael Lass , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Richard Gobert , Sridhar Samudrala , Xuan Zhuo , Johannes Berg , Abel Wu , Breno Leitao , Pavel Begunkov , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: g4t1xf9srpfd8nw9q7mkpbgbrm8iwq4t X-Rspam-User: X-Rspamd-Queue-Id: 461E51C0006 X-Rspamd-Server: rspam05 X-HE-Tag: 1714183882-12631 X-HE-Meta: U2FsdGVkX1+Xkk16eWvkKySjUuskpd8g8bTOKUkv4tHXL8qRE8kEaGA7r1mOBSoAm8LerhNBQxjhY0sTIv8zMHWRoFabZmFlLcPvMX7xYi7v2h8JM3QirybsoT7e3J5P55e85VulbQLKKs9xU6r0NfL5KdkE0yknW5L1gjFfERphlB3pTv7d0n9ICwBbrkrBNt8TOALLzPnZ1i7TedC2lmcaeZ3pLbI4gXyE/rwN8/Uq11SP+fEzPB/UOEjEL0UPBO6Y0YbN7SPgaPCqqP4xSFyGiVDj11t2RH2uCFLkA5ij32vDug6d23xyGQ5Z3SXWtN2Ud29qFzin/P5F648OZnC/97KevOJPz8BGUm1o0rfoDTvdJHer52PGbhi2Q/Gp0F5HLm6QapPfSOkKCt7TrkINDEJaqWdy6bLgu93Ni8dBk9jqhLja+t2RZifNJsaM29W2AjCXTVpGJ5Vy3+dHc4eu0luFmsnjVCu+mpOd3HBpCaBtcI8Ks/que80r8Z4PGQ3mD1XwNJO00FX9IhnGa7NCqsc/k7GelG2Oc70iwBNgQHITCz9647364lmW1P5RBr7AwV5wkghi+xAdSdPEKO1TqrXc9t6lWsQTzGYW+y+MuxBt0mc+oRLZYZBBlvPRFENLqPagF4zMhDfFeeLx52DzcQAuakMBGkhIk9YCnPjyYVzzleCvttwisjPVjKtAgOorjJx2OFC3clu6Gszse5RGCQXxAMVZb0kH+4/zhr4vLaJvagi0hOH5sncPJK8EnDkqE5c3P23nuURdjm/qc+tbQxgV0APFPANdoalkXf2000DwDOCll/81ADku44IsjKz+8h+vGJBUgeG7xIP0NTZ1NPN3tI9MHk47k7PmS1ug4ER/3eQDWUfAtCjlswy/YmZ/oaCpuQGHxDyp1FZkhR2m94u4UaPmAXF0iMnEJAwFsY+7r5dN9jjKnlDSB+QMkJCtv6PjQq/LDcv1SiZ xCY5ob61 O8gOcs5GE8OmXbJ69C/BrcLQZQx91q1IyXFDkOsCivF7HOPw7zuN9hFPhXLClFAdG6/u54u04totV0DgXlTMPdzvh9caS7zMGazndWyNIJMkF4v+efMbIFWzlmVjCpFXZnvWmHjtDlCkFwOPEJJjtHE3kcizuXzYrTxMgmprDcK87/gAJymdGKNzxCRaYehcDJr53LDig9PksBwTYAihFyj+++0ddtf7kfYjjbHhaMo3EAclg8N8/ARpgbsHsgOk84hVO6C+AOFo1UtzhLYaOHOVg4/xata4FcRcDV+KU+PCKl2fs9VcJ0Cy/6DJp03F+4ds++F+SqpD75Tv4IYndHCBgwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 5:18=E2=80=AFPM David Wei wrote: > > On 2024-04-02 5:20 pm, Mina Almasry wrote: > > @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) > > */ > > typedef unsigned long __bitwise netmem_ref; > > > > +static inline bool netmem_is_net_iov(const netmem_ref netmem) > > +{ > > +#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER) > > I am guessing you added this to try and speed up the fast path? It's > overly restrictive for us since we do not need dmabuf necessarily. I > spent a bit too much time wondering why things aren't working only to > find this :( My apologies, I'll try to put the changelog somewhere prominent, or notify you when I do something that I think breaks you. Yes, this is a by-product of a discussion with regards to the page_pool benchmark regressions due to adding devmem. There is some background on why this was added and the impact on the bench_page_pool_simple tests in the cover letter. For you, I imagine you want to change this to something like: #if defined(CONFIG_PAGE_POOL) #if defined(CONFIG_DMA_SHARED_BUFFER) || defined(CONFIG_IOURING) or something like that, right? Not sure if this is something I should do here or if something more appropriate to be in the patches you apply on top. I additionally think you may also need to run the page_pool_benchmark_simple tests like I do in the cover letter to see if you're affecting those. -- Thanks, Mina