From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673EDC6377A for ; Wed, 21 Jul 2021 22:04:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DAC260FF3 for ; Wed, 21 Jul 2021 22:04:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DAC260FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D7706B007B; Wed, 21 Jul 2021 18:04:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 487B86B007D; Wed, 21 Jul 2021 18:04:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 376506B007E; Wed, 21 Jul 2021 18:04:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 1B6526B007B for ; Wed, 21 Jul 2021 18:04:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C30A518488923 for ; Wed, 21 Jul 2021 22:04:09 +0000 (UTC) X-FDA: 78387973818.17.246D327 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf25.hostedemail.com (Postfix) with ESMTP id 7FF10B058BE8 for ; Wed, 21 Jul 2021 22:04:09 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id gb6so5471726ejc.5 for ; Wed, 21 Jul 2021 15:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nX5aqOHY9HgaYebkuFtX4Rr9OCAl7jIPuc9xY87G2ms=; b=i8jZLH7QWGH392+y6KKCsDXWau5mWKnuU5S2rFJptlP3f2uiYpDZach9xzawO5no+z BE7w5ih0UKHzsNQsvzxorhf6GyjSfcDz1Ivn4BbzD9HK18JbL5wA2VCrYuE7cFPy6FY/ JtEsGmSABTrZosYpH2ek9J+Fw2DkR8578PgmYzxVuvj5zrhjbKUo33qf+WYA78sGO/hq efK4B2WYgckHT1QNDHhfiCBQjKCgrhu1O8mvpoxyjUXnKNcK0HqGQWl430pPU82fKT2z Y3Zf6BoFKYCvaFj050inSFGLmhYeXsUbSHic2UweI6LwZBSieqt4RLC2bTSOv9/fQQEL QBWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nX5aqOHY9HgaYebkuFtX4Rr9OCAl7jIPuc9xY87G2ms=; b=nrPVAY/R8TN0vYurc3t+zpRY2xq5MeYw3BZu5UIiLS5cgZAxE3ZCOLa2/suXRJeU0d t8hwV+GvVp6rg1LuZt9G+HtcY1XFh10KvFkpU9DUCw2QK+5wqEIubgDCggyFaFvjfJYI MmT0YpzZa5X5dbrQFSzzpv25H4GqIJ42y4SgP3jiTFZYSo/gtJymlHV1yyVPbtd98Iko Ev1aMtBirC+gQLZX3YAzi5lHRNOL8GOguZ9qG/ISslpBZcNdKacTTXacDrMykz+yCMBF mC4Ykt5C2W7gwrTcF5CkD8CdeEBG9HeAfl4l9mOV1qD4CkJdhK03Pf0p1Oj/TADfo3nl V8Mg== X-Gm-Message-State: AOAM530fXZslr1MFDlwWOvvuMCdF3n2T/IE+Pi5mO7c2QxtLPzbHH3g+ ugC8yjP8ImNU0g0daX8g39nL67hX4qNUG8XcWb8= X-Google-Smtp-Source: ABdhPJyiuD5aAfpuE/L9yRsGvic6uzV/QC+cEizXXgEKW/OiEhhpdW3X7cgmWFigm6hlZd/49aS8uKtMpPoxKJRU9fE= X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr16091424ejr.499.1626905047927; Wed, 21 Jul 2021 15:04:07 -0700 (PDT) MIME-Version: 1.0 References: <20210721063926.3024591-1-ying.huang@intel.com> <20210721063926.3024591-8-ying.huang@intel.com> <43A1CB83-6127-427F-94AF-40CE1B283BE1@nvidia.com> <59a92898-4a8a-05d3-5f75-1f8defb6feda@intel.com> In-Reply-To: <59a92898-4a8a-05d3-5f75-1f8defb6feda@intel.com> From: Yang Shi Date: Wed, 21 Jul 2021 15:03:56 -0700 Message-ID: Subject: Re: [PATCH -V11 8/9] mm/vmscan: never demote for memcg reclaim To: Dave Hansen Cc: Zi Yan , Huang Ying , Andrew Morton , Linux MM , Linux Kernel Mailing List , Dave Hansen , Yang Shi , Michal Hocko , Wei Xu , Oscar Salvador , David Rientjes , Dan Williams , David Hildenbrand , Greg Thelen , Keith Busch Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=i8jZLH7Q; spf=pass (imf25.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: y7qmiw6k8notgdrxhhifzt1bqd8uq1ck X-Rspamd-Queue-Id: 7FF10B058BE8 X-HE-Tag: 1626905049-749413 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 21, 2021 at 2:58 PM Dave Hansen wrote: > > On 7/21/21 2:38 PM, Zi Yan wrote: > > On 21 Jul 2021, at 2:39, Huang Ying wrote: > >> From: Dave Hansen > >> > >> Global reclaim aims to reduce the amount of memory used on a > >> given node or set of nodes. Migrating pages to another node > >> serves this purpose. > >> > >> memcg reclaim is different. Its goal is to reduce the total > >> memory consumption of the entire memcg, across all nodes. > >> Migration does not assist memcg reclaim because it just moves > >> page contents between nodes rather than actually reducing memory > >> consumption. > ... > > Should this be folded into Patch 4 when can_demote() is > > introduced? > > I guess it could be. But, it's logically separate since it has its > own justification which is rather discrete. > > I think it's best to keep it separate. Yes, I agree.