From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71AEEC072A2 for ; Wed, 15 Nov 2023 22:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4A3A280006; Wed, 15 Nov 2023 17:45:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD311280001; Wed, 15 Nov 2023 17:45:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4DC7280006; Wed, 15 Nov 2023 17:45:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE958280001 for ; Wed, 15 Nov 2023 17:45:57 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7BDBA160B2A for ; Wed, 15 Nov 2023 22:45:57 +0000 (UTC) X-FDA: 81461672754.25.2769E39 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf09.hostedemail.com (Postfix) with ESMTP id ACC31140015 for ; Wed, 15 Nov 2023 22:45:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q7Iz1WzF; spf=pass (imf09.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700088355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7nJjkgwnquHHuOaLHOOrng4yzhJOgtCK4+wbNH+tNy8=; b=MY+1UvzK8gmGPDbZkkQSrgQYJ7gMigHlBAenR5tSEDYQoB99CNvVfbLnaSxSSe4r2R1EEE So04Bo/qcne2K7hvbwkYArz8gUMlFi90MfkmDYDysOwTA4khupXbbI4/YC8OidkAWeiRmB 3s9JLCDi1rCiTlz7A59cbyM+gAHyIWM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700088355; a=rsa-sha256; cv=none; b=lAUHxNIvrxFI+iYdYFfm+LEKu4p/CVrKN8E65zdMhBEx/vrBqBCV2TQ3nbzYN0I2Rkweyd 8NEXAidULYHTqYdDx4C4BKzPFAju7i6rHx3OtuUGEkW7RChqIb1LaU6KH/AmA5u6IFMZ9h CZ3gQ9da7BwnQLTi9+IB9z/p+Zvofhs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q7Iz1WzF; spf=pass (imf09.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5bdfbd69bd5so1048321a12.1 for ; Wed, 15 Nov 2023 14:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700088354; x=1700693154; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7nJjkgwnquHHuOaLHOOrng4yzhJOgtCK4+wbNH+tNy8=; b=Q7Iz1WzF3OfNw6gy0FQ6cL0sTWdIsBTwIJu2yo0BjgZ9XSutW4sUDyrjBBlh5ezAHn /6yRs0/Tic1J39WGDWhwVyKBQW3bSGg5ApECvC+w1mA4Kscyspbw/2qHjbjG891I4HfS b2Xe6/7n1xvrx3Yfd/hRVpWPARhj3EPU2+wfO3lJF392Q83k3rTK2soPtoaevG8yJJSX PX1qMnRH9jL/qLRLy1MVBPOCyaSieuLQDCxvL6F5XGFY+p0ynY+0Wzm31bEiK25NZjxR 9DjjAoHnKrah7/5Jc6itGHClpIyAFGb464zTjkgorn1c7NH3CIBkO20/OqrH++g/ueTI rqmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700088354; x=1700693154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nJjkgwnquHHuOaLHOOrng4yzhJOgtCK4+wbNH+tNy8=; b=h5R+/Vte6GSlQkLN6kSvJz9U/+s4iTF7GBFZjngWFnHU1yc+kryYUXWqbA/ArtmauX sRS6hQLDJtXDop23w04NwV8R6y58Yq660Sf/UGFhbJvg5TMzulHY/H0mVYZ0HbUzyTM+ 6NdMelssObQxJ911vBjpZCaOx/zjDI/IMb8y+C5hSAiMxe5FLenrcYRZ2oGP8mtI69P1 DXzd4yY1O2JgI26w4mg0+Lgp8d4OW8Tv8LyE3lRlJCfUZojoSNLrL5H//F6Z+22ZjYRz tsLEGnKD5iHQHxTIKuSFT+H/UQDyieebGUjlveBWSFgY+z9eGb7D2SVbOx5C+5XNfZdS XLmg== X-Gm-Message-State: AOJu0YwauxVbfseijTPQhC0ezJdP/mjS6VFNyNM4XZ+X7bDTh11mM3g6 kpKR2G1u5iBlK8dz9hzRBak8saB4iGxcONYwH48= X-Google-Smtp-Source: AGHT+IFWJLMP35QdB/HcbXYKW5MUQcrpjrSbORoDJin7bLHVuHfxxHIuONYZtUmWSljUE66jKlaFV8nIZgBGIwSTQb8= X-Received: by 2002:a17:90b:1056:b0:280:8e7d:5701 with SMTP id gq22-20020a17090b105600b002808e7d5701mr9875600pjb.2.1700088354411; Wed, 15 Nov 2023 14:45:54 -0800 (PST) MIME-Version: 1.0 References: <20231114014313.67232-1-v-songbaohua@oppo.com> In-Reply-To: From: Yang Shi Date: Wed, 15 Nov 2023 14:45:42 -0800 Message-ID: Subject: Re: [RFC V3 PATCH] arm64: mm: swap: save and restore mte tags for large folios To: Barry Song <21cnbao@gmail.com> Cc: David Hildenbrand , steven.price@arm.com, akpm@linux-foundation.org, ryan.roberts@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, v-songbaohua@oppo.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: ACC31140015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xpd1ep3cqhbud89pb7w7mq6gazmpsn31 X-HE-Tag: 1700088355-50780 X-HE-Meta: U2FsdGVkX18ZSSFxbo3K+xHnHO7p8WuMQHftV52itPOfF6ZRvmNq6jgept9lIXT8000+gMuqwEeaFRQ608hpBbrpCh3xLBFWpHKRjtwAAXDOPt2ln1z6CvfsKJezwHXV4JG6eHdYTLac0NYxxRWjJ0VC5YW1nOBbmIkffzWAGGsFim9MySGbGtSA920mMQvnvA60QprfFhlELzW9A8BpUx5Rm9Z//3fVwr+EFw77kAQVsiC/LR+3syFsznNAWinar1evHp2ukpKkrQSas2S78I0GrQhv6ID93zYjgML1Sk/5Mj3viYGATegL/C3hkGTAWw2lVKS3xrGuwFwnco1GtJF8zfEZqEaTkqs+pX1yWLhjWhHagZ8ysnuQ9lRbFUbgoa4Ytpf/Rw5mjTQJRDnx45NnmRNVJcSTmfDRIMhSv2JmVN54XXwyo1eACnPt19n/ASm9dmvR/LcUPqsYExNq8rWKVmcQyX4QRls57Lf4SM/ci3dUe+JkgQjS78nBemYKWzuc+LOC9Ug0cR1CzDiimiIoC+hhNfjoEKYKhYMmEq9m8kezmCjbTrciqU0ywGMi7SadwO2dtYty6FBt6izgzYZlKJYQXQ1Kz9JvY7vrPc9nC6v8JFdWbhTrcqlx3xOC9vNMzyZFYRpr9Tt87jNwLj/wJ/PhFp+cw0PLhK8KAcoLyR2XROXNpqaiyYRzZHok4lD4+IapLEXyNO7xAAR8lwdzvSW5QnVT7bxvU3xJODTWTReyPutlBwZfAtwozQRcQAt3uSpyfHMSl7kP/iSHEffp0UsRsGM52P3OdbLp/pa+Sux52xjcsoy6hnxz/73spOBfyaFyXaDuHj0P+uXe8SIQ/A+Ch/cQl5hg2rH022odjAN8Pomxb85GL7saIdK6KBMp66gNq0IElK1hklYbEdAAgH3EzA3N9F15A4xxNqOVmThb/+Hglw30FtnngV1zo80JqYJo+qo7M04+Y7v 9nStDULr 39eJ/aLwrQUqj/VLZu3I5DtiK7SMcYOu4gbo2TIAmvO6lL82PcAEJCMJ0TfFvg2RVNpyV88ggmgP8luJNen+8VKtnVe0CUBfIh1Vfdzl4ogpyxdwPjYNt4sn0pwg7hbvy/yF68TTI0GUkNeGjl1m/Wtl31LHTUcz82S1PU2zUOnGodiSTUuJMDjR/0hp1CjApZJGezDRetsmCQhHosXsMqZvUl7MLJ9dL4pICGYSk769ud1h4Il1pwABwOF3PRyR7Z/0IrQ9RLIPCGwP3HqDmZYmxhMkBqXBCTswMiczVF/gnpjZa8xVMMSEOP6ymKIhsa5V0XmxZ0iQZujfRKxF4qVQ7ycHiPoeyZl7Ft/P24zFRF1y0wGNyBj/rsvZb8Nm9yfzczBZU5h8jsTiAjYpDp95fHif13r2Z3d+5dGOjDm8aXYtmSEYumheIfcTNS4GOZmjtXUjhJRc+Swo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 15, 2023 at 12:49=E2=80=AFPM Barry Song <21cnbao@gmail.com> wro= te: > > On Wed, Nov 15, 2023 at 11:16=E2=80=AFPM David Hildenbrand wrote: > > > > On 14.11.23 02:43, Barry Song wrote: > > > This patch makes MTE tags saving and restoring support large folios, > > > then we don't need to split them into base pages for swapping out > > > on ARM64 SoCs with MTE. > > > > > > arch_prepare_to_swap() should take folio rather than page as paramete= r > > > because we support THP swap-out as a whole. > > > > > > Meanwhile, arch_swap_restore() should use page parameter rather than > > > folio as swap-in always works at the granularity of base pages right > > > now. > > > > ... but then we always have order-0 folios and can pass a folio, or wha= t > > am I missing? > > Hi David, > you missed the discussion here: > > https://lore.kernel.org/lkml/CAGsJ_4yXjex8txgEGt7+WMKp4uDQTn-fR06ijv4Ac68= MkhjMDw@mail.gmail.com/ > https://lore.kernel.org/lkml/CAGsJ_4xmBAcApyK8NgVQeX_Znp5e8D4fbbhGguOkNzm= h1Veocg@mail.gmail.com/ > > > > > > > > > arch_thp_swp_supported() is dropped since ARM64 MTE was the only one > > > who needed it. > > > > Can we do that separately? > > i think it is ok. IMHO keeping it in this patch makes more sense. IIRC removing arch_thp_swp_supported() is just because this patch made swapping large folio with MTE more efficiently. > > > > > -- > > Cheers, > > > > David / dhildenb > > > > Thanks > Barry