From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C42BDC433EF for ; Thu, 18 Nov 2021 00:16:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6059761B72 for ; Thu, 18 Nov 2021 00:16:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6059761B72 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A08006B0072; Wed, 17 Nov 2021 19:15:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B87A6B0073; Wed, 17 Nov 2021 19:15:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87F406B0074; Wed, 17 Nov 2021 19:15:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 795A06B0072 for ; Wed, 17 Nov 2021 19:15:56 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 33E3A87CAB for ; Thu, 18 Nov 2021 00:15:46 +0000 (UTC) X-FDA: 78820132692.14.5504F0B Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf08.hostedemail.com (Postfix) with ESMTP id 825C130000AB for ; Thu, 18 Nov 2021 00:15:44 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id r11so18686800edd.9 for ; Wed, 17 Nov 2021 16:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PPzDrm8hw/ujJmiUKHH7CMVzIaJ4uv6KjA6rPPfDBlA=; b=MYjaC48HJMlTwAZ5qRLVZREpdOvi98kfTgr63YfwurOcOCrjl9nJYQY/icYELIUxrA JckcwZRrBPvvLA2osY4mkl4IFR21i3IrIi93OetLdhRQbXGnvSiOw0KBlPyPlGLcm62M EF+WyaDrV6hZhmnG5QRvaGd0Ez6fk8j7gaZrvhrKDlD8+q3sNaNBDklXm1S/qD2ZO9Zr ZXDEyEn4vI7w2sN/7X0GF6fZEHK9VXv0kxNv/4/F7efW5JAVBadzz1tbCr4uKZHiIjza jouvD+XsEWjw9sis7M/LW7FUAAxRuIlEozUxeVWxxGqQ8bvvV0SH9eCibsIX/M2z3Xvk Kz8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PPzDrm8hw/ujJmiUKHH7CMVzIaJ4uv6KjA6rPPfDBlA=; b=t8HRpUwqimKX/qTSYQDhBQJLvGuoxPcNksdNNsRYQ085wsNQMxn0DrnXWltn/6olnJ yStxcdLfh+eI7yNuD8TVPq2CDjaQz1FFzHmv577+UrsgvwtqGFEeOl7QnINa/G8MB2f7 IMAWvdOCaSm+7kfR8HpOWrlhzAtbushJ65r8qVa6klDG6yx6kQIO5o3/R9dF+7NTHM4X xUzfQTAJr41eP5x3BKr4fqWGS6e6+jMxACaKY/7hUMwBDd8DKFRK1M5JdbJSC7yyQKut xCao5bgc6llW5pfYpazABOSJAoq+9dXPTgq84m1QBnSH1eRgJoaIHAdGPVcG3kSmE/OL xlvQ== X-Gm-Message-State: AOAM530Kf/oxzu4oNLJbC29ga8Idpk3W91fm7qU+MRCcdtJa+4PF8+v+ Xd5Ud2wulhCx8t2lcaYssyKZzSOj6WTBKF1VPNo= X-Google-Smtp-Source: ABdhPJzX2jweD0mYj8O2e9J4t8sqUX9NjEWWi4n12PZ/vxHqcZkNTop10a1J0vwbn/VBUOa6nTaTtK26vO6eZr3EstY= X-Received: by 2002:a05:6402:2926:: with SMTP id ee38mr4415019edb.71.1637194544403; Wed, 17 Nov 2021 16:15:44 -0800 (PST) MIME-Version: 1.0 References: <20211116013522.140575-1-ying.huang@intel.com> <20211116013522.140575-2-ying.huang@intel.com> In-Reply-To: <20211116013522.140575-2-ying.huang@intel.com> From: Yang Shi Date: Wed, 17 Nov 2021 16:15:32 -0800 Message-ID: Subject: Re: [PATCH -V10 1/6] NUMA Balancing: add page promotion counter To: Huang Ying Cc: Peter Zijlstra , Mel Gorman , Linux MM , Linux Kernel Mailing List , Feng Tang , Andrew Morton , Michal Hocko , Rik van Riel , Dave Hansen , Zi Yan , Wei Xu , osalvador , Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 5ierxf4t6cymox3bd9ob4exsdum7xiof X-Rspamd-Queue-Id: 825C130000AB X-Rspamd-Server: rspam07 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MYjaC48H; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1637194544-398857 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 15, 2021 at 5:36 PM Huang Ying wrote: > > In a system with multiple memory types, e.g. DRAM and PMEM, the CPU > and DRAM in one socket will be put in one NUMA node as before, while > the PMEM will be put in another NUMA node as described in the > description of the commit c221c0b0308f ("device-dax: "Hotplug" > persistent memory for use like normal RAM"). So, the NUMA balancing > mechanism will identify all PMEM accesses as remote access and try to > promote the PMEM pages to DRAM. > > To distinguish the number of the inter-type promoted pages from that > of the inter-socket migrated pages. A new vmstat count is added. The > counter is per-node (count in the target node). So this can be used > to identify promotion imbalance among the NUMA nodes. Reviewed-by: Yang Shi > > Signed-off-by: "Huang, Ying" > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Peter Zijlstra > Cc: Dave Hansen > Cc: Yang Shi > Cc: Zi Yan > Cc: Wei Xu > Cc: osalvador > Cc: Shakeel Butt > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > --- > include/linux/mmzone.h | 3 +++ > include/linux/node.h | 5 +++++ > mm/migrate.c | 13 ++++++++++--- > mm/vmstat.c | 3 +++ > 4 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 58e744b78c2c..eda6d2f09d77 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -210,6 +210,9 @@ enum node_stat_item { > NR_PAGETABLE, /* used for pagetables */ > #ifdef CONFIG_SWAP > NR_SWAPCACHE, > +#endif > +#ifdef CONFIG_NUMA_BALANCING > + PGPROMOTE_SUCCESS, /* promote successfully */ > #endif > NR_VM_NODE_STAT_ITEMS > }; > diff --git a/include/linux/node.h b/include/linux/node.h > index bb21fd631b16..81bbf1c0afd3 100644 > --- a/include/linux/node.h > +++ b/include/linux/node.h > @@ -181,4 +181,9 @@ static inline void register_hugetlbfs_with_node(node_registration_func_t reg, > > #define to_node(device) container_of(device, struct node, dev) > > +static inline bool node_is_toptier(int node) > +{ > + return node_state(node, N_CPU); > +} > + > #endif /* _LINUX_NODE_H_ */ > diff --git a/mm/migrate.c b/mm/migrate.c > index cf25b00f03c8..b7c27abb0e5c 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2141,6 +2141,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > pg_data_t *pgdat = NODE_DATA(node); > int isolated; > int nr_remaining; > + int nr_succeeded; > LIST_HEAD(migratepages); > new_page_t *new; > bool compound; > @@ -2179,7 +2180,8 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > > list_add(&page->lru, &migratepages); > nr_remaining = migrate_pages(&migratepages, *new, NULL, node, > - MIGRATE_ASYNC, MR_NUMA_MISPLACED, NULL); > + MIGRATE_ASYNC, MR_NUMA_MISPLACED, > + &nr_succeeded); > if (nr_remaining) { > if (!list_empty(&migratepages)) { > list_del(&page->lru); > @@ -2188,8 +2190,13 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > putback_lru_page(page); > } > isolated = 0; > - } else > - count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_pages); > + } > + if (nr_succeeded) { > + count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); > + if (!node_is_toptier(page_to_nid(page)) && node_is_toptier(node)) > + mod_node_page_state(NODE_DATA(node), PGPROMOTE_SUCCESS, > + nr_succeeded); > + } > BUG_ON(!list_empty(&migratepages)); > return isolated; > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index d701c335628c..53a6e92b1efb 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1242,6 +1242,9 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_SWAP > "nr_swapcached", > #endif > +#ifdef CONFIG_NUMA_BALANCING > + "pgpromote_success", > +#endif > > /* enum writeback_stat_item counters */ > "nr_dirty_threshold", > -- > 2.30.2 >