From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4714C2BD09 for ; Fri, 28 Jun 2024 18:27:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510426B0083; Fri, 28 Jun 2024 14:27:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BD056B0085; Fri, 28 Jun 2024 14:27:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AB646B0088; Fri, 28 Jun 2024 14:27:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1BEE96B0083 for ; Fri, 28 Jun 2024 14:27:33 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B649C8084E for ; Fri, 28 Jun 2024 18:27:32 +0000 (UTC) X-FDA: 82281130344.18.28659D1 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf12.hostedemail.com (Postfix) with ESMTP id D999740017 for ; Fri, 28 Jun 2024 18:27:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TvPtAvyn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719599234; a=rsa-sha256; cv=none; b=VTf9Eo4RLoZr0wwN9WB/bPsqlGcFjD83vTB/lyIVPkTFiqkdszmVVUGzS5MmnqRGFTKM/r LieyCJaCLkEX0/NbPcCpRQxWuGOiTYkYLX/SgaZUsrMLJfPxMQxyg46oBKV1VUI3qzt/GO 4BUKCsY8oaSPxza1XPsFW9CHB9/Ga/4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TvPtAvyn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719599234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dgGUkmn1jPeeQuMXMcfk1hTstH8mcemeot+l8YFexZY=; b=BZls04UxjqI6cp7+A4dykVXekEebO355wOmXEx363IuW60JFQ746IrRONHGswbxfoFaIVr yllMlY7cEw1RtkwrtlshV/cf284iTpPLyUlWAX/+EU09/abTrgyb9Av/N8Pg0vu2aIXXs/ kfSBsZGqTQLCFyhZHzN3PyGFdtjaP/E= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2ec58040f39so8868291fa.2 for ; Fri, 28 Jun 2024 11:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719599248; x=1720204048; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dgGUkmn1jPeeQuMXMcfk1hTstH8mcemeot+l8YFexZY=; b=TvPtAvyn8exeY/1KfYEiUjn8rxDORjcnskr3y8TQvqPYO/mYHGe23mUNSpF7R+UPPG ww3b//9YzyQ/2peN6J5TCeBWddyIVQ5xir3Y73yjTQfSB93htcSEK9rVjer1bokwslmT gR/6egP4miReR4TXpH+U2qtuV794cDse7934hmouAXuViPaHtqWtEhN4/Uy4SG1h7OSW 234EVNsWG/kriOG3PWg/puMMq/PPWuT8h/s/taSSD5T0c/WQc9wjLN2qi152OQT88TPw WYQ3rlrz4xxk8A7GhQrZRKD/DBsUyxXbXLOWcAq23sEjar0zLwA+eEItWq19tNYM/0xR eKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719599248; x=1720204048; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dgGUkmn1jPeeQuMXMcfk1hTstH8mcemeot+l8YFexZY=; b=rGgl4SJgRJUCFl+QVpmSqoot4xyqngnVxt1Skb7wPA5bSU+wxiKtDidYJadOKa5BSM GoRia6vV4jC7qPZyfNgNdURIKMaZEGlM07eVP1LkkFx2z4m8xHx5XShearWTNTSrjPeE 3/Np9tTeXQMDHy1eq3777NwSE3J8kBvYlWBuPF0TqdL4hTShlrECzpyg8bqRViwOZBh0 Qw9f+o39LwFCRw65cU0MXEb6p+qK4wNgpQ8XNhtJF0XIf9gdWwsWmj8v0d1CkTcTQvuo xdlHJd7wXc0uPCWRQFy9xIFZVXWPfto2P/eW8z+/BNiDhA1d83InSwvfhYIe3LiWadm5 3JlA== X-Forwarded-Encrypted: i=1; AJvYcCVp5xkPCqXEbGAiCC9oAf/CB/2ZWGN0yTq7zloRoEmcMZ3Gm/yOUz6l7tdg6GviO+KUTx07rnH+pnijHo0kWX52uks= X-Gm-Message-State: AOJu0YyPrJ0lRoencPfEr18cwVWYo2xYTJgsg/mmx/U6TWPBhqEQFrpW 5Odrtb6HD3Jr1DGU892VCSrTZyJo93JFMrssM2xbqpC534F2spcgWuHCwYvIzvLZRTy/pZqlErm 3upJRlXiimNgjvMX/0CkN9RFTewQ= X-Google-Smtp-Source: AGHT+IHS2YMlbAwnhePYHqSgke0BKfxRk6YNzoY3zHWvbGGz8ba49/3S2DgaqWbp8u3oQrZOZoMWNMsUfdQVPv11hRU= X-Received: by 2002:a2e:87d3:0:b0:2ec:500c:b2e0 with SMTP id 38308e7fff4ca-2ec593e0cc0mr112746701fa.22.1719599247749; Fri, 28 Jun 2024 11:27:27 -0700 (PDT) MIME-Version: 1.0 References: <20240627221413.671680-1-yang@os.amperecomputing.com> In-Reply-To: From: Yang Shi Date: Fri, 28 Jun 2024 11:27:15 -0700 Message-ID: Subject: Re: [v2 PATCH] mm: gup: do not call try_grab_folio() in slow path To: Christoph Hellwig Cc: Yang Shi , peterx@redhat.com, yangge1116@126.com, david@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D999740017 X-Stat-Signature: orti5twrbmrdekat38i8z9e5a1yb7gup X-Rspam-User: X-HE-Tag: 1719599249-560291 X-HE-Meta: U2FsdGVkX19ExucOU/CNDQ6WDVGaAOLT/pJ4OztraQxrqOZn1hdsQbqR84abrr8dDPqYUHmRH8Bl5hU9Kf3nADu0nP5XT/4SwZVYRMw5rCSN3Xl21BvC2e7tzM9Gqn/pPWhBbFWmu7oeR0oF4j0I5RdL7VzQY7euE2WEdXwa8J+NBkOrypuK/G1+iKoqZxpS2aMDqzmVi7XHmAmzqkr+EXx1/6Nh2mIgu+Tw8L0mGsY4cGkcrdUw6QPhacxP2FMAIughiw0U/4ksYyVV3D99mBNH1zqmXM0UmgOAeoEQef86bAYhJ+GpMcALhSAoeEOQnb38uIMU+uYEnwZSIzk5TU/U5Su/IMTNQeRdI2w88s4cWGZbTH0vAvNZWrCFKRWnrmSvp7RPH5cvdndODa5sY8tT64x1mJP1hG3raYMTpuqyRjlPP0518Yv6WexohY8lbglsAQCupzb0kYjLuO9LidJAvlSARKbXA5dPFSG+52S6HhM7JZGb7tllK9ldJF5GYbUOEr6V+EzGVgDNiN8ac5WoG7X+v3ik7fJFmQi3Z066iUw8TLAZXcScTKmBJopw+KTkIqLmWMeCNeidTNaYU3naNs3uU6IFgV2hmkz4K4xw6nCsvHVdFCQ/SI84TvrG9U1Z5PZJwCtQH4QRNXdIHHOdBiXrqrfErhqZ5ngfZjGYsb2wlg5kbPgSk02oWzfob8NTJJolBMghL5O4bVBHs1nrlqoLLwzq/RGVfyhpdoAhnhunPNw2yAbvXPpFauTyf6Rd9dhuVPwERxxg91IXyqfBnt05gXiXPvZ/xkPiXAZF94OdH0GuzH7A0kKtVaNrXklNot0CId9vrLEgAHI1xq44ukmBnaCWlgbc89XE8lEXn7yX2G75SO/F/p9xVTQaVK1izqTQfqHqdXsh9C8n3N5/wLFrPI4ieR2HZGDfxpWDFUhdNINsp1m0vKKVrlErBrAas6iOAszkO4fOOh7 mbVZUKrq KcRYKrDDsYVaQ6wMYk2ZCKgyfn8OM5HQO4DWut0suo+247eekY4J7oGLQ2+DPThKlrzMzSyNgVqYX4SREv3P1PMK8aKZpD/GFaIum7Vqj90g4YO/wjucFT0/8WM5W9SCrULZ6cuO9fLn2AM7ERRygNsSvyjKXvTCSnmPWdNjzc1GoVaT7KXCfRjmT2TEGkTTRshP4wJN8L9qyT6xWs1XxcID2bLv2/aTb4a0Za5ls+mNhx847Ttm7cxQ4BZ+vUPDEN5RWVk93BAE3S7gXwvdgDLKnwK4C0vAiKrJ4UZ9JfVuVb0rfqZ/xvew1xUa1jNjwjAWMVTDgKk101WctHZAjleoOvsWPNrgfxC2HpCIcNNP0edhgUfirv7R3fStqwmE26jUEbpz99cPnQo3cCMQYkLl/QA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 11:35=E2=80=AFPM Christoph Hellwig wrote: > > > +int __must_check try_grab_folio(struct folio *folio, int refs, unsigne= d int flags) > > Overly long line (same for the external declaration) > > > + struct page *page =3D &folio->page; > > Page is only used for is_pci_p2pdma_page and is_zero_page, and for > the latter a is_zero_folio already exist. Maybe remove the local > variable, use is_zero_folio and just open code the dereference in the > is_pci_p2pdma_page call? Thanks, Christoph. Good point, I think we can use is_zero_folio and open coeded it in is_pci_p2pdma_page. And all the format problems will be solved in v3. > > > + ret =3D gup_hugepte(vma, ptep, sz, addr, end, flags, page= s, nr, fast); > > Overly lone line. > > > + folio_ref_add(folio, > > + refs * (GUP_PIN_COUNTING_BIAS - 1)); > > Nit: this easily fits onto a single line. > > > if (gup_hugepd(NULL, __hugepd(pmd_val(pmd)), addr= , > > - PMD_SHIFT, next, flags, pages, nr)= !=3D 1) > > + PMD_SHIFT, next, flags, pages, nr,= true) !=3D 1) > > Overly long lin (same in the similar calls below) > >