From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D5FC433EF for ; Mon, 27 Sep 2021 16:51:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B54060F58 for ; Mon, 27 Sep 2021 16:51:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B54060F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0B5936B006C; Mon, 27 Sep 2021 12:51:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0155B6B0071; Mon, 27 Sep 2021 12:51:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD247900002; Mon, 27 Sep 2021 12:51:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id C72666B006C for ; Mon, 27 Sep 2021 12:51:21 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 83C8925F43 for ; Mon, 27 Sep 2021 16:51:21 +0000 (UTC) X-FDA: 78633943962.32.7FADB34 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf23.hostedemail.com (Postfix) with ESMTP id 1D9D090000AD for ; Mon, 27 Sep 2021 16:51:20 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id dj4so72051265edb.5 for ; Mon, 27 Sep 2021 09:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GqnGVlOWWoCRs+MztdprLg+2bam6PwLqfCjC4dqsjTg=; b=XzN+yJ4nsOlXhukqXwuke6l972D9pHEjn8/qhZkDViqN8f5iEm/dSO4yvstar7/zzH hFTpPMA+C3o2yZJGHgnATrlYFNnADUOQqOTVClgkVA8e6dQdh4HsKcwqmkR4CjUdMjeV 6hVqBYRV3cj1uW3CC051k97JwGgyR9T7BQt61dEQg5gIwS/pTg2vKxOjXvKUVQ0D8pw1 5go4UWeQIri+ZQQCObKzqDiLWbuoLMlpj/LC25+l6JIhCX0Y1Vr0uFtQvCuMabq1XZWB 9MvOtipYYmZCWFcNLUIzEJC/8/KEjgbw5L3dVMP7FzmrY47QgOICRl3lOQwxUuBoG1gI 0uzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GqnGVlOWWoCRs+MztdprLg+2bam6PwLqfCjC4dqsjTg=; b=HCBdfpbw7oRczuXDnCJcTeyLEcDjXE4Bw0toDTp9eBzsWqJ0EhfIX4GVeFUrR7OL/n kWl+vVThi1nmiLnECrOe6ZcJTwdh3ONnlizTCOFEILYsMMBU/sqxFc4OcSCOQHNSSqzw mTfMaLvwhxZR3h0V+W1kKSRv77VLYsvd6zffzkdK1i571+2YaJ7gjFsDcMgiuLs0jsUL qxBe4OpnVa5RuSGalhOCJkDUehzgzgJpuRaMkIqpGtdvmTo4JCe7WLe7JzoW307gmC/2 Qq1y9vXYeG/Ur2MYTw61/ykaBzHOLB3mH+6zXtUFPcjVNiSg7CPkyfxQjfNJnK9/8rHd 0lWQ== X-Gm-Message-State: AOAM531W/H72flN/OTUVNhSpeg7+0FC/BuP/UOwofXSL03B1O1oniMOR g3dEannYI075Qja+eSQ8+KQEThWBs8d0MMLwNPw= X-Google-Smtp-Source: ABdhPJyxRDSVMXC96QqUsrRGo92OZcyTydl/griYsuQKaO07BcgSDmqOifKe2SGCqhzFlzi4P7jwNFbx4oYCm59uCtg= X-Received: by 2002:a17:906:3854:: with SMTP id w20mr1057775ejc.537.1632761479812; Mon, 27 Sep 2021 09:51:19 -0700 (PDT) MIME-Version: 1.0 References: <20210924181218.21165-1-songkai01@inspur.com> In-Reply-To: <20210924181218.21165-1-songkai01@inspur.com> From: Yang Shi Date: Mon, 27 Sep 2021 09:51:03 -0700 Message-ID: Subject: Re: [PATCH] mm/vmscan.c:Fix -Wunused-but-set-variable warning To: Kai Song Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1D9D090000AD X-Stat-Signature: mtqua714m78yo648d1duo16xwsgxfkq4 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XzN+yJ4n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1632761480-354294 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 26, 2021 at 1:36 AM Kai Song wrote: > > We fix the following warning when building kernel with W=1: > mm/vmscan.c:1362:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Kai Song Reviewed-by: Yang Shi > --- > mm/vmscan.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f8b43f131673..7cf702bc1959 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1359,7 +1359,6 @@ static unsigned int demote_page_list(struct list_head *demote_pages, > { > int target_nid = next_demotion_node(pgdat->node_id); > unsigned int nr_succeeded; > - int err; > > if (list_empty(demote_pages)) > return 0; > @@ -1368,7 +1367,7 @@ static unsigned int demote_page_list(struct list_head *demote_pages, > return 0; > > /* Demotion ignores all cpuset and mempolicy settings */ > - err = migrate_pages(demote_pages, alloc_demote_page, NULL, > + migrate_pages(demote_pages, alloc_demote_page, NULL, > target_nid, MIGRATE_ASYNC, MR_DEMOTION, > &nr_succeeded); > > -- > 2.27.0 > >