From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B291C433F5 for ; Fri, 13 May 2022 02:40:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FF2B6B0073; Thu, 12 May 2022 22:40:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 988D36B0075; Thu, 12 May 2022 22:40:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8500A6B0078; Thu, 12 May 2022 22:40:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 71AEA6B0073 for ; Thu, 12 May 2022 22:40:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3EB2998B for ; Fri, 13 May 2022 02:40:27 +0000 (UTC) X-FDA: 79459166094.11.5313DBD Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf05.hostedemail.com (Postfix) with ESMTP id 9D0991000B1 for ; Fri, 13 May 2022 02:40:07 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id 31so6242546pgp.8 for ; Thu, 12 May 2022 19:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XtvUV6zT7Ei7z7xfN5FJ0eQzKGzKa5OtK6n50sHbFso=; b=Ijq56PSZuO2toBDYBakVHR7A8XQ1FMENZJSFqvWXq2XVvscaFxG7KG6sbh7RT5pPLp /kjxOq8oHxgU6xQvPzqF68WoHmt7bTpDVqBEl0jEuKPyor85Qe+TMUEjiBXi68nBet3y fGZbqUELrTsUVQ3UQ1KgqxGzUAbZzhLMirQ9m/X2AZHEiTTurD8U5hnSoWBshm2EAbew 63gXeq3wB2kzYfhpg/UKnKg8/ln8Jh3Vi+ndPzH1HIITCLSgeUWFbaePHuqsp3JJ3qXy 63JcyMI3kqEda3swGQLvFsmyXV7B4GZRRyP7lAzvXG2EdL0l3QpLKOlJ83chneqK8AtZ uXbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XtvUV6zT7Ei7z7xfN5FJ0eQzKGzKa5OtK6n50sHbFso=; b=ndaDNqwrIM7EV55D7v3rw9ZDZUQKMr8aTAe9SmLhisCscVqu6FJMzK/JdfEglypjXw 1Enw4IOLqY0PLxe5p3ZPYHgjKSKxf0Vp2lmQpaAabOlIkqRE6l59QCoJfFqlwfHz7PYw Tn4oetHuz3sqbzBUlWhhZY2lZgCVxhjd6gWjn4gL+HAvX+y9iVyxZI6QupMCPIt1Vd0X 8Phm1Gk/4x2/DPJGXeQRn5v9pmZ9lODFlrSEOfrpe6TOjqghIM2q++ssO3WYQmL8N+oO LNwEaA9XaV8SNKQN7NoaaZVAsyyn9aAmR4PHCIFbmOIDwRc7kN+EAIFejclzw79+tlZB fT+A== X-Gm-Message-State: AOAM533gxzi1zKA4jz8gn8Dnd/XZWD9WKsJeBjWMNsQqOnkiLvH3CUDb yRWkKpP3FvKPNSzYi+NkfE0Fg0QA72IjAs31yYE= X-Google-Smtp-Source: ABdhPJzIxxaqgu3vOLZoIjHVAIopPDnxRh5xRoBTBYgoUlcN5j+ZD7mWvkDYqaZ9RDmuQKKWuRi+wMi9x6dqixnZqt8= X-Received: by 2002:a63:1856:0:b0:3da:eae6:ca4f with SMTP id 22-20020a631856000000b003daeae6ca4fmr2056278pgy.587.1652409625866; Thu, 12 May 2022 19:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20220317065024.2635069-1-maobibo@loongson.cn> <3a441789-b3e4-236e-2e44-e7a1c7258a94@redhat.com> <20220512173620.2f5175c7a321e6ccea6e58e9@linux-foundation.org> <8c1fc6d4-7d3a-85dd-ebd9-fc8e221f1878@loongson.cn> <69c4f018-2012-8af5-569b-289d2a8a80f5@loongson.cn> <20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org> In-Reply-To: <20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org> From: Yang Shi Date: Thu, 12 May 2022 19:40:13 -0700 Message-ID: Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page To: Andrew Morton Cc: maobibo , Peter Xu , David Hildenbrand , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9D0991000B1 X-Stat-Signature: 5txo1m7hamugxthkfeziidtbwe95k7ra Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ijq56PSZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspam-User: X-HE-Tag: 1652409607-385673 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 12, 2022 at 6:49 PM Andrew Morton wrote: > > On Fri, 13 May 2022 09:29:07 +0800 maobibo wrote: > > > > > > > >> and/or changelogging. > > > Sorry for the late response, the mail is filtered and I did not notice that. The result is not so obvious after bandwidth is improved between nodes, it is only about 1% improvement for specint2006 for 32 core on my box. > > > > > > Now I do not see negative effective about this patch unless user wants to keep some cores separated from khugepaged daemon process. > > > > Can we provide an extra parameter to let khugepaged daemon scheduling binded to node or freely? If can, I will provide updated patch. > > It has always surprised me that we have a single khugepaged thread. If > we had a thread per node, you'd be all fixed up, yes? Actually I was thinking about this before, but I didn't see too much benefit with this approach TBH. The khugepaged scans vmas and the mapped pages may spread on all nodes. It is not like kswapd which could scan the LRUs for the specific node. > > Ditto ksmd. >