From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2DCC433DB for ; Wed, 10 Feb 2021 16:59:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8505C64E02 for ; Wed, 10 Feb 2021 16:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8505C64E02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 080706B0070; Wed, 10 Feb 2021 11:59:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 030776B0072; Wed, 10 Feb 2021 11:59:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3B036B0073; Wed, 10 Feb 2021 11:59:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id CED486B0070 for ; Wed, 10 Feb 2021 11:59:05 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 92EF0180AD83A for ; Wed, 10 Feb 2021 16:59:05 +0000 (UTC) X-FDA: 77802968250.29.fan51_6313f0027611 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 6824E180868CA for ; Wed, 10 Feb 2021 16:59:05 +0000 (UTC) X-HE-Tag: fan51_6313f0027611 X-Filterd-Recvd-Size: 3881 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 16:59:04 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id w2so5375287ejk.13 for ; Wed, 10 Feb 2021 08:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CZixN6Q/4ReK9YtVCNtVo5cDo+F6iIEK6tabVtfOzxo=; b=Rq7xCOotKS9ZpLJt7mztI4zaEi7hNGUIkviW+Rh0IHqkEftTg4Ao0h6MELWhz+xcle E/IQHaPwkqKKu+ymFzsU/pg7WI73tsddPelKXby+JVgt6OqjmwceDddIBPMHgon1b03Q qHTO7RokQtGa7vNbp0aeyyzJxbXVgnajTj15dyvyECpv90PceOJQfRNPbbmejRzarwzE Psq8DugOhJXTH2BgccoDMJFjNiNE6oGWSUvxiwUdz//D8rjrttPMQvRT0ymwXslFOuNW qXJ+2wwE0WtTjTh0mJlvxBF6dd9HZ1bftTrQAWLbAAzuKmFoqoQhJvUZDiApiThkQyK2 MexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CZixN6Q/4ReK9YtVCNtVo5cDo+F6iIEK6tabVtfOzxo=; b=nn2/ML+UmVpAczJkndCvhulTM4cn7OkR40HuDkn6Hsvs7gR6ASNt0WdXdWT4eTtGJ0 J4Atnop0EHI5cYH/vEH/mgiLbUn9hJnXmPol0UsgVYF6rWgwaF+MB8N3OZOaRWhj3RBY B/Rvn2YPfrXigNMqXFhdTd4Jh7jXObNZYt7iFZ6UXnFo1gG8ngrZtd8T5t1DpT5RY9ZC pmkh6JQ2l9hw45Zlv81Ut46kJfcfQWgb9IZJp07OTjqL+cLtyuPMk74cU8rZWl1cSCoI cBtSkn9oFf80dHEBVHEhphtoXf08l7ozgz93OZKhY8Ba5zmg5jhr7/KbSMna7C3/LlRc u4hA== X-Gm-Message-State: AOAM5311YPFxEc3IHVaLGDRKKWncOn/DVMgfZCaAxT7iXcBLEECN88Cr 4hQVUu7ZGfMH4U+3FkrJWcWft3nA89eTm8nE7SM= X-Google-Smtp-Source: ABdhPJyOUgWmInD4qVcgQuWqw8PD0zsXXPLcq6zX4rspY74T4IQSbdnnewUZt7QWQDAqh4rzLc+HPrDLiAWQqIA/5yM= X-Received: by 2002:a17:906:755:: with SMTP id z21mr3949721ejb.514.1612976343938; Wed, 10 Feb 2021 08:59:03 -0800 (PST) MIME-Version: 1.0 References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-2-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Wed, 10 Feb 2021 08:58:52 -0800 Message-ID: Subject: Re: [v7 PATCH 01/12] mm: vmscan: use nid from shrink_control for tracepoint To: Shakeel Butt Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 9, 2021 at 11:14 AM Shakeel Butt wrote: > > On Tue, Feb 9, 2021 at 9:47 AM Yang Shi wrote: > > > > The tracepoint's nid should show what node the shrink happens on, the start tracepoint > > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the > > shrinker is not NUMA aware, so the traceing > > tracing Fixed. Thanks. > > > log may show the shrink happens on one > > node but end up on the other node. It seems confusing. And the following patch > > will remove using nid directly in do_shrink_slab(), this patch also helps cleanup > > the code. > > > > Acked-by: Vlastimil Babka > > Acked-by: Kirill Tkhai > > Signed-off-by: Yang Shi > > Reviewed-by: Shakeel Butt