From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F90C4338F for ; Thu, 5 Aug 2021 17:42:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D74C161104 for ; Thu, 5 Aug 2021 17:42:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D74C161104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 44D2A6B006C; Thu, 5 Aug 2021 13:42:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FD416B0071; Thu, 5 Aug 2021 13:42:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EB2E8D0001; Thu, 5 Aug 2021 13:42:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 11EED6B006C for ; Thu, 5 Aug 2021 13:42:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AF8348249980 for ; Thu, 5 Aug 2021 17:42:31 +0000 (UTC) X-FDA: 78441746502.04.7A4056C Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf20.hostedemail.com (Postfix) with ESMTP id 744B1D0000B9 for ; Thu, 5 Aug 2021 17:42:31 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id go31so10899143ejc.6 for ; Thu, 05 Aug 2021 10:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0kwcq2vwgaqhWyej8Dvyil/ttiS5XKEcNi0TvEB5Tgc=; b=kp21L82WdyWCKPskjHwNLuKwoR7OjYhu+Uku9LXRiS4Gb+FFi6jLIFyr6Fnjpl1Ro/ d2+itDg/f6QOGZCtG4D0tcw2ZS9vdVl2+7VA7JLgSoT7dUG5SuhXArTpzKONFKm2WTOz P3y474xCNac2WQYs1IPvi032xsUwqhgt5nAy4ssa011XN/H6kc9ik5+VPsvNZozdmZwC sVGcHs8dENUbE1lXhhO0R5IjNfe4m1rVuuQmf/boWWukm83ZVTYeRVC6O4ZT4spzwE9i RXOpep6KvDNZYtmpOIOI3QxMbZfFi8I/h0ANTXR4auBOsXsci+iihbdsHYqDBEqh2zHG 0gJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kwcq2vwgaqhWyej8Dvyil/ttiS5XKEcNi0TvEB5Tgc=; b=FOfB3UjIPtA1KXcaLhiDb0wRy4vMlzng6W5lCy4bEa/uFdNysxfT20KHczwATaBoBd mOxbFDwAfXETM1P8FPsj/+WcMoxjY97NySiRRnLJ1tMThl4bGOurkO1X4ocbpuEJrJB4 2v6z3imeayrpeaPtSZ//XPU80rxYQ+WqFW1U87QmGHrfduZH+2X+NWiBvPrzBIrNJOwZ fEtuwXSZtdk6zss+oxvjW+S2RFPsZNeq/w8TAhG0qqBHjfMwN8VJKbQVjyDjWR3UO0dB q3w7TlLgrollCsEMORzhkKcMt8fgUlIjCGfCpSrE8JQXqktwPydhHZ0vq0rwKlt+io5/ rebA== X-Gm-Message-State: AOAM532bcXgF5CSniBa+rtuN+g9lS+vC7Oj009wlSG4BAg3NbiXEJJuF QsQQbfQYtGhE9LzWtdAvi5zkuqvvyr6nQ3/1KjQ= X-Google-Smtp-Source: ABdhPJxI/c74AwqjFKwul5SxdIi97MikBfUfUiOxUUUhcEOTSTNO4DJsQJ0op0B27fm4QQKtjZEgVcZTe6OX9tYe3Rs= X-Received: by 2002:a17:906:58d1:: with SMTP id e17mr3663543ejs.383.1628185350291; Thu, 05 Aug 2021 10:42:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Thu, 5 Aug 2021 10:42:18 -0700 Message-ID: Subject: Re: [PATCH 2/5] mm: migrate: Introduce a local variable to get the number of pages To: Baolin Wang Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 744B1D0000B9 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=kp21L82W; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: gdss13au9bhntf5uxugsemkp51h5p9k9 X-HE-Tag: 1628185351-234953 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 5, 2021 at 8:06 AM Baolin Wang wrote: > > Use thp_nr_pages() instead of compound_nr() to get the number of pages > for THP page, meanwhile introducing a local variable 'nr_pages' to > avoid getting the number of pages repeatedly. > > Signed-off-by: Baolin Wang Reviewed-by: Yang Shi > --- > mm/migrate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 5559571..eeba4c6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2106,6 +2106,7 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page, > static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) > { > int page_lru; > + int nr_pages = thp_nr_pages(page); > > VM_BUG_ON_PAGE(compound_order(page) && !PageTransHuge(page), page); > > @@ -2114,7 +2115,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) > return 0; > > /* Avoid migrating to a node that is nearly full */ > - if (!migrate_balanced_pgdat(pgdat, compound_nr(page))) > + if (!migrate_balanced_pgdat(pgdat, nr_pages)) > return 0; > > if (isolate_lru_page(page)) > @@ -2122,7 +2123,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) > > page_lru = page_is_file_lru(page); > mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_lru, > - thp_nr_pages(page)); > + nr_pages); > > /* > * Isolating the page has taken another reference, so the > -- > 1.8.3.1 > >