From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D28BC433E0 for ; Thu, 7 Jan 2021 17:30:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1D8322C9F for ; Thu, 7 Jan 2021 17:30:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1D8322C9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB3158D013D; Thu, 7 Jan 2021 12:30:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E89408D013A; Thu, 7 Jan 2021 12:30:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9F088D013D; Thu, 7 Jan 2021 12:30:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id C36B38D013A for ; Thu, 7 Jan 2021 12:30:11 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 94F04485C for ; Thu, 7 Jan 2021 17:30:11 +0000 (UTC) X-FDA: 77679667422.05.touch35_3e004ed274ec Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 74AD21801FA4F for ; Thu, 7 Jan 2021 17:30:11 +0000 (UTC) X-HE-Tag: touch35_3e004ed274ec X-Filterd-Recvd-Size: 4281 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 17:30:10 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id cw27so8525909edb.5 for ; Thu, 07 Jan 2021 09:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=axN4GaDeR+MEVgZRaEXZ0ZXIu1myM+jajV0ll7329Nc=; b=SdXQ5erLN+VPMwfnwaeY1r+OMQL6P7Q4W0zpfnGUfxiS1mifK8NmOQb7MdNFSETRxb mdDsYA79HeJMVjUPNKiTQv84ococrgAwemyevpeeiEKjMR6S+2fjXnVCfZpfx3FAp7f0 IZMn9m0haK8J/vmnXabBW12BPzu+NTQzipQHITG1TJ8INpNrhRtiUMrFTcfzID0m+SS1 Ks7gD89pqGVhbFPQtPJ8PwPvtm00jSZPQXGeipKKIkZ/O1vFM5bHBpsa5SaMLE2s98Zf QJbtOLMWP3Rl//GqySLYG38tYqyIpnDxDLsC8q2b7b2mrPFuTkjeKmR+cYT+XescK8R+ UZmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=axN4GaDeR+MEVgZRaEXZ0ZXIu1myM+jajV0ll7329Nc=; b=R4UX8wZ7ABlAEajgxi0r2NvKYEVS5yy6Jt+4B9vGlOGRqv6f1YNiXpizV+ZqKMxInH XSrWPjG4QDOzac6wi+zemBf9PnxybHaF2FWHz190G2chBUkNQ85gwQcIWidXuFhNo1OR 3NZvC7dlCRPmEpb9kjcCxXNHdntHbcvKZAPpgtyhY21RxXnqew7mVF2q64jTzgpzMtRv s621zh0c69uY5rPh+aBPLJ+3wydgurS+P8NlU8Ddggg1rqWAW8klmsexNO0hVH88eZ9y pSMD9Y2NcU6J+0ywAkprDudQyuxGs4T1Qf1ehQilDVp0xT7i7+cWU8oqYGw9CoqxyFef PEtw== X-Gm-Message-State: AOAM533X1LGMJaaEk/3GTWP6AGYOtR/3/STckXvhySzwuyrdeG8M+06p N3/fR3xdemTH5mxFaLbuu5yYHpXm56VLySZkG7o= X-Google-Smtp-Source: ABdhPJygpCklThqcXVk9N8gboz9hlyQL1rXmDc4Xa/4U+ytfmNsb/qt+nLY7mzm1lkA3K2vV65dW67esM3tOLGMyP70= X-Received: by 2002:a05:6402:1c8a:: with SMTP id cy10mr2430738edb.151.1610040609737; Thu, 07 Jan 2021 09:30:09 -0800 (PST) MIME-Version: 1.0 References: <20210105225817.1036378-1-shy828301@gmail.com> <20210105225817.1036378-3-shy828301@gmail.com> <20210107001351.GD1110904@carbon.dhcp.thefacebook.com> In-Reply-To: <20210107001351.GD1110904@carbon.dhcp.thefacebook.com> From: Yang Shi Date: Thu, 7 Jan 2021 09:29:55 -0800 Message-ID: Subject: Re: [v3 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code To: Roman Gushchin Cc: Kirill Tkhai , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 6, 2021 at 4:14 PM Roman Gushchin wrote: > > On Tue, Jan 05, 2021 at 02:58:08PM -0800, Yang Shi wrote: > > The shrinker map management is not really memcg specific, it's just allocation > > In the current form it doesn't look so, especially because each name > has a memcg_ prefix and each function takes a memcg argument. That statement from commit log might be ambiguous and confusing. "Not really memcg specific" doesn't mean it has nothing to do with memcg. It is the intersection between memcg and shrinker. So, I don't think of why it can't take a memcg argument. There are plenty of functions from vmscan.c that take memcg as argument. The direct reason for this consolidation is actually the following patch which uses shrinker_rwsem to protect shrinker_maps allocation. With this code consolidation we could keep the use of shrinker_rwsem in one single file. And it also makes some sense to have shrinker related code in vmscan.c, just like lruvec. > > It begs for some refactorings (Kirill suggested some) and renamings. I apologize that I can't remember what specific suggestions from Kirill you mean. Removing the "memcg_" prefix makes some sense to me, we don't have "memcg_" prefix for lruvec either. > > Thanks!