From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0D5C433E0 for ; Thu, 2 Jul 2020 18:23:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F0FC2084C for ; Thu, 2 Jul 2020 18:23:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VG0uLCzP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F0FC2084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21A188D002A; Thu, 2 Jul 2020 14:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F0E48D000C; Thu, 2 Jul 2020 14:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 107258D002A; Thu, 2 Jul 2020 14:23:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id EC93C8D000C for ; Thu, 2 Jul 2020 14:23:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B4D782C06 for ; Thu, 2 Jul 2020 18:23:18 +0000 (UTC) X-FDA: 76993958076.15.paint15_3f00b6926e8b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 65A571814B0CA for ; Thu, 2 Jul 2020 18:23:18 +0000 (UTC) X-HE-Tag: paint15_3f00b6926e8b X-Filterd-Recvd-Size: 4426 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Jul 2020 18:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593714197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N4n2qeDClQPShAlOepg3+xUXJF0gLP+gI9YS4+e3wWo=; b=VG0uLCzP6klptJMASdTb5lg8eSxXbyaUJba0E6CJGKywZAKndPM8RGA9IP0cmkuHyKd6pB C4zeUClWlblpweh51WsXmV6ft3DFl+shr7kG7h1rWgY/PKrngvKAujP+YDajN0m/iT7QR1 JTED7YB450EezijkMkP0HTw05yq0jqw= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-E32PIXTqPQyZ_GJFgNHjQw-1; Thu, 02 Jul 2020 14:23:15 -0400 X-MC-Unique: E32PIXTqPQyZ_GJFgNHjQw-1 Received: by mail-ot1-f71.google.com with SMTP id 10so9413322otp.20 for ; Thu, 02 Jul 2020 11:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N4n2qeDClQPShAlOepg3+xUXJF0gLP+gI9YS4+e3wWo=; b=MgqBt0fTr5x5nKR7RCIuWXR5FKIA+WH8yYblLsGmXZpUprIplX3fIJWP1YHuZd8xZX Y8F4hir4BvHBplh6zMUIAmcgrP1jIRNdOLCcKrOHEzfCXw9jS2JGoV9fZa4uQiSFVDfa KCJmAIyuxcZYC+MgstE0xpP741xlh8L681SItj0RD/Dv7C2MX9QLSm6lF647tim9oZWN fRQcNF2uAlrkSUDlxb1Lowb1x/J8trTa3XGzE/R289iZOpzWOsiQABV8wYlIh9oH4et6 WkFPRKQc/U7QDxki9+UD5kQ7XGdeSCqnpke0H4UTPxZwyUvyN8JWAfhPOddQzGA26Fud ohqg== X-Gm-Message-State: AOAM531BF1sk4FH7tS7HXrfyReismKPQT3ZDcqqIkG2dRINJxQ3fsHs9 YMQIwn2PznDX86l3xQZH0cPc37IY35N8XaQ8sABsOIsDXuLv/7vqU5LZxgxyDSGkkewFhUX8E5W CTj/tPHtpgT2tvo4ftH/njEFhViw= X-Received: by 2002:a9d:5f92:: with SMTP id g18mr12102136oti.95.1593714194841; Thu, 02 Jul 2020 11:23:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvm7EcRvsfCto8/PgbdopuIxxPcMOqqa27XvyoeidGOQ9Dab1I7ij1VwHb4T6hC4Paewj6S+oUpsnH5rz8W5I= X-Received: by 2002:a9d:5f92:: with SMTP id g18mr12102114oti.95.1593714194564; Thu, 02 Jul 2020 11:23:14 -0700 (PDT) MIME-Version: 1.0 References: <20200702165120.1469875-1-agruenba@redhat.com> In-Reply-To: From: Andreas Gruenbacher Date: Thu, 2 Jul 2020 20:23:03 +0200 Message-ID: Subject: Re: [RFC 0/4] Fix gfs2 readahead deadlocks To: Linus Torvalds Cc: Matthew Wilcox , Dave Chinner , linux-fsdevel , Linux-MM , Linux Kernel Mailing List Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=agruenba@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 65A571814B0CA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 2, 2020 at 8:11 PM Linus Torvalds wrote: > On Thu, Jul 2, 2020 at 9:51 AM Andreas Gruenbacher wrote: > > > > Of this patch queue, either only the first patch or all four patches can > > be applied to fix gfs2's current issues in 5.8. Please let me know what > > you think. > > I think the IOCB_NOIO flag looks fine (apart from the nit I pointed > out), and we could do that. Ok, that's a step forward. > However, is the "revert and reinstate" looks odd. Is the reinstate so > different from the original that it makes sense to do that way? > > Or was it done that way only to give the choice of just doing the revert? > > Because if so, I think I'd rather just see a "fix" rather than > "revert+reinstate". I only did the "revert and reinstate" so that the revert alone will give us a working gfs2 in 5.8. If there's agreement to add the IOCB_NOIO flag, then we can just fix gfs2 (basically https://lore.kernel.org/linux-fsdevel/20200619093916.1081129-3-agruenba@redhat.com/ with IOCB_CACHED renamed to IOCB_NOIO). Thanks, Andreas