From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30FE3C83F1A for ; Thu, 17 Jul 2025 18:36:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A03D98D0011; Thu, 17 Jul 2025 14:36:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98DC08D0006; Thu, 17 Jul 2025 14:36:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 854CA8D0011; Thu, 17 Jul 2025 14:36:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6BB788D0006 for ; Thu, 17 Jul 2025 14:36:06 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1F6B610B89A for ; Thu, 17 Jul 2025 18:36:06 +0000 (UTC) X-FDA: 83674611132.27.591447A Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf16.hostedemail.com (Postfix) with ESMTP id DBDE3180010 for ; Thu, 17 Jul 2025 18:36:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TA7tHxpO; dmarc=none; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752777364; a=rsa-sha256; cv=none; b=4ryLpDYVq1nDdMk+n7faDFjdQlcysXjh3WWrsqe//jphEGSYo9Euk2ivyaDlwTLDQXeFYA Us42hbSGg7cZ29L8udO/CBFX2CPSD5IEr/Pdma38AccAUdHQ+4aikkZlL3YDYE2XJAVWUP TRYmCEtr4NPo/MsTW8Zmla/3cjOPIjc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TA7tHxpO; dmarc=none; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752777364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aieKFP+WlFpL5D5yzi8pvP6vZRe7mbkNZOfzzhMJB0Y=; b=EdCYSeOzO8CNf1w8TcEdFuwY4NQPJc4LsRNa7Tg1nsFydLJYY3AKqbBE0KTULU1dCaPzmj v7lwJTL++06+QbFCaXbc/LFFlxPoM1WZisOGcTnDLpQSrjvXVPkvkHDumatUSYRji23fEY E1uCrGy6+yOYVq5gywExmltF+98xip4= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aec46b50f33so244226166b.3 for ; Thu, 17 Jul 2025 11:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1752777362; x=1753382162; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aieKFP+WlFpL5D5yzi8pvP6vZRe7mbkNZOfzzhMJB0Y=; b=TA7tHxpOjpN1MftY0c2XnN0yI0c2ECqjXW2omiEnFe3HPtxjcw2n+n5o+48U3PK24m zRufNTuqiYDtVrdbnL7ypFtIZnTPoaX/JOFicmxH+5uHJGgowaY/mT63bbIpB/SmP0yX DKCAUj6ZptUAs723bCn7Bdse0g8Qa9e1Z6MWI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752777362; x=1753382162; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aieKFP+WlFpL5D5yzi8pvP6vZRe7mbkNZOfzzhMJB0Y=; b=tBZqaK/3J9wT3aam5dxoB/ag96cdcKtuv/blCLKBerNNWIlOn9ssHO1ZzXM9hWjh0e STZ4avOkq3tt/Cm24yizq3GlaPVcLmRUpZ7hYgKrwgi/M0C3BkbHB5MnMOur7CS+RGdp doadg7QV39+sW8Djens0P0ENPpEKYWVeJSOOQg87H5m/6UgFR1296xY7bBViewnX26rv lWxz8TgpeN5aN6vmObK0Z3/dGJrsdeMhx0FOuF4Le/UZ8i1zM3rV22VgTpVcK0YeYDH3 F1oPDRV8ObMlV05xEhWKLdIUAYuSyAkZmPzlaiGGCo37VwvhJQ/McMHWVerwgyauf8m8 /zwQ== X-Forwarded-Encrypted: i=1; AJvYcCWxqxBN2zsrwteMPhqbm6ERw3Pblyqrgx6rJ/0nEFxHFbl3U0FDR1uXO55v41Ssj+duHHJ+IgaCWA==@kvack.org X-Gm-Message-State: AOJu0YzjEFFuA31ElUowhjxcI497/cgKO94lX49gX9k1hD2yqdXsHCiv NncXMC4463m2P45V8hDk6+z6JxcMR+tXOLJrp/G5P0C9G+6TjJqlRSu601+jXObYMyRPYXIRS+S TX5QRtBc= X-Gm-Gg: ASbGncua2GcxeTTVKX88antCSQRBjzByUcVTmRr/GFNgHDLLSEaZkpWZTo8rT+7ueDp 6qB3KNYwhC8obTH2TGb70KtpD+RZcSoBeZH4W59Za/6UeYIAmMOAbUdSTd1a23R8p5esWhL2twZ Mv7LPbObaXEhGdEXI72Dqk+YKVM0fkW8fLGFeaMHDCZ8XCMpU0kalqShWldGzVxiZNHtKrmN0xr /cY5llynSzjnrGgb5HwgkXa1BayPUd+RjTV3HXZp/xpLUqqBFIZujGVgKaPvUNaWGFD8HxTtHFj 7gb9bTrp/7JyB3209hZSE2tGJnNGdA8gefbHVC4mMhcVD6278GjpmKX+3u+PbXNe0VCk/bVGTTp Ta9ZZatm1fnVfixUO44C2b6fguOcvj2TPHYJDegrhgJujnE/l5423qsePRInBXHlSoZ1rHVGJ X-Google-Smtp-Source: AGHT+IGGA4Q14B8GIFeJ/J3wKOjDf/7B+tN/eWNTbY0P8JssaUwXPjt3lwjn3YktoZaoJAMRntkFQg== X-Received: by 2002:a17:907:d11:b0:aeb:fc49:3f56 with SMTP id a640c23a62f3a-aebfc49584cmr602868366b.15.1752777362091; Thu, 17 Jul 2025 11:36:02 -0700 (PDT) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e829629dsm1411861166b.138.2025.07.17.11.36.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 11:36:01 -0700 (PDT) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6070293103cso1901591a12.0 for ; Thu, 17 Jul 2025 11:36:01 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXgUHbpcYxSP0crPnW9lbHoLyxfPqPyhKHL6s1GhdSpS/flpzzxO9/We+yltGJstgbwrc18qXt2jw==@kvack.org X-Received: by 2002:a05:6402:34d6:b0:608:6754:ec67 with SMTP id 4fb4d7f45d1cf-61285bf3730mr7487110a12.30.1752777361408; Thu, 17 Jul 2025 11:36:01 -0700 (PDT) MIME-Version: 1.0 References: <20250716123916.511889-1-bhupesh@igalia.com> <20250716123916.511889-4-bhupesh@igalia.com> In-Reply-To: From: Linus Torvalds Date: Thu, 17 Jul 2025 11:35:45 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXw_kNIbTRokcm7T_S0XklVgvPSebW7F_Vtc8CMTkt7DzdcMPhb6rT3qzqo Message-ID: Subject: Re: [PATCH v5 3/3] treewide: Switch from tsk->comm to tsk->comm_str which is 64 bytes long To: Andrii Nakryiko Cc: Bhupesh Sharma , Bhupesh , akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-trace-kernel@vger.kernel.org, kees@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DBDE3180010 X-Stat-Signature: ou1xdsp1eoy9fsbn8cza8ixcqxx3s6gf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752777363-678223 X-HE-Meta: U2FsdGVkX1+WUs/XBpbqxr+bajrtVjknV04kE8Do1yvnMebyrL+shO4tqWYIAzIIq5C2vC91qt8ktBoWqsW/VDdqrZRAWByV8+NAN2MnxVmrXGX+Kt1HEhzuOlteTREClM4VeFTZoCjkfrq4GRc5WSDE4A0vLYbawdxsv40U0se9NuPXMEYhKVeTjwNd+/3UcpxASHjFH4V9xRHDcdJujrEgEt2dAjJionjXK6utfvwx4Q3dxuH615KQm0mjr6/D0BgOcboccT6vdK2AA/YIp7OU0j96kKwGNi+b0zF7x+UpgJv00+NDkCdCfQJuttkkOXcpzAckzrdy9wrOKxg2kT1XCUPDJGVyBHkxFTnx6A2nmmp06BotIx4hfBv9QGLGTRAUfXHPkK20Hv8Z1oMx4btLziRZpvnLdIMwrTlQgjYFfNqW3Re4m4lUgum+W3gnil1Tt9jBhxMEfNspp6R4xp4rg1sgrxNxMBOQLOCy3h7qPFrij4Oc+6aqXEoMYKdkpDP4zhBCnPQqf8EvXD7L88iamn2JbMik5ikYldaANZpHUaNdd0W0E//8xC2D/ANjacJitP7lDm1SBjFpyYwU8/MLKjSEK2GGLl9YLWzUJktyOcgKFK2wK2jAmAz22kdfegBJb8mr3kPLXMZRGPmRdU946alQGQoGp6agzHyqZAp19PwEwrgFC4KVn6aK/3rZBos9eqKQIGxmKy/xDS2pWL9saLJJq9MPqYw7Al0f0dBGrnsamU3GQO+os8i38TTbqRCQWH/LutMGQBIG16qkHSBIF50UJZFncL4/RbwXB/esgYYoZ5HZ+GGzc9f1IEHLiWHcWtTjY7y0GVKZW7mpYoiLTOIW7o8/Fs6Gn45E7QkRrUXvhq4nmuc5AAM7HaryHahwZjcZEl4NUTxKT7ZfJ1Vcub3N+cOHSDO1LOXYcdW4WgP6pv/hoP3ZHeNV6XqCAMOWL6vNrATnPFe69yd 4epfHHZ8 w51S4GzDKTKnwO7Mzpk157DxVTc4D6DlN43YKOlFLt82JKMhhrta8Lc/SDCD4mlSGUxwIqqcgd0O8jgTi50IgR0QjdzNLiP1ncp3jeJS0k5xi5itRK91k1Zdbbgret6v+vrIDJbhgQHp++eYCUEvJXq7SUDvYXh/jPfe3HRDXtAtsYRnY46jhFHW4/7ZRGpzaSSfqCjYwczBYNJBd+D9MQA1MYn2z6+nGDP3wWknh81MtZsQNORXgJBHalZrfW/uxanwd9oSfvIrDyIEfZQYmnORFScvnBTsC6o+GpGS0wmxuHACJfqADAfWT/gAu/o7p1EfNhYCOhKt09FFq3DQsW01+ndWStVs4Skd1XFKn1WJG/36696a/pl3l2G0IXDGjh1iYk/fdNL5phlwWKQOBN7+o3lGJ1w5qjXLddJP1ATVDm7jzisPXmvVzkhCZQOw0DT58mLqTV70ESMeX3Z8NmLMCUvRuoMBl9dUkYCBFdAjOgu2Bk68qtdVFCpyjkhd/P3q78TGGe8gv4p6L3I2AoGTu9y25PGM2KKEMhcrdOt7h8tcJrr7UJ/EbZshlCHkoz9KMKFVFK0U8jr7By51veaxpTVAMoRcSmuF2djEJF+NJFAt0WfcthyzzsdSSTOX0M5OeDkGI655v+3E2/wVoAa7KCb31/F01epHKT883jV1BRjE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Jul 2025 at 13:47, Andrii Nakryiko wrote: > > But given how frequently task->comm is referenced (pretty much any > profiler or tracer will capture this), it's just the widespread nature > of accessing task->comm in BPF programs/scripts that will cause a lot > of adaptation churn. And given the reason for renaming was to catch > missing cases during refactoring, my ask was to do this renaming > locally, validate all kernel code was modified, and then switch the > field name back to "comm" (which you already did, so the remaining > part would be just to rename comm_str back to comm). Yes. Please. Renaming the field is a great way to have the compiler scream loudly of any missed cases, but keep it local (without committing it), and rename it back after checking everything. Then just talk about how every case has been checked in the commit message. Linus