From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A504C433E3 for ; Tue, 19 May 2020 16:36:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 313C3207D3 for ; Tue, 19 May 2020 16:36:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="UORYpGfR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 313C3207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D21D480007; Tue, 19 May 2020 12:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD0D4900002; Tue, 19 May 2020 12:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE6AE80007; Tue, 19 May 2020 12:36:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id A7E43900002 for ; Tue, 19 May 2020 12:36:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 70759180AD81A for ; Tue, 19 May 2020 16:36:36 +0000 (UTC) X-FDA: 76834021992.07.leg01_1c8ac2e1d253c X-HE-Tag: leg01_1c8ac2e1d253c X-Filterd-Recvd-Size: 4116 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 16:36:36 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id h188so64000lfd.7 for ; Tue, 19 May 2020 09:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z16ZFiLRHWlE76l/Nnyd5FZZ2VSBLxmf0lz5LDCxbPs=; b=UORYpGfRWpAQPT7Eim9FPjPnn5GKxiDiyP2S+AQw0QYKUVeSC2Y2buNVi8EbpRkorO IcT1mnMe0MchbGIuyrDccORk12Xm6v8WUDLE8lpsgynSHzLIn9GW5XFMJoAg1fWLV4X4 DbGGa/kxryZV9vtywESRiuCWoDlSmVvuwa5YA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z16ZFiLRHWlE76l/Nnyd5FZZ2VSBLxmf0lz5LDCxbPs=; b=sGIigCElQ5CLvS00h+nog/PKBy30Js4rqe8Ws93MkbigZMJdQq+Q9izNFdqhMsV9l4 RvmeZSepK1G5CHBdOVxwNluwfjKEQ/YaDCZIvguSBwsYx5/rAJQfXEckTE81pgGWVls4 E1QNAcBsZkruTYfokIHUU9GetibZVcU5jHzRXpnYVPSR4/roQRA7YDpRecmIHr3WeBtH gxLfoxjqHs+Y6KBjAxEuxyvmabTFlJopNYDsZ1DIFUlO2Kwd8rMJ23Q9+H2QkYhv84XG JIg+GsnNzBnwahDX08LiZeeKtxeCKbO/HMbrw/2W3rZ9GyzZTX4XvFAgOeif5pefCs5t y9UA== X-Gm-Message-State: AOAM532Nfoj+KRd6kBkiM8fmEc91EivQHpSRsTa+DuUjuXDXDWGwY2ei QiySH3Sh3mdsabLrdLlmqyfG3eX14WI= X-Google-Smtp-Source: ABdhPJwvz8RSMxK3vwt+0UDLTmvQG7/2SAXCrj9a7KggKtOp3hBbhU5VISi7wJMQ3ujMEQTU6Y0jig== X-Received: by 2002:a19:6914:: with SMTP id e20mr9460495lfc.27.1589906193481; Tue, 19 May 2020 09:36:33 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id k24sm58120lji.94.2020.05.19.09.36.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 09:36:33 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id w10so460477ljo.0 for ; Tue, 19 May 2020 09:36:32 -0700 (PDT) X-Received: by 2002:a05:651c:1183:: with SMTP id w3mr156059ljo.265.1589906191917; Tue, 19 May 2020 09:36:31 -0700 (PDT) MIME-Version: 1.0 References: <20200519134449.1466624-1-hch@lst.de> <20200519134449.1466624-12-hch@lst.de> <20200519161418.GA26545@lst.de> In-Reply-To: <20200519161418.GA26545@lst.de> From: Linus Torvalds Date: Tue, 19 May 2020 09:36:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/20] bpf: factor out a bpf_trace_copy_string helper To: Christoph Hellwig Cc: "the arch/x86 maintainers" , Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Andrew Morton , linux-parisc@vger.kernel.org, linux-um , Netdev , bpf@vger.kernel.org, Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 9:14 AM Christoph Hellwig wrote: > > I don't think we need it as the case of > > case 'a': > case 'b': > do_stuff(); > break; > > has always been fine even with the fallthough warnings. And the > rest of the stuff gets removed by cpp.. You're right. I read it as a fallthrough because as a human it looks like there's code in there between, but yeah, the compiler won't actually ever see it. So scratch that objection. Linus