From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jagdish Gediya <jvgediya@linux.ibm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
ying.huang@intel.com, Dave Hansen <dave.hansen@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool
Date: Wed, 27 Apr 2022 15:50:49 +0200 [thread overview]
Message-ID: <CAHp75VeAVFNA7faZjsHOyAM2ZKU=xWTVZDKiPwY2woKW712Qpw@mail.gmail.com> (raw)
In-Reply-To: <Ymf/yyPLGErQji06@li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com>
On Tue, Apr 26, 2022 at 8:49 PM Jagdish Gediya <jvgediya@linux.ibm.com> wrote:
> On Tue, Apr 26, 2022 at 04:27:01PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 26, 2022 at 12:10:01PM +0530, Jagdish Gediya wrote:
> > > At many places in kernel, It is necessary to convert sysfs input
> > > to corrosponding bool value e.g. "false" or "0" need to be converted
corresponding
> > > to bool false, "true" or "1" need to be converted to bool true,
> > > places where such conversion is needed currently check the input
> > > string manually, kstrtobool can be utilized at such places but
> >
> > kstrtobool()
> >
> > > currently kstrtobool doesn't have support to "false"/"true".
> >
> >
> > Ditto.
> >
> > > Add "false"/"true" support to kstrtobool while string conversion
> >
> > Ditto.
> >
> > > to bool. Modify existing manual sysfs conversions to use kstrtobool().
...
> > Also Documentation update is missed.
> I am not finding any related documentation. I can update
> the comment on the function for true/false change.
Yes, please.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-04-27 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 6:40 [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool Jagdish Gediya
2022-04-26 9:39 ` Petr Mladek
2022-04-26 10:03 ` Jagdish Gediya
2022-04-26 13:48 ` Petr Mladek
2022-04-26 13:27 ` Andy Shevchenko
2022-04-26 14:20 ` Jagdish Gediya
2022-04-27 13:50 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeAVFNA7faZjsHOyAM2ZKU=xWTVZDKiPwY2woKW712Qpw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=jvgediya@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rf@opensource.cirrus.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).