From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965E3C433EF for ; Wed, 27 Apr 2022 13:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E26356B0071; Wed, 27 Apr 2022 09:51:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAF616B0072; Wed, 27 Apr 2022 09:51:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27D26B0073; Wed, 27 Apr 2022 09:51:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id ADD816B0071 for ; Wed, 27 Apr 2022 09:51:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 76274284F8 for ; Wed, 27 Apr 2022 13:51:27 +0000 (UTC) X-FDA: 79402796214.28.87A4A30 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf30.hostedemail.com (Postfix) with ESMTP id A5E418005E for ; Wed, 27 Apr 2022 13:51:19 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id p18so2013000edr.7 for ; Wed, 27 Apr 2022 06:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ME3k6FVz9MhikZB8YeQDQMy2j/6J30B2O0RtfV1l4Vs=; b=R+1uvwZ+roIC65MCNVVtIZlXIdCojO529o26SqQVucBsTFonn2EyQX0WvTDI6z5i5J ahaOo5k/LSry8UJiPSrYiXRl40gVZ5IAyWx5WlaChPxQfiTdA2Ut4GKiN+5ew/k9vedZ ZrVemdWVQF65SNTUWQopxVuHV/KUcmgG8gTDn7gMDNuyFtqeol5V7Rnmr1vv8k2etFHn 541O2ahIp1GHuAxMII3XddclDsTulr+/okLlBMYwemCvYhFLVhTdNxeDC1tWDCZJZjdu ypsmzG3DfgyiqD6pkGm14bVib9RQTszLIUiLlrX9CXRliUEQhTYl0DeQzwl2p0JiwCHP IbRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ME3k6FVz9MhikZB8YeQDQMy2j/6J30B2O0RtfV1l4Vs=; b=R4h+YWMWR/bz5wkEfILZYmsxbaJGIRaEETcHvDvK103qT/aJp4IhCXBb4Y2VpVDERT QtY0+nDmKF44bxyyNMGPpy5LQFCFr6I/V8HI1tfVFH/vUSu90Lw1ALJ7Fr8jQ2uOv1l5 mk0ON5hpgYqN4vBURR5bbtwJCd/3pauxRGTbSqYfIx48KbbpUsbQAuvF5B6KLl/dfpks R1Ks+Cp8VTqSbdTyZVvNZl0bBrielCDLKRHUZ17YlFFJ+e9mmJK4SaiD2GdH3gWL3Ws0 F/a1JgRlrJTNZ1ZoN/ar5Tg7r55f8Szw2TrzvSZ79Ymog7aHgUaeEcqCKjad+SA42FOf 3hTg== X-Gm-Message-State: AOAM530Ioy1ltPFmi9DpcO+SI8c62lJ9plhVNaTp8fcXSgTt+Ng9Qu2e jM46JTu6eeV6mO6NDW8XloOZkGvoe2zdcKoXsGc= X-Google-Smtp-Source: ABdhPJyPt00gR6kCyybTagoxwc0M5rLTuN5tBDFNG5rBmddOwlzJgfpF2F7hsTIVixrMAh3zGL6yoX2RtAsE1BzY5Rg= X-Received: by 2002:a05:6402:54:b0:419:9b58:e305 with SMTP id f20-20020a056402005400b004199b58e305mr30077944edu.158.1651067485669; Wed, 27 Apr 2022 06:51:25 -0700 (PDT) MIME-Version: 1.0 References: <20220426064001.14241-1-jvgediya@linux.ibm.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 27 Apr 2022 15:50:49 +0200 Message-ID: Subject: Re: [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool To: Jagdish Gediya Cc: Andy Shevchenko , Linux Kernel Mailing List , linux-mm , ying.huang@intel.com, Dave Hansen , Andrew Morton , Richard Fitzgerald , Petr Mladek Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A5E418005E X-Stat-Signature: zkmfj7nmikgsqkfuf1fkaehbysswkwhf Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R+1uvwZ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com X-Rspam-User: X-HE-Tag: 1651067479-135944 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002287, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 8:49 PM Jagdish Gediya wrote: > On Tue, Apr 26, 2022 at 04:27:01PM +0300, Andy Shevchenko wrote: > > On Tue, Apr 26, 2022 at 12:10:01PM +0530, Jagdish Gediya wrote: > > > At many places in kernel, It is necessary to convert sysfs input > > > to corrosponding bool value e.g. "false" or "0" need to be converted corresponding > > > to bool false, "true" or "1" need to be converted to bool true, > > > places where such conversion is needed currently check the input > > > string manually, kstrtobool can be utilized at such places but > > > > kstrtobool() > > > > > currently kstrtobool doesn't have support to "false"/"true". > > > > > > Ditto. > > > > > Add "false"/"true" support to kstrtobool while string conversion > > > > Ditto. > > > > > to bool. Modify existing manual sysfs conversions to use kstrtobool(). ... > > Also Documentation update is missed. > I am not finding any related documentation. I can update > the comment on the function for true/false change. Yes, please. -- With Best Regards, Andy Shevchenko