From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0500C021A0 for ; Wed, 12 Feb 2025 17:21:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76FB66B0082; Wed, 12 Feb 2025 12:21:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71F406B0083; Wed, 12 Feb 2025 12:21:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60D546B0085; Wed, 12 Feb 2025 12:21:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 42C556B0082 for ; Wed, 12 Feb 2025 12:21:06 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D730F801B8 for ; Wed, 12 Feb 2025 17:21:05 +0000 (UTC) X-FDA: 83111958090.16.CA0B16D Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf27.hostedemail.com (Postfix) with ESMTP id 0EF5E40023 for ; Wed, 12 Feb 2025 17:21:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XwVR6sED; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739380862; a=rsa-sha256; cv=none; b=SIpML27+Ly0/Nsq62GZAO7kQvq3WVvrL5tvvpXaSJVSW1PpeTIb0LjXV6sUI2vSoNUricP u5WXDDshkcSFFYSbIfGXt54iCKneGfnarm/jFafMvA9wmqniqOSqAJxOn3xGVOJlzU3E9d 0nDoipYAlTd4JiLI0LlhQ8KPCv9aWIQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XwVR6sED; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739380862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jeSSZK4PSeNrLf/UkOnBIv88I7lwE/8/f+TqwBpL03Y=; b=fw0Bfk9f3wMJlxIYEYyi9yVTLuTgzCYratp+6B7+7h7FzDlprZpMvxrm49IEm9+T3+4ghs FyJsrFBqiR5awzmvlJPO96lNh0RivnL+9mX10Zzmc+IVka8jmieVTw9//owZEBovZnVGh9 NSalmoDQjFcUoNMBHfHEV/oRO6ROgUQ= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6e45dbf15c7so19136d6.2 for ; Wed, 12 Feb 2025 09:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739380861; x=1739985661; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jeSSZK4PSeNrLf/UkOnBIv88I7lwE/8/f+TqwBpL03Y=; b=XwVR6sEDOztMhMOqtBCX1va/f+ci729g1LndEfT8DB5SquVCNhwsSgOS8rcjkgCLHs kzwaMN8XFF2nRkJYvJTcZBCNmmJZ/raFmeajG89GzwQO1xEXiyxnhb97/AzziHa8L4UY m7eDU6B2VyT8UMVT8REi5RtMlLesZlmAlE1qcuuhorS1htuSEalTqc/4zOJazFwp4SsU L2t7s0C6zt3IDvZZPtW20iccJs1UQmL52r/uDpQVfkgvB0E4EbA237lPis0qevyijyc6 vbW0tyYxtkuDQCVMvt4l7WsfrTLMLgPvVoc8haUcjFj7/h2UGbhzxHuJDpwgBYHGaX0O IeMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739380861; x=1739985661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jeSSZK4PSeNrLf/UkOnBIv88I7lwE/8/f+TqwBpL03Y=; b=YXQ0VTAkvtrP6wRZwc/co8mcAhMcG8OmODvph4zGA+oJjQ5IG+DaLQu9Q3XNEt8+66 og/rGw8FKiUxZUXKY3ooTXCM+scjW9tVe2/tlu6Nt5FRBtBpdllwxxgyU5UQahKLU9VV Zc7gjVaZGoMUexjaRY8exCCtb3xEcJ7hAUVpEJl9NQogKjBJdvJdk6KHO8BR9mxd2+At 2WqtnC6AAp1x2miMKaomCnggRtJPRH0Lu9ipEqO/bB4h818bZ99eI1oGEajvhHtmdI7s Dwq+eIJjKR7feXDFeQ06lawPUY9QfZfT1zrOgJ1eV4DqTIyUjRnqa+zwxV056OSWJaRc dPJQ== X-Forwarded-Encrypted: i=1; AJvYcCXU05asQnaQ/UvDGL3ZoELYOBE0mtcI3TqEnqTdw4KWH4/+sRfv7HfP075ISsxvQgsZXQg7EpTSew==@kvack.org X-Gm-Message-State: AOJu0YxnjM9G1sXYWib2sKmUd1ZOTLeI4MKJxeyXfTQg3hUj1V1/3tPr sEPvMXHz3wps8TxArVppg1C+icnwi8ivrNjGAzRaKpiI67y7tiVU+/uWEegFI6D4FLk0A9su9+N 6W7Q/msUvxSLNhf8qaNqhSundSU7bgHuf1LRf X-Gm-Gg: ASbGnctROXIKx/y9QPnbeU6IVLNGec2qaDtGGVBSSN9igZS09k9fhLzeeDZJtUwHpYI ZW0aVUgxX8aYyKL8ARq+X7Wx5ET0+O0NHFjH8PAXF/Qiw18uhMVQINmPXNHClD4eZ4jIKqQ== X-Google-Smtp-Source: AGHT+IFOkxUKiInOFKVjEDV47EXlD3ULSW6dxOqnsUEPvjxezkS9zqVjaKFFy5oyAWENy0XvWvkqFUEKm6tzA44qU9c= X-Received: by 2002:ad4:5c8f:0:b0:6e4:4484:f357 with SMTP id 6a1803df08f44-6e65c14e596mr4105176d6.30.1739380860578; Wed, 12 Feb 2025 09:21:00 -0800 (PST) MIME-Version: 1.0 References: <20240318204212.36505-1-21cnbao@gmail.com> <0000000000009221d60613f58726@google.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 12 Feb 2025 09:20:24 -0800 X-Gm-Features: AWEUYZm3mTuZ-aqDMu9sN78o3Ka1eekgR0-dKvrCFpfG70KvnGGvV3eUT_2Pwd8 Message-ID: Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one To: Barry Song <21cnbao@gmail.com> Cc: syzbot , ira.weiny@intel.com, akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 0EF5E40023 X-Rspamd-Server: rspam12 X-Stat-Signature: 37wiu94m9ychyejykywmgugbfbuz96ig X-HE-Tag: 1739380861-675237 X-HE-Meta: U2FsdGVkX1+CrpVqr3usvN+1JoYHrwbTheG7OVt4Hg9R+3MTXeWRvXgY07Aysp9L4vzOQcffCc3e4m3m/G33JULwr/Y6gjIXisser5+caHrpbpix4b7Wg9uAxiqTEgSHtoX5O3W4iNJpNKgpg4u1GgUpZJnBnydHa2XIiGyJ0hYKKx2m3gLDhbJa0AC6roE4xocEjN6NmDjFrPUVCQv/osi4PwHEHu8dZ3aQ5cD/aD1IligJsGqdmrIhOq4XGEuXdHwyZ/eIsBXPzp4FMUW90PzgH737JdgFZeBWSE4+87KPalr3piE4MBfqJQUjVyDarg8ebpu2DgMFk60nkY2GtltgJmQaqcam9qstoa8W6GWYoF+Aa8/kkEtJIHHRIWCHziLX0IMrhxb87/sSwxucZFjkOIFQxLWv4xqWPqMm8iA9Qj5gyLbLIWUC5JXMXj5+d2M/w37hwPDyKSFMk7L6rmUqOcMJ7eoy6aqWcqDc+J9zYRQS98gTlsliy6k253Z6ZzAqBdisWSLDYLg1kwcaw3vlcg7VNy5rY1ayhL1dN3GI+Dhj0todvBev5UNKNBkG06Anx6/rxNSYhsB++rFqf1ELBwraKUXs4cNJ+5X28CzKn8SaGQ/cqH/4G0Nf2fVqqQPlAUZrp7Fg5nRQVdq5Y+edNCtCg7MKxqPhQQpR4sRAqa5z9Xh2t3GtHAg9HSm7Z5bpwWpSFyIkgWL0ItUQLb+P7Pm+tukHDoTJay6jo58covvmMFeJSrEMchPlUh/gwEZ6po0+xbvvfffHJ2m4suaIr3LS7KziJfuvBNlFIa+Sq1mqrNar1I9j3POw0iNqm8miJWjDrxaqpA3d3PlZHi+h714Pg0Q2sJOuD9t9DhyVjC4w2Nhtj9+/xLCijOlZnpKOFHj0YCp/KzfG6k3F9o1oImj2HkGanmCgtA3cHK2DeeuNwKFmQH3LOVeaa5UArW8Y/i+0S0DSs66g17v ekSxo68x uutSfDSw+JdP+tT+0mrvBSEz++HwaVUwUQwhhUFvQ9Gl4VB53DvNnNb6aSmnGrnAKIyfMWzXgWELRalOb1zj9FrtfoPtsGyI2fOZ1ZQhlZgHs46Ze/ZWDPJX2NS+bxQKZ7YlSbAUczZvC9kn/eItz0Jli+oVenUZ9kYeRwVsHYnLGRQcBBlneAJZWdgDdMoTgBTBALrjoUYBgAYOsYb/1d0rCq/2OpT6h4+9szv1C3jujo8bn6p5Jo+kYHZBA00ZsDgLklwjzqnhDSV3d7FMMQu7roDODopu+aIe3LAiEp9DNuH4akL8xXpF2oIzE60SSzo9VzNbJKsXKd6f3+TUVm1SOHoET9xTlNVJSeTsdRaJViDZEcZgKY8Yrx+CWS+MTsXNklRs3OIx7zVnKfofmur4xhw/kNzC5EV+mhNt+2lM8VJCO059Xs0cBrity3kxhXH2bLqZOVQLfXvFW7X/IbatuTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002112, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 18, 2024 at 2:03=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > On Tue, Mar 19, 2024 at 9:52=E2=80=AFAM syzbot > wrote: > > > > Hello, > > > > syzbot has tested the proposed patch but the reproducer is still trigge= ring an issue: > > WARNING in __kmap_to_page > > > > ------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 3529 at mm/highmem.c:167 __kmap_to_page+0x100/0x19= 4 mm/highmem.c:167 > > Modules linked in: > > + Ira > > Hi Ira, > > I noticed this warning is coming from commit ef6e06b2ef87077. > > you have a commit message like > " Because it is intended to remove kmap_to_page() add a warn on once t= o > the kmap checks to flag potential issues early. > " > > Do we have a replacement for kmap_to_page()? The background is that we > want to pass a highmem buffer to sg_set_page() but we only know its virt > address. I am reviving this thread because new zsmalloc changes will make mappings sleepable, which will allow zswap to drop the memcpy() in zswap_decompress() -- except for the !virt_addr_valid() case. We can get rid of that too if we can use kmap_tp_page() in the scatterlist code. Ira, could you please answer Barry's question above about kmap_to_page()? It has been a year and kmap_to_page() is still around. Thanks.