From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7CCCD37AC for ; Tue, 3 Sep 2024 19:41:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C6588D01D5; Tue, 3 Sep 2024 15:41:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 974368D016E; Tue, 3 Sep 2024 15:41:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83B168D01D5; Tue, 3 Sep 2024 15:41:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 66BDE8D016E for ; Tue, 3 Sep 2024 15:41:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1F5A91C21F6 for ; Tue, 3 Sep 2024 19:41:47 +0000 (UTC) X-FDA: 82524447054.28.C57CFF5 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf07.hostedemail.com (Postfix) with ESMTP id 5482C40006 for ; Tue, 3 Sep 2024 19:41:45 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IuIIap3H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725392435; a=rsa-sha256; cv=none; b=116RZeXxvm4s1B2hXsAN858rxIHY4e+EYxQ4V8oVKLG1dG3u1FNBX7hsIdGZpdy2VG/bWo u6FealDqKt1fYuLxV+4GpJ6hPFP99J1qx7XAdmg1MQmRw1M0zfT5CREd0nWaNga7pRshoj llVKIpyXuWy1NwAYTqbKN+gwfjcbRkI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IuIIap3H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725392435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ulJe0DxztcTweeavIBv/J7BVFYkM1MVqEhbfxPn4s+s=; b=fl97ABqftgDcXJgMlyj12e4THsmLPmBhwCahDi4yZTh+9AMrBQH1XSDB68dZN6IApCSh/z Hs+lafLXjXsb1icirTN6/+fybkyzK4dWf1JHRbnJhZRaOx0D9wAsYHWMknieCT94C6BEx2 VNbBBznKg/DTuUKzFF7K3GXD4wyUMiM= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a8a1d78e7b0so977866b.3 for ; Tue, 03 Sep 2024 12:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725392504; x=1725997304; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ulJe0DxztcTweeavIBv/J7BVFYkM1MVqEhbfxPn4s+s=; b=IuIIap3HDENG0liG2l5GmAeo+8jpI108u6EUYKKDff7h0GhmbCbu20wTNayDc6Cla/ n1Ga9kV6Wo50yuYSWT/22iKwUuoRTBjgCOIvPkf1JwVuxZ9XObKhk/d9GaQjljmpg/8q kB/8E84ONYWpKNLOOIWvX4BODqoA8lktjNwHcqM5Y/n/xYGN3gLg8+ORFQl4NcJSNZ5m JWzh3Opwu7bj3B8/Kn9fsVD+oO8iTxfafp6t31mbZkJqbTjvzOBFRjPgVhqTfowDObin y3qoDDZn0L+EWkePQKAdr3WW7j2JOgR3bhvgUhL97WV/5upyLXyFfFWqAF46LVEKKVXI tV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725392504; x=1725997304; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ulJe0DxztcTweeavIBv/J7BVFYkM1MVqEhbfxPn4s+s=; b=C6TbDqFX921bFnJeAxa0CxG7zWfsjWZQQNuIE4yVWWUaSxND72dAxyLvrjlvr4q1q0 XpLOyKAZmlUcWylrYLPuxe6sKU1lX8BMArmIuvbHaoJKStNe4P2hZ/jPbj9kiiuSGdPI AJptJKc0G7sRoyM7qkWaA1Vg5HQtHy3beP4qomFopepU/9xxqfiU0R2pDcB8KGlfgQc0 WnZBGu1iqd4jsAKdtB1atvtDequQpGnnmbuRCpmrgenWIFuG424FZyXuX3Y5CkIWCMYo HPvXNhN2ro+mDsjjHcisoFBECKfQwKOke1uZlO1Rmi/9Dfi8ilgw3yPMzcJUznRd1ey3 Gmcg== X-Forwarded-Encrypted: i=1; AJvYcCX8CvsoHTznrLBT2TtvAhWEHbf/zQxcCYwadLu0kPphYVEgJyaDbhT8GdHKCRryUc1u2oXFEXnd/Q==@kvack.org X-Gm-Message-State: AOJu0Ywek9MJVZBhXPJoTFZsBEM6Njp71wZk1zaEXudSMU7q4qvz2PdZ rCVkZOCPr5L4fDKpOIOOAg541YQ/2FI/QM5QuNwWEoJLzU+Z0apYCNm69XSC9KH1r/Ygne7JUxH ZJxJN98lyrgyYDylPhgZ7OQs5SpfJF8fhnj1D X-Google-Smtp-Source: AGHT+IHJcJq7aFM6e/h0j+rnGvilIYdEVljFkR6d/pNz6/Bk0XabK3Er/a+7iPLrhB/W6ZT2+co5ktIrnqIcPcHKTRM= X-Received: by 2002:a17:907:efe2:b0:a86:a178:42de with SMTP id a640c23a62f3a-a8a3f532680mr7874966b.54.1725392502780; Tue, 03 Sep 2024 12:41:42 -0700 (PDT) MIME-Version: 1.0 References: <20240821054921.43468-1-21cnbao@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 3 Sep 2024 12:41:06 -0700 Message-ID: Subject: Re: [syzbot] [mm?] WARNING in zswap_swapoff To: Kairui Song Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, chengming.zhou@linux.dev, chrisl@kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, ryan.roberts@arm.com, syzbot+ce6029250d7fd4d0476d@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, ying.huang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5482C40006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: eabjfk3dyygczgg78xt47itz1w34dxeq X-HE-Tag: 1725392505-959889 X-HE-Meta: U2FsdGVkX1+smzRgkx//ZFMyFbRqX2EY/xRp7odQOrmipQ1bYPq9YDMuZlPcK8mH+n/vx6WRo9kjHRDkbOpIZ3NfKSlCm+XJmTiPWXzt8jls2KQxi8Mz9CE11o9IeUhbxAxVQBI/18Vnm8B0b62E5Ox9tL1SSqW+He0ESD1BKoTo/S/KFohfexR4He3iUDphloqrPJ0NSc/1KDQiuOC/6aN3ZxW6Wb+xANdVSy7mo+VahoYLZT5bi17ISymWSa32ZRlrf/jcRDE2L4jEHt+ISsDmuf9qeLrHOVWxgKLs3OmEPBn6KIkomsNgLgDhcSlLpRt5y4zJzkm0zsVga4QSdiBR+oQi00fvTT8hDfXF5aw/negZKD402zGFFTySo+iP4xFLwNw7s3C9XaFnLvaA93wW4poq4TQbXimZrFHyTjBzEtCVqGQFoATnRM03i8OV4edYze0/7khW/6ehcf2UsGZBWhen8vZCXc5kjgJY98yRfdlrZBhmIBBDslWhiXTzKFjpMXkR6UKZ2IpB57KHRUwAKBGEEZLBjV0330Ld6t1rvW6s+vOtq/gdMzZATBBxJLpzBLCNwXwS3AK5dZ7tdZMmGuzw+Bg6zSf5M/AALe/DYShk0ccFzC3my6aghy2XIFPTEyJ7quZ/mDTcj03kehwcLQ2OWN0C+NOalDbYFcSam656sOxS+X64EhaP1GI3miuR0MK3B8XSqLf3Bc9/V6JV026pD4+HfjFo/E60AGl5zH9X5T+zLHzHxoQZ3iRG/3nI9xbKc6ZMy3wbxBwouB/59k/gzYX7d//3oiWAoNSj3O6gN23lX0Xjs8tm1YSpcLq7x3uOICGu7mHqMNkR2nyhPvk1BdS1GSVZGzUUUe/6J7ST3h4r//4PRh6bTCfPTQ/dj+/h8b55tE557305vQt83vi39yDgxk+u2vv6lK8d9Z8LqFX66xSW9byRzvkgHXiyPznGPLgoRPBq8rs XIQ6T9gc kVkB51Rp2XQ/12ATx8rSMa2AcvNh+IjaxSnNF+usZaOH+0ID56Xt56w9BErCL3JqU4ZET0Rgsd2+rBJip5JH8ZXHqyJpRTZwMRN1OO7XFMKAdXLSrRipr8r6Y6K+yG6kfO8uzPZPS0SNpOhZFpWlFNF4xsoXrbL2tVban2lvXxCsBY9ScuMq7DC7PtgpFhfW4++0fsaynGZjnL2HV/UMceJk9IL52ogBF1LMeYINm3pBcgh3NItoL1LSHXUxG2cG1KUSm0SwzKcXM2YwPh9TRBMwHuQheH6sQXcwP3fOwwjQ7ESbrc+EGGp9QsLhff6ewg952ROJfpnksBS/S1gBJHrFHmgd3WBnemJCDaAQTHZRQDR2cZkhSCrcYv31amNbalz5ufV0hAUmdhwJ9hlxj+WvJxeY8SExm+mRJ3qg4W6sgtjHm9qXSpvMyFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000106, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 3, 2024 at 11:51=E2=80=AFAM Kairui Song wrot= e: > > On Wed, Sep 4, 2024 at 2:22=E2=80=AFAM Yosry Ahmed wrote: > > > > Hi Yosry, > > > > > > diff --git a/mm/swapfile.c b/mm/swapfile.c > > > > > index c1638a009113..8ff58be40544 100644 > > > > > --- a/mm/swapfile.c > > > > > +++ b/mm/swapfile.c > > > > > @@ -1514,6 +1514,8 @@ static bool __swap_entries_free(struct swap= _info_struct *si, > > > > > unlock_cluster_or_swap_info(si, ci); > > > > > > > > > > if (!has_cache) { > > > > > + for (i =3D 0; i < nr; i++) > > > > > + zswap_invalidate(swp_entry(si->type, offs= et + i)); > > > > > spin_lock(&si->lock); > > > > > swap_entry_range_free(si, entry, nr); > > > > > spin_unlock(&si->lock); > > > > > > > This fix from Barry have been applied for mm-unstable and it's looking > good so far. Are we sure it fixes the problem? Unfortunately we don't have a reproducer. The swap entry freeing paths are getting too tangled to know for sure if zswap_invalidate() is being called in all cases, which is why I prefer having a centralized callback for all swap entry freeing hooks. > > > Kairui, Barry, any thoughts on this? Any preferences on how to make > > sure zswap_invalidate() is being called in all possible swap freeing > > paths? > > I have a set of patched that removed the si->lock around > swap_entry_range_free, and the slot return cache is removed too. So we > can move zswap_invalidate into it as locking or caching is no longer > an issue, I will post it ASAP. That sounds good, but I am not sure I understand what you mean by removing the slot return cache. I will wait to see the patches.