From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0194C3DA4A for ; Mon, 19 Aug 2024 20:13:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195B86B007B; Mon, 19 Aug 2024 16:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 146706B0082; Mon, 19 Aug 2024 16:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00DA46B0083; Mon, 19 Aug 2024 16:13:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D4FD86B007B for ; Mon, 19 Aug 2024 16:13:01 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 59113141556 for ; Mon, 19 Aug 2024 20:13:01 +0000 (UTC) X-FDA: 82470093762.11.F5F156A Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 77C3B140017 for ; Mon, 19 Aug 2024 20:12:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aRgh5DAf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724098363; a=rsa-sha256; cv=none; b=xvxEYBh20ZYKHSuI52EzGkU4bZnlyZNx+FaM5UADY5GQs+7XYUFz9I28wUxhTOhe6yESnE dTM5MPaPvN3lqPbZOr6RsMLakVKHi2F1NnKEUoPA7wSS4XGV8ZR2rkajQkdJpBYWwP34t6 6/VMl3/B4lCpoINloPqoxnmUC+CkIl8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aRgh5DAf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724098363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0IHP3IXv9tkhttF23+h9A3PLRc1T04eMz8zhHjUswxs=; b=gpVf9ZlinHwgKQ8FhCz7zHR7pDH0hUYQxAQWkFDPs1tG/duWY7V1uStpFMY+3sreY6rZxq pX2bDg8v89NjQzpfS0KsbckMrklXM3Te5Y5zVLuHtAiT2Kgs2IsSc6JhfCpIMNqPj+wLrV plsrJ8uFolhNyNsjkcFHP1qK1GY2/2I= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5bf068aebe5so1100958a12.0 for ; Mon, 19 Aug 2024 13:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724098377; x=1724703177; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0IHP3IXv9tkhttF23+h9A3PLRc1T04eMz8zhHjUswxs=; b=aRgh5DAfilyMdeRKWGHWQ+ux50zqL5cV7dWSETmSIgbH1WMMdjeMAWsxnWzG2XnroW KtX0t+ST74aVeZGLBOXzVe9WJXdCTwpgmf7YyoHSm5l5iOQQlPzHm2QccJMxa0e14e5e Yg4W+pmRwMiKT+b56qxZfBh4YHVa4d0hEHFriCQMajxcAPsR1bEF6kfUe5d0h04FEGfC xUrcUV8nD2yFbupUvhRVC3arACBBDc/kIOlaEGVTK6Pb/Pi4rsKBjqunyy1rSo3lVuLR 5TzkmNdldPjK69xme0xsq7K8zY2OIKSVSHZ4PkR2834eSOi2c+4X1+fp8LU5V83t4fja RcTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724098377; x=1724703177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0IHP3IXv9tkhttF23+h9A3PLRc1T04eMz8zhHjUswxs=; b=iqpenmKulkFXG9OxbdTEdf/jXvUezDAtkF3TH6sg53bNrC8YbQPFtYxDrmzBR+GXpJ v/4qBiARr6APeZ5etOGaKziysIvo6cxwV8eUWNiDmTPjEZCH5tj+dwCg+f1f5mALKqkP 1OUijDtzmFPpvfy9jtoKWBwc76H/2QxLhFY7BXj2boA1hhX3xUJR/GbJLBIfDrmi4x5j MYdXJqi1WgGOwGywZLfugVOTPqt4QhEWYYhpC+hyG0y36hHyPVQWsZeIoCdQtA729jeG 3kVkrxrsVMhqi+qKbrgZ6OwsJoRqDuMdm3WfoumHYsuyYfUEVuMQnV3O1bc6wUEQfwDJ UhIA== X-Forwarded-Encrypted: i=1; AJvYcCXeIvU4pfg68RrdZpiIV0fPEdyLW8sTjvCno9Vr7eLAZyttVKIJwTfy6WwcUQy2agKI6hzvJR38Qg==@kvack.org X-Gm-Message-State: AOJu0YwEDlUQgaKneLH/ha5M3nWclk25d3ZHaZRCRBUziawCR6SbKEXS uUsl1hsHeQ7tkid6E5kt62b+cz/9tWwU9R6rSP+EZcAv0XDI1EJL6SmGnFx4zlZAJUtS+yjWueg UwJWsaLGbXTx7ZjJ8EWiGnMXwkACJKlmNZ9mi X-Google-Smtp-Source: AGHT+IHf1DbTRTSJbNXcbrsMYzihXZRxQQ4bhW6nKZ/ZwU3ONcT5I+asE9RUPOGClkIBZ2C0BJ7bOTfpy8Gw9iYxzqQ= X-Received: by 2002:a17:907:c7e1:b0:a7a:aa35:408e with SMTP id a640c23a62f3a-a8392930f8amr894532566b.27.1724098376142; Mon, 19 Aug 2024 13:12:56 -0700 (PDT) MIME-Version: 1.0 References: <00000000000060cf79061fd24ca8@google.com> In-Reply-To: <00000000000060cf79061fd24ca8@google.com> From: Yosry Ahmed Date: Mon, 19 Aug 2024 13:12:20 -0700 Message-ID: Subject: Re: [syzbot] [mm?] WARNING in zswap_swapoff To: syzbot Cc: akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, syzkaller-bugs@googlegroups.com, Chris Li , Kairui Song , Ying , Barry Song <21cnbao@gmail.com>, Ryan Roberts Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 77C3B140017 X-Rspamd-Server: rspam01 X-Stat-Signature: 4sybqpbi9gbjph3h117scsfn5wt14fgk X-HE-Tag: 1724098378-983872 X-HE-Meta: U2FsdGVkX1++O0ghKDC9GTdXZANAW/ghLh0asBM/zdCeR+qyBoHvwYahqNul1TId2q1BFE6FnX2h1cMQ90SKjLALIvlgVCtrI5SgZHR1urkqlnL/BwetoLnS2Z9OUnzey/0RNUTEHKLb33xkd4g/yQEoL4yOotpZksz84r2uMdLKW9nfUQZ8TQlAW5Sn0fiI49Aav2ogE8T68URwSmI/cnWtJIqpJGgyde/RaJnssEJBglcDLbB7H9293uhOJsS1OXGchLCSAOosLa0nN5xTTI5rYLe+StDOuciQz+wsZmvzB/+8YqqFJQaJft/uGT0w43u29HJbH7zf9dajB+7qR5e8PLoBJqFFIXD56XdwfYmvduihu3DTFksgGr3Y9IhR5Ivq5Xj/p+3PcCZ/N9brD/Qlm6Gyh+G5BJy9XCcFKpryULaq3ITjIa1irr07lUAEwqqaZ4shhHitJRuwp21k3Sc4h0oTHnRfydAFWCSwhjfM7EffUgsUbiTcaPfbewZYb2YmF1pbyURR8aX0tp8FTjbVmaMPareVUWc1FjRJQN/3jLn25/L7wfvyy06Ek2eO6WOdBK165190FS+PeYkYTPMK5X89//kCC94Fqvjo6YtZZzCotGaYn8kwTPqsSEV4t7+e3EoG9eurD5AT5/KKUbj6dbTR+i16ge+MPcII7q2bsINKfrJ2p/8otvFeXzruJGbSMlyAvymkE1UteRzMSVtclHgJLQ8GHcGxgxSPf40ePO35aimtb0qlr5k7kh6Ajf3vP0QSgLeb0dN7I1u5k549fUcI54tLL2LsiMfV7Vqi9uYS4QMxGIhDkBUYHtM5bAPueiKb3YmU0c8Bm8+BjbE8HzW+2TWXrvZWznykj2RcgJMAOTTzI7Tory2+WZkb8zU0jfdmOY925/pqjgr8GUpYA3lTuHWiP46AApxzvom30+oxuOY8JSX2UFmgRHCRj8rEBPhdHioNpdHJKux Dfr4H2++ BGtFOwfZJjod9cfISntEgc1pmkRcBqk9I6jN1TwBA4ibAPvOUSfQGYHLZLmKMMKmBCRGf8dw65giUON/NwHh5UPRh4hsDoVxJb6ZaKe1wvmSB8gpxwAegLa3K08itxgULlxhgeGPKFRsIoqaJ2Lt0kfhUcBO80bNxYoQsTTE9jHDDbQ2ye8aov5DRWt+BtB3Tv4bbg7db/q2khDTDl2jMS04EOEuYgSvMNoMVXLjEFGcN8835mJyK5uk62RYnj9mUv+ilJ0DJr2juWPKrlAla1REV/UN8XifWTzbT7nSUno8F1cCn7vFc/RqvN6hAO3IaBBemw+e8cMLM3TbqT43dlm/awD3zCxu8xbxEAiDpPzjOtwCGPP48rOFbSxpGSqWy+7sM/qtCSi6r9dPhDQcjbeOBTs/mAlFJ+V0TW7cU6o4x27qaMcIqthexmn6siww/hswnpS7GrQfV/XqoxKK5mUioX8ULZSAQwNrnAOJd1Pjs9NwbxvETiDHvLA0aWZD375dMgdzhJN9SVjB73rSoPrGGN1eMZ3F/zG/55hkKEDXqfP7Jf+YA/AmATj/V8EFSPIrTiURpVTQtjPf5pfjKAgoSRR5NFQOfVODTE9U225tEAsKsTFelJyRF5u29k9WLSp0sk7Jjq/iG9fw3YrG5UEvbUIRZ5ahX6rlQ4yFAv23sQsCxmSE4BMZ1rt+GXrny0km96gNLwALS96ugbVCpMGR6sCsEb9pTVyc0fnkZNZgXdiK+b8HsjU73QkNKcJzNrpTWnsKiCsOH11mOZdOQ7rFAcHvK0zKszjwN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 12:52=E2=80=AFPM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit: 367b5c3d53e5 Add linux-next specific files for 20240816 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=3D1248910598000= 0 > kernel config: https://syzkaller.appspot.com/x/.config?x=3D61ba6f3b22ee5= 467 > dashboard link: https://syzkaller.appspot.com/bug?extid=3Dce6029250d7fd4d= 0476d > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Deb= ian) 2.40 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/0b1b4e3cad3c/dis= k-367b5c3d.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/5bb090f7813c/vmlinu= x-367b5c3d.xz > kernel image: https://storage.googleapis.com/syzbot-assets/6674cb0709b1/b= zImage-367b5c3d.xz > > IMPORTANT: if you fix the issue, please add the following tag to the comm= it: > Reported-by: syzbot+ce6029250d7fd4d0476d@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 11298 at mm/zswap.c:1700 zswap_swapoff+0x11b/0x2b0 m= m/zswap.c:1700 > Modules linked in: > CPU: 0 UID: 0 PID: 11298 Comm: swapoff Not tainted 6.11.0-rc3-next-202408= 16-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS G= oogle 06/27/2024 > RIP: 0010:zswap_swapoff+0x11b/0x2b0 mm/zswap.c:1700 > Code: 74 05 e8 78 73 07 00 4b 83 7c 35 00 00 75 15 e8 1b bd 9e ff 48 ff c= 5 49 83 c6 50 83 7c 24 0c 17 76 9b eb 24 e8 06 bd 9e ff 90 <0f> 0b 90 eb e5= 48 8b 0c 24 80 e1 07 80 c1 03 38 c1 7c 90 48 8b 3c > RSP: 0018:ffffc9000302fa38 EFLAGS: 00010293 > RAX: ffffffff81f4d66a RBX: dffffc0000000000 RCX: ffff88802c19bc00 > RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff888015986248 > RBP: 0000000000000000 R08: ffffffff81f4d620 R09: 1ffffffff1d476ac > R10: dffffc0000000000 R11: fffffbfff1d476ad R12: dffffc0000000000 > R13: ffff888015986200 R14: 0000000000000048 R15: 0000000000000002 > FS: 00007f9e628a5380(0000) GS:ffff8880b9000000(0000) knlGS:0000000000000= 000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000001b30f15ff8 CR3: 000000006c5f0000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > __do_sys_swapoff mm/swapfile.c:2837 [inline] > __se_sys_swapoff+0x4653/0x4cf0 mm/swapfile.c:2706 > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f9e629feb37 > Code: 73 01 c3 48 8b 0d f1 52 0d 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0= f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 a8 00 00 00 0f 05 <48> 3d 01 f0 ff= ff 73 01 c3 48 8b 0d c1 52 0d 00 f7 d8 64 89 01 48 > RSP: 002b:00007fff17734f68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a8 > RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f9e629feb37 > RDX: 00007f9e62a9e7e8 RSI: 00007f9e62b9beed RDI: 0000563090942a20 > RBP: 0000563090942a20 R08: 0000000000000000 R09: 77872e07ed164f94 > R10: 000000000000001f R11: 0000000000000246 R12: 00007fff17735188 > R13: 00005630909422a0 R14: 0000563073724169 R15: 00007f9e62bdda80 > I am hoping syzbot would find a reproducer and bisect this for us. Meanwhile, from a high-level it looks to me like we are missing a zswap_invalidate() call in some paths. If I have to guess, I would say it's related to the latest mTHP swap changes, but I am not following closely. Perhaps one of the following things happened: (1) We are not calling zswap_invalidate() in some invalidation paths. It used to not be called for the cluster freeing path, so maybe we end up with some order-0 swap entries in a cluster? or maybe there is an entirely new invalidation path that does not go through free_swap_slot() for order-0 entries? (2) Some higher order swap entries (i.e. a cluster) end up in zswap somehow. zswap_store() has a warning to cover that though. Maybe somehow some swap entries are allocated as a cluster, but then pages are swapped out one-by-one as order-0 (which can go to zswap), but then we still free the swap entries as a cluster? I am not closely following the latest changes so I am not sure. CCing folks who have done work in that area recently. I am starting to think maybe it would be more reliable to just call zswap_invalidate() for all freed swap entries anyway. Would that be too expensive? We used to do that before the zswap_invalidate() call was moved by commit 0827a1fb143f ("mm/zswap: invalidate zswap entry when swap entry free"), and that was before we started using the xarray (so it was arguably worse than it would be now).