From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69320C47DD9 for ; Wed, 27 Mar 2024 22:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2BC16B007B; Wed, 27 Mar 2024 18:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDB856B0099; Wed, 27 Mar 2024 18:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA2C46B009D; Wed, 27 Mar 2024 18:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCAAD6B007B for ; Wed, 27 Mar 2024 18:34:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4920F1C0F78 for ; Wed, 27 Mar 2024 22:34:55 +0000 (UTC) X-FDA: 81944275350.13.7C73FDE Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf25.hostedemail.com (Postfix) with ESMTP id 90354A002A for ; Wed, 27 Mar 2024 22:34:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0t4DBHE6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711578893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VGIRL0u/W/qPO6wlvUFvCQGLo4EDnsNdwhLSr7NSVes=; b=X4gffk8nV8Pqt5xpuLkFphaBNpN2OwtobNw0C5JJugnh0rfbgvLEJIV9siuGx3u/fPbjJP hCP4Ix+lV6mb2/UXlKRdiOtHRDdSpA4VvgTRhiwoWJfzMMuSernZ34poSd+WMkrtDEgMpe 1t2syhkWs6dNcJuNShnDhae1cZkGCow= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0t4DBHE6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711578893; a=rsa-sha256; cv=none; b=MWQpGGeiCBh7gyS8LWqMy8d3HBHNilZ6Yn91pILgXhGRWfv8/KlbF+udt9JYwV4CIweDdq dmBQow67w01DSQhhZCdXQCLU4BfVxpGRs6rPvOH2puAtyxZAmhdP1UcL2UsoZ9VfUrmCKB 6uZ6g0d00K6iM1hXm/o2naBhqq8O2no= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a46ea03c2a5so67535466b.1 for ; Wed, 27 Mar 2024 15:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711578892; x=1712183692; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VGIRL0u/W/qPO6wlvUFvCQGLo4EDnsNdwhLSr7NSVes=; b=0t4DBHE6I3gAyfcsVl+cDJXzQ/GDnMf7Z0NwAs1718NDw67Abs5A9havAoFusBtLlG zYja/AJfWLev7PQ1pZgBNF2PkXLhQLTWjaDRUVDDpNFRaLswJhwBSr/TLTYfJfYmheaH JOdud0YI7jSBcqxhoY8eJDTr1Df2UKxyAidL1kpCtq3VnWTeXteLVNPAYqlWlfaHXTpT +LMNOo8Zmu/elnbNg2/Fn6Lq0KXAOHmxrvKe0Hr/2xjpPaKimYjnBe4eCtP2V8H2mmJP Wd+d2cq9pZaE65qA/4QEJPWxsmEkywifOMZt6x/bnUFg//H38iVisJ+dZukRZoNQqXmy oYgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711578892; x=1712183692; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VGIRL0u/W/qPO6wlvUFvCQGLo4EDnsNdwhLSr7NSVes=; b=epCWXxOiJPFlth4QiLe606XZpkdmxw3PCJSR4oJSzMJg7dycXoaCWQmHSJv6bHPy+I qfOe/Bnb8o6mvuACs5dFsArjHD+7rrs7/TFioBnFGKyw1GSMOuFOsBbzHYMAEd+AVQGL 7F6ig6xcnDqprG+FXio7rXi58cPDk1wBVS3v3rFVrrD54S17ymSaApnmYcZtU7RS7HMz 1GKiDWAHNhQiY4y0+YZ6gnINIQiSnaYoiC7RIbLsME9+AURKhFC6QeT6QgOWtGQQcGmn h8C1BWtMPwi+LcTP20LFh6JLvW6fY/CBP0S4WS/WZ3S0YuFs7A+ZisqiQqf8NXGgd52I sY6Q== X-Forwarded-Encrypted: i=1; AJvYcCVAp1ecWDudi3N+IyNdgLlC9vP+tbSLl2cq+kg1tiiSJugzmuxUzF6F3SNUGeL+BFhwl7k0jrLvADcYVhJZsLAO2Rw= X-Gm-Message-State: AOJu0YzNnufpanE/8uCp75HwbdOmqA0hlLed7Og+EProjlZB/JlSfNL7 IiJT2wTrqh9o3oifAKNtUXt3SDsIysTcokmlfpWnX5QB78r4WvMxLaStY0EopRDShPhyyMwsRkf h2ezqxaZAICv0kAxbRCW6TX8I+u0fuf4xyKO7 X-Google-Smtp-Source: AGHT+IE4oRCJhxC13l4jo2VHG6Ts0gkVfAyq5pMdu2T2ldxiEy9xYYVSHonq23TOooasGj1h62r0AK2RzYTkIYuAPmE= X-Received: by 2002:a17:906:4ace:b0:a45:f209:d2cb with SMTP id u14-20020a1709064ace00b00a45f209d2cbmr542481ejt.28.1711578891882; Wed, 27 Mar 2024 15:34:51 -0700 (PDT) MIME-Version: 1.0 References: <20240325235018.2028408-1-yosryahmed@google.com> <20240325235018.2028408-6-yosryahmed@google.com> <3e1eedef-5e4c-448f-95ea-d50b431c4265@linux.dev> In-Reply-To: <3e1eedef-5e4c-448f-95ea-d50b431c4265@linux.dev> From: Yosry Ahmed Date: Wed, 27 Mar 2024 15:34:15 -0700 Message-ID: Subject: Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled To: Chengming Zhou Cc: Andrew Morton , Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 90354A002A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mzatbmoyzs9pbqwf3okkia8fjx1y3jqn X-HE-Tag: 1711578893-638322 X-HE-Meta: U2FsdGVkX18nELJf9hLzCuvA/ONLNobcmC2sGowVZ4zwc87uN7itpJ8gy7zAvbso1rJPxyK2cTvzjuSBXAV9sh7Jx7JWES7yOadG/CMcI2ZojPgwZQw1L2rLMFW+c1p09iPDyWj1Nw3mIfcNugYQCr97ewEqHj5AP9pn+Ik3gpodXH/z1uOpNOjwsFg68gAQH6iBDbAtBpSSuRKOppl6ruMqIRfPZellrfO0c2KZ4+rIXQi6+zMvhMTtgBK2sZbqLeUlvNMpHAHo2DWpLLRmUBO+5Ao+se8kGW9H7JmXUzxnaJVT7EoB09+INoYaZOmYkWNKDBVOyk+I/sRtSnJewt6rzl0WxphZxjqtO9C1Ti3E64qPSZ9pd5PNN51j5KlzfSlu5aNOz46nQt+thgmpEsBCehzl1obCHz0YoHgkwETPYry4vFx16FPk8Rjcb1Kz24T+tF6AxZAfhkbR0zgoJatg+iEpOssLryob/updBCBiCZqPPlCvfccc1LHE7vNfRYQbwjOL4rNU8gfmYms1IZtKgI1EY1eYH8gXFXxS25hX9zGEQK2EikJdoZSB4Kel4h1TsQdZYye/APoMjTQe5ZCTJJNvYoopsby18cw18k+XtEaT9uyYlYkrytCtF3h9eGLXDYgVL6eCxc8ZYhV3QhZapF2yfwbzzQud79elTZS94ttWwiq/CwjVj4RWvNJSKtfIOWyptgqZM8jNUaM0HLNZFbr3jKtL96qRHW4Y9pToeQYSrloyT4uu9ZvBH+C7lsi8Nya72xpqVootlSWIZbHuBa9iZSu5z3o72woBmvGAPlemH3ZQuWiZUk7415+YkXYPejM+eQoiHpL3GarklokI65XLLCfKAoe8O45/UBI5L+YXoXonlf7No3k5uKQ8X6t61mrwauajnuArLfRCN+pI0z+0SsEhClDmzOSHRbjUw394ZfjsskBhWi2zQDw6RGsh/5+v74Vr9vMhnPS 62+EmCBN tQNsnlhPKfCWF4dMyDcDCL17cqopBAGwpTSWPi5YN9L7LYtM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 7:44=E2=80=AFPM Chengming Zhou wrote: > > On 2024/3/26 07:50, Yosry Ahmed wrote: > > There is no logical reason to refuse storing same-filled pages more > > efficiently and opt for compression. Remove the userspace knob. > > > > Signed-off-by: Yosry Ahmed > > LGTM, should we also remove zswap_non_same_filled_pages_enabled? > Not sure if it has real usage... I am not aware of usages, but in theory you can use it if you exclusively use zswap to optimize swapping zero-filled pages. Not sure if anyone actually does that though. We can remove it if everyone else agrees. > > Reviewed-by: Chengming Zhou Thanks!