From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17519C47DB3 for ; Mon, 29 Jan 2024 20:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 825FA6B0087; Mon, 29 Jan 2024 15:33:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 788866B0089; Mon, 29 Jan 2024 15:33:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 652F46B0092; Mon, 29 Jan 2024 15:33:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52F846B0087 for ; Mon, 29 Jan 2024 15:33:28 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 25DC6C04C3 for ; Mon, 29 Jan 2024 20:33:28 +0000 (UTC) X-FDA: 81733498896.25.BB1F196 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf23.hostedemail.com (Postfix) with ESMTP id 5368C14001C for ; Mon, 29 Jan 2024 20:33:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VC0lQoSu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706560405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pJ4yjaXnu/gO8IJm2MvBxAL0/BI+WbXyDMVS9W9Dbmo=; b=t2pNgi+k4MDB6yVAJDH+f+AQidDTCzJiKGWTcByQ6kcXMCNL5GUJS6Bx2QB8fzF7Ul0AUH 9rwLxVUgKUbJO/OPsqIrDlJvf608kkX9QBTaBbTVzjsDoQ4hz7+xpNVM/XRQLckVA7+pIF gl2W3Qmb+U37VaO+y7KYwPxWybumOb0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VC0lQoSu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706560405; a=rsa-sha256; cv=none; b=2zzo/5GFeDne8iMTubvNBBbEZgCxkZUGQno2y8Btud5ZP35lpIALhlq2fLzhTZuSp6wRGR yegz3AT+0zXTElvPWvzHTT1Ctq8kAl/VcwRRTwRD0+LjlDrAQt3djOWu6s+y4eNUOvXufR UiHxUnR5xrjJYXv7VX6twaLcsEP2Tl8= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a35f68bedc6so105533566b.3 for ; Mon, 29 Jan 2024 12:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706560404; x=1707165204; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pJ4yjaXnu/gO8IJm2MvBxAL0/BI+WbXyDMVS9W9Dbmo=; b=VC0lQoSuv4b0LZS+PpZ8bqPYMj1oa7fgJ3R2TVVXEVNs0wziWZsJfik6qKu6RRu9wf 1e8fRqWqX+OxhNmaBai6UEBO8mnvtgh9iKWu7G2KOlxUEwSJl93qwacWmvNVVmvRgLk4 gp40wdRxHpp10NiApowkGh1vwchjBWcT5OllF+nSb8AoMZ5/ool8aBgJG3HrueNIJAZv jQck+7cjfyk2DgHUNZFiOoJjRZvNsAl410ViRbFUD6QrVnFG//kxbxk3mMaVIfKjAtXc 89bDMMR/IUoJK1CsmWZFInQm0oR98rsYR/Uq/69PK6h3nrBhSuOLcJsvHvxn0JChvpma TFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706560404; x=1707165204; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJ4yjaXnu/gO8IJm2MvBxAL0/BI+WbXyDMVS9W9Dbmo=; b=a4J8q0LYA8LoK218aYTXUA2I/IH0eKs607oLaMngnnqu+3Wr2x4c9IOP2YhwIoZPFr dN1ELqyenfZUkEAfag0Qo449E4cwjhvR02ey32FAXbk2bmbPja5EAkGmIsC8A3zqRXAA NOwZSpPfZgE3sFa/so4xvS7d3FfrTSZa6tiadwr1MQDB+ctd0MsnanBtk1ykHmW+MF2F B+2A0YUZ71V8ztpK5o9SBQzLArZMPGOht/xKiMefhGQkdVQ8c51oH2Ao+ioak1QKR1Jm 6TyCabVAvEizoHqgCuaYjZkAlRe4SmLH+KNDBoek3TSt6qb/Gf1fjYgbJFpkOE5SUYNf 1H0A== X-Gm-Message-State: AOJu0YxoU2DUwBMvb82JRmJCY68/Z3JMYTNEj3Via599OzX/wDYuNVZ6 ME4gs7+czlGMa2gmVIQD3zOy0pUIzFdMtE/+Ihm4q20vOCEFZVVA1wiSphKXqe8PT1qSBeX3V6F pznqoyFokSQKwgs4lrhLKvLaX46QJmXWEWuxn X-Google-Smtp-Source: AGHT+IE5Y49hmyAaED7dNazRHrPEe+9T806rwtrpIsfdyTaOO/aJp+aibuVHQOAWlsNuez82H+FriMLx0X+jXVB+EsA= X-Received: by 2002:a17:906:4ac6:b0:a35:2c1c:52ef with SMTP id u6-20020a1709064ac600b00a352c1c52efmr4959461ejt.15.1706560403622; Mon, 29 Jan 2024 12:33:23 -0800 (PST) MIME-Version: 1.0 References: <20240126211927.1171338-1-tjmercier@google.com> In-Reply-To: <20240126211927.1171338-1-tjmercier@google.com> From: Yosry Ahmed Date: Mon, 29 Jan 2024 12:32:45 -0800 Message-ID: Subject: Re: [PATCH v2] mm: memcg: Don't periodically flush stats when memcg is disabled To: "T.J. Mercier" Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , android-mm@google.com, Minchan Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5368C14001C X-Stat-Signature: eu61ptwinu4jkfp1qf9bner5uzcxytzm X-HE-Tag: 1706560405-953539 X-HE-Meta: U2FsdGVkX19li6g3gQtLOIWgVirK5rrN+3gewW12AvC4CE3FVeEVnA4EDUQFLtqVs+kTedxlj/p3MftjcQZ+2VjYJjK8LI2tovRVK3NevBsu5470SzA1JqSxE5U3qHnlOOOg4lsY5lzFJ/04hSD3O6Sn7wNvJghcu1Km6v9SF9vQdPN8YpHxE4imzfaMaRj8CAF2oflc4ZY0P7zesDC/vv/FAWZu+WiKMvziW1uhxm/54HZXfxHcLCbI8AMJanrvC3eagGjeX0NmvHWV9yV1AzV6GORZNxNpr1MomeHX0BZfK1wvUDv6YeQQp30W7XCrB+NKylN2Sy60oRqm7V74Lpvxz+I1FzkICD6IEAMp5iePrpIBgTscTsyUDJ0YpilZgAi++lYw82aiaen60k4WqFIUjDvqfMUgzJWQ7uEOIIO7Pr8gJu9jqj2pfT+qMP5cjw7Bp9YotcUcq+2pDU+8X4oVNsOVwGT269H/TJ7Rb3XK+Y8zha5uk3tgFV9SS1b6EhAf0I2kB7B3I8G0IOfX3PSMemK5Qv7HeB+QBKxiWvtsz4SvbaS8/GFf0iZdL29zxqh/M77jREN4SnjLqlz5J4ZZVDke85rJb47+TRbEwI0or4ZoG/hWfnWys02KJ75Rxt3NkHoTdCOL/iHjZn4+zHq8hQMkdecqR1ZT7e5Fpq9KHK4KuuwrtkkC4Jwr9ZYp0kkhtdsXh4v/09cZ9fMsxhDxjOmElmne/QV9r/YAuBkLJv7lxsJaqy3nbIuZ4QHIn8/G4Uw3q8AxPgWwVYvsE4NXwb2bUU0CN2vu+mV7ndQopTO3X+jpIF7xv2AR0Ec148MB5O0av1yyb+jAcPebXXD+gn1A1c2dhz/08/S4hgEYiUwVo9uEC1b9E03LpdkwCG7rOxTa8O4/CLwNdKfCogBHcmvTgc++WwZdvXtC47wCSUStX5zONf68pON2DX+n1R7w9KtE2ucDuEzbkHF 5cC4IL5h ll0FsnrU35/iyeRaz5Y5oe0D5FSzGZSEg+6He2945cHwQ99SVGQnGz84dgfZRSArRriM1LnqvdzK/S8XhZ7eVCVAMSz7Z5CfazddsGAopgutD2QhQYtH6h+A788500wrGQNDRNqbdtxRdhbX7P5g4O5OTWi7OydUcbQCWDKOLzJv5gbcpMfhglS3LKTXOe1dfl5FMNyfz4XQ+Py4Ze2wmrCnH4iF4WGYgXQo8xK/8hyWztkyEODKbVkVkEfS3tC3f12LFGNtu8IReYWG3cFzuA0R+hRtUURzCktszlrPKaMdofdNsB1HO3ipccg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 1:19=E2=80=AFPM T.J. Mercier = wrote: > > The root memcg is onlined even when memcg is disabled. When it's onlined > a 2 second periodic stat flush is started, but no stat flushing is > required when memcg is disabled because there can be no child memcgs. > Most calls to flush memcg stats are avoided when memcg is disabled as a > result of the mem_cgroup_disabled check added in 7d7ef0a4686a > ("mm: memcg: restore subtree stats flushing"), but the periodic flushing > started in mem_cgroup_css_online is not. Skip it. > > Fixes: aa48e47e3906 ("memcg: infrastructure to flush memcg stats") > Reported-by: Minchan Kim > Signed-off-by: T.J. Mercier > Acked-by: Shakeel Butt > Acked-by: Johannes Weiner Reviewed-by: Yosry Ahmed Thanks!