From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA6EEB64DA for ; Thu, 20 Jul 2023 18:25:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B507328014D; Thu, 20 Jul 2023 14:25:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD99A28004C; Thu, 20 Jul 2023 14:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9536A28014D; Thu, 20 Jul 2023 14:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7F06828004C for ; Thu, 20 Jul 2023 14:25:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49771140248 for ; Thu, 20 Jul 2023 18:25:01 +0000 (UTC) X-FDA: 81032816802.24.E9FC857 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf27.hostedemail.com (Postfix) with ESMTP id 6BEF64000C for ; Thu, 20 Jul 2023 18:24:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=mt1sBgB8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689877499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WGZYDyMNM2urRP5vx8c4QdZu7AgAmPw6pFOTfwzWRZg=; b=AZir8bnFENr0vzid46zVad2sPevzC0i6XUYvngwfzgZtvSUz2PrESO5dXK0Y2QjotN7n/K uWkgJfU2k3mpFJB0vaEbxArtKJ4/7gPOETLiAOzqQbXe0kQFHJ41DVpVE0o6YvqLIMCJ3U 6X2TvwvfoLbZwZoBs/2lT0I8NaFNogQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=mt1sBgB8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689877499; a=rsa-sha256; cv=none; b=Eky9JOmqiB4oFt2RN0pYM21kmFuwivSnjlYi6koF7CTSULVQDO/VMsJV+LmKtuU1prwTPD QkN7DbThvyvgoyiGFRUBgW9xKJEUc5VFbxgmqzvmwaPFqFLqOEbZgB2jbN9lVib2mO+JVg FXD2J9hH/B4g+7QRn1cQ6878Cxn4rBE= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-991c786369cso181976866b.1 for ; Thu, 20 Jul 2023 11:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689877498; x=1690482298; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WGZYDyMNM2urRP5vx8c4QdZu7AgAmPw6pFOTfwzWRZg=; b=mt1sBgB8r8M1WCu/khBK23vqsKmLfRnOL6qK7jQNjWuQznHO23Bay2e130cpCoAeEe 73wl6cIlXIIHsARp6vmsbAgqU8tjbFsub99lKb6wOpa+2M7PaWHciatXeIKNUuKhG8Hq gvLVGkhokRJM843fQ4gfqbjq4sybR7Spbv7PsPcpms2MdS2TKW/uGAdo4EF3+79d+WGL FR5LA8exsfDUsRso36GvGWEESx7vwxbfo4RVNcEMX5czOJIcjwKxvMamEAV9G2TkUhul /2qFpAFCbsvjtw9NnwnnoXvY9OXP5eTbP3aC5STbEiXWIRUNvSN+B28jk9P5SDDLA9AR /NTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689877498; x=1690482298; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WGZYDyMNM2urRP5vx8c4QdZu7AgAmPw6pFOTfwzWRZg=; b=b1KpLyW+1j3SjCNhjTmmXcavBKT263Ljl0vMgFTyPU8gi6/v6nFHaaSaK2+63Smj9V gUGBtM3tZvt80ZSxjCfg8sAjn6TyrHaS8FUUy8cbjW5lhvpDNNGDCm/r3RRWffH9/3UP np3b9Dqse7rFNhRAL1/FlDK59Wi9tmTvynKRbKtE07sVRndTQHccP9FDY/CX6VrDwkfu U2gfr9ZDg2HAd3ouD0WKCk1byLG86joWBjJKt4Wopke8oGxk2ZMdG6dIAOs2Xw4UXvWN auMmiel6k45k0q4lrha0x36E2ZzuyRUitnHoikMe5gL0dCvLEHq+/MsfZkajoimKszrL mMmg== X-Gm-Message-State: ABy/qLabtm8kcr7i+yiMAZYAjFRkEBnZY5b6Og1oNCDWUJHx6TEKojhz W/NaqtZtUbiO8eruoANz1AFmn1vK8iMXxvhO+dUxvQ== X-Google-Smtp-Source: APBJJlGZb3WymIaX1uRXdrzpAriwl5oRaFaeofNe1umRFQSKMrse/fgm7TbBbCD9GqEa6VUNJPBZ4YV8vzmdo9H5tic= X-Received: by 2002:a17:907:2716:b0:99b:499d:4635 with SMTP id w22-20020a170907271600b0099b499d4635mr2319758ejk.75.1689877497693; Thu, 20 Jul 2023 11:24:57 -0700 (PDT) MIME-Version: 1.0 References: <20230720070825.992023-1-yosryahmed@google.com> <20230720070825.992023-8-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 20 Jul 2023 11:24:20 -0700 Message-ID: Subject: Re: [RFC PATCH 7/8] memcg: add sysctl and config option to control memory recharging To: Luis Chamberlain Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Yu Zhao , Kees Cook , Iurii Zaikin , "T.J. Mercier" , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6BEF64000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9pinucwd4xpsrr9ouyto668i1gbciq3j X-HE-Tag: 1689877499-807078 X-HE-Meta: U2FsdGVkX18Dl2ghKuRO571zinxKq+/Joxu+DaCg6svZQEUBRQlAbZKZv/nK9UabeRx+JTq3hJL/bjFthH6aNKKs8AFpmR18hkGRyB9PqPOPLuMJPEPbb9v4W1cHk2ZwpyVu5BXO3SdIQl2y9B3dl4tpajo2jcvTosAhRYej436LkGP5NFy/8j9JtF2OUf94CS1bRl7RDOUuVQ0NJogCVGUqC8dfWn0IUs+H0OkP+SLNlm3g+R2/WC0R9PPOqPD7Ze7dGssTNNQwtBMILNH6KK7/uHQNVWoBHdDJ0nuo+M2ErymXdU1GP6sRr+gTLYj99q2H3vN1lX7eKRb0by/M86862me0CZlX4TjeGNpCMqk/p72dLVWLmZfUXWdgt234/pnoJppRgkktRpL389av+hWvAITagvBvWpoGf2xqZYH9vQtrS0N+YYrGM3i8oZjoMO0qqwOaEJqyyp0yrSIUKLXmkRw4skHX8n0rq5pQbPz6E1RjRcGkDOPO2+jX9j6XSX6MGTECAVoNKv9b2LwaE4wAhL45SLrNGxgQQqbT46Mjo+pWMbNK0x9kX1MrhmoL/26Xj/8vVQS0wHt59Xz/uQSxesP7CSB1UuPkwYHTNj0UW7fe8eltRrqFEG7bC4L2TxP0RFyxt9hPzyB/JBr05wraoQJyYAqpmmiURnWw9SGj3E/nXDNY+2+pFaaWFFgpxzN4OrM9VX5zGXbzHGcPSFS5cmSKLQN4VbH8bMA8Q0KpS/diyT44yeLwna/LGa/3HAynxNl2+rNBcaCfChEUGd3yNQvrKbug7GCJwhuAqGygV3o/JT96HrdjLh7kJGEZU7/XNsJeWSHSujbCc1H3BHr+WxiHQ8YU/hLMKKo73LQqoxLbIJlACekfEUWwTz9HpVKUzzUWoXiFDr1IiYxyXAWjkeTeVASCkAcGAIPEbXjTSN5Y9RRYhgTwd2cABW8P9j143SlcE6c62TMWltS 0g55Qd0p v04dWSLdsmQJQDbcZEHkyq5DUuQVol0/AJRYxtaiIf73d5iwyN8EJ91oFC1yK33PBFw+vfys4fZUwC9lRjKfypmFrKd8yoXCW9JA65fj8FoFH2hWJC+duzv5QqdwmOkEPqAkklEQIPiDAZnjXRZW/QTctY8/bURCW6ppjFeMXFqTca+TXpQpQRBLEhTqDCWUOW2OrDpgMJkyihe4Lbzhb5evLRrzPmDUs9VIy6H42UpSLTv9per6UGe/a0zsd8AhN4OFza9LrcZ4KrWsfHpJTLRBzliw8SmO0aVkGDCm4Ai5khkk9YviUV8uMLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 11:13=E2=80=AFAM Luis Chamberlain wrote: > > On Thu, Jul 20, 2023 at 07:08:24AM +0000, Yosry Ahmed wrote: > > Add a sysctl to enable/disable memory recharging for offline memcgs. Ad= d > > a config option to control whether or not it is enabled by default. > > > > Signed-off-by: Yosry Ahmed > > --- > > include/linux/memcontrol.h | 2 ++ > > kernel/sysctl.c | 11 +++++++++++ > > mm/Kconfig | 12 ++++++++++++ > > mm/memcontrol.c | 9 ++++++++- > > 4 files changed, 33 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > index 59b653d4a76e..ae9f09ee90cb 100644 > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -60,6 +60,8 @@ struct mem_cgroup_reclaim_cookie { > > > > #ifdef CONFIG_MEMCG > > > > +extern int sysctl_recharge_offline_memcgs; > > + > > #define MEM_CGROUP_ID_SHIFT 16 > > #define MEM_CGROUP_ID_MAX USHRT_MAX > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > index 354a2d294f52..1735d1d95652 100644 > > --- a/kernel/sysctl.c > > +++ b/kernel/sysctl.c > > @@ -2249,6 +2249,17 @@ static struct ctl_table vm_table[] =3D { > > .extra2 =3D (void *)&mmap_rnd_compat_bits_max, > > }, > > #endif > > +#ifdef CONFIG_MEMCG > > + { > > + .procname =3D "recharge_offline_memcgs", > > + .data =3D &sysctl_recharge_offline_memcgs, > > + .maxlen =3D sizeof(sysctl_recharge_offline_memcgs= ), > > + .mode =3D 0644, > > + .proc_handler =3D proc_dointvec_minmax, > > + .extra1 =3D SYSCTL_ZERO, > > + .extra2 =3D SYSCTL_ONE, > > + }, > > +#endif /* CONFIG_MEMCG */ > > { } > > }; > > Please don't add any more sysctls to kernel/sysctl.c, git log that file > for a series of cleanups which show how to use your own and why we have > been doing that cleanup. Thanks for pointing this out, I definitely missed it. Will do that in the next version. I guess this will also reduce the reviewer churn if I won't be touching kernel/sysctl.c? > > Luis