From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6BC5C47DB3 for ; Thu, 18 Jan 2024 17:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E82E6B007E; Thu, 18 Jan 2024 12:37:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66F9A6B0089; Thu, 18 Jan 2024 12:37:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E9A56B008C; Thu, 18 Jan 2024 12:37:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 35BED6B007E for ; Thu, 18 Jan 2024 12:37:54 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 09ACB120790 for ; Thu, 18 Jan 2024 17:37:54 +0000 (UTC) X-FDA: 81693139668.05.EA41E56 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf18.hostedemail.com (Postfix) with ESMTP id 31EA71C0018 for ; Thu, 18 Jan 2024 17:37:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Y/r3UC4H"; spf=pass (imf18.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705599472; a=rsa-sha256; cv=none; b=QHR+n84rRgU/CiQBW5O5urKxAG36vZyptVE9MwNXka64+ueL30kgaLgOPLXqYw34EC3fu4 HrI8sunsYRzMm2x3c9tfH+z8jzfEpjqZIoCeCj89ZDOUEebjhKhjhziESppzxXQ70aJdAV JTi2xe51I36HedsL2bInMhdT2ILk85E= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Y/r3UC4H"; spf=pass (imf18.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705599472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1SLI49q2Cr6+OAuuBarj8au+Z71GOo7Ef/S9Ci54CE0=; b=bp4hkwogSF8ldw0/+cAMENMygsM+nqbZ9b/xEy89d0Y6rOfodq9/PeOBFoh8PKtNU9X4Ld qMJAFyq6Z6oLcgpFoVxpnll62KDvFtkXIT0OS4JUSTMmEJuV63fO3esuRT7pcmWH85f+4Q 1RhDS9JZEr/eJomkfy3IPLwZ7QDM/ls= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ccae380df2so139667961fa.1 for ; Thu, 18 Jan 2024 09:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705599470; x=1706204270; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1SLI49q2Cr6+OAuuBarj8au+Z71GOo7Ef/S9Ci54CE0=; b=Y/r3UC4HCyUAu+ukfFVAjCaYF0JnTI/ZJU/McoUo1d8mwgCHZItA1IfdQ6IWl2hLyp slnmc7nj0PZQds0o2AYr+rQswP4JH4pGTtd08y+GnLK+fpzXejXVpuGYNMFD6u1XdNuE I2sRbcw5S2YUpFxLF2wpVhHSzWU85IJKKmhiPJCoHC5w5fAHKS2ooScZ/mwUQzrynmOX pvocVXRzNhxn9dML23NXJQlUmtp2VMTbJMX3jAz+8v/NYFczdL7SGxxO4dkY4e7CJnQ2 FxYOcPIOttMHmleLNCMZx+WN2+F/LMbIRNJrLanCP6XY5X2BVU92h8ohrvADsEWIBXQb XtRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705599470; x=1706204270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1SLI49q2Cr6+OAuuBarj8au+Z71GOo7Ef/S9Ci54CE0=; b=gwil3Np9bvUsDD/jEFqeK5C6vu5pE3gkmfYBDGFgCoa5E04QRLothDdn7VkYBmcmrD BCs3CtKLMruEJ5wGljc2qXhoZvV7oFD5HBXeoMzLg/RqD4Ohe1OUVCKUoBKJPzrVD8zR 0T4OXVaZVflIUem16E7oBHHw9v5P+Z6mMh15kxFCr7dQIZidTB2I7Wr000F3SJ5EpEzh ffW9bkq3ogQqkJXvLAxsfs2rybub4T19SYppno9T0D7VMDwNCwXQX8PV93ZogEEM1gAY Am8iVfM3YeXm/rxauB8Mz5LaffVEa+wmAhGOfiXJs5EMMU27Aj8uayMaM4hlHFJJJuZF vORA== X-Gm-Message-State: AOJu0YyL5imu2sJ8l4tyCOJ/qpa/KnpJzJsEddcaEhdVdzuc0Jv4pvJb rZ7677wGI69SzJN9Ptup131L59ZibN0RLFAgjPP1p8b9ki2tAlDDb97uigOlpkB1rBSbfV8ZbBE RXedDXNkpQ0izdZj7TVzf7PxvitoDZsjk8n15 X-Google-Smtp-Source: AGHT+IF3AEnWYHNRp1Oqp8aUrRQqBgoYUu3uvzRdmsLIYUSCDnQo/aN4tWsJAvsGDTsSZ+ipTWaOuVXwRwbmGHd4+xU= X-Received: by 2002:a19:4342:0:b0:50e:f5c4:ce39 with SMTP id m2-20020a194342000000b0050ef5c4ce39mr607267lfj.53.1705599470178; Thu, 18 Jan 2024 09:37:50 -0800 (PST) MIME-Version: 1.0 References: <20240117-b4-zswap-lock-optimize-v1-0-23f6effe5775@bytedance.com> <20240117-b4-zswap-lock-optimize-v1-1-23f6effe5775@bytedance.com> In-Reply-To: <20240117-b4-zswap-lock-optimize-v1-1-23f6effe5775@bytedance.com> From: Yosry Ahmed Date: Thu, 18 Jan 2024 09:37:14 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm/zswap: make sure each swapfile always have zswap rb-tree To: Chengming Zhou Cc: Andrew Morton , linux-kernel@vger.kernel.org, Johannes Weiner , linux-mm@kvack.org, Chris Li , Nhat Pham Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 31EA71C0018 X-Stat-Signature: bxxe6ezd8jq3z9imgfikepj7hh8xs8t9 X-Rspam-User: X-HE-Tag: 1705599471-859582 X-HE-Meta: U2FsdGVkX1/jRH7uekW8WaaMS4heADwJw442XfVrB+tDk3nmzz7UyxhNIuIZgDsdJThYHIA9hZbrrEtBJr/beN/fsKn1U4mlAFA1qh5ztyXcU1RTCFYSyqbcDCaBab56BJeIpyv/MTyvPCmi56cT/YZ9sRaU6vN2f3JrMi1DoFAW1mmxdiceUlofOks03EkECVVZNLgYW6g3v7jO05vXegfkGPmFERZqOjPwX7HvpcR7RTcnpbT5rdbwPZBd64G5fXBnb4KTweNXyntnNWtG5PUehLFbBbhLbH6R1uv7QBOpBhd6V9YCRNxVqoR95fPWbyHyvMSNkjbz8jaerUVY8jZgu5OE05hGapGERfnF3/wKwVE145y+0EOWEnO5pOxkitcXSVX54g8/lwCle0WmPD88N/m04LfmEqe8G/BF1I+iD0pE1JzlJnVHOmivQa2ygBkzUyeMmJBMnrH/rF8SFOLIPs67pIuyLRzNBiC81qeKmf1Nw9K2NN8Us99H90oVgKaEScQt/c1ZpsuoJUFCPyuLhTwML/FnBQNL2PqO90uMJ6B/BA+J/c/r+INFvXNpvgEfSN1jMkczO/q6/sNEZpHfF3T2E20oPkpfNapVEdmvezZT0o8LRD8eFv68iccga7D/In4ap+xa26dW4RPxHeoWnbS82kivEVq/C4PsO4/q/F5kNFgoLLySMj2wB7L5TIfYwADWNfFjCIfKGwRFayiPOEJJ9QJWbpB5m1s8KQnt/fZS/K1x5PdJn9g962QqsrJJXVnNVEyOZWjlnbCD/4Mff9DgomPM5CbrFxzAlTDb7B9OncnmI6X0q0rKVK9vPzy/hDlJa6RGKXh3HvWO1uNQ0ec80jcRGrUCwc2b9xqDOpZdnnCneb0rrIQV1Iw2swear1X421WBRUPuAZeeO8oxCH/JXPjnrSyrISTbrlW044V3hSE1vNxnhCNA9C30AXBQ0LqweoT7EWFBhT8 GzOG7zO8 k8+ji/si4teBolbPaKQ2jeFlfr0HBZbtGlv1/Lo5DiQ5v8T9GGgxOov3tT0FTAxMjcEGU6z2PEzNsdsObHptQidmGD9x92lNVQd6zs+B6ZFerbpiRNsaSKoi+h5THjMgthiY39NxKFTEKF2i9mH3qYGdbK7v6VMJIMk1clrkZ73/kE4ATB6BiwTWNTb90om65HzL46UaWWlfuCQhexFe/CxoVEnlYbsdQNiw5LKmFO5oQB5tdARS4vwqWKaflW/zMHQjtyK/7bLVDP5NXgKld+x+4NlZuV7KCXPQJh6bkQUEWESJ4vNi+5SaprA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 1:23=E2=80=AFAM Chengming Zhou wrote: > > Not all zswap interfaces can handle the absence of the zswap rb-tree, > actually only zswap_store() has handled it for now. > > To make things simple, we make sure each swapfile always have the > zswap rb-tree prepared before being enabled and used. The preparation > is unlikely to fail in practice, this patch just make it explicit. > > Signed-off-by: Chengming Zhou Acked-by: Yosry Ahmed