From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48138C5B543 for ; Wed, 4 Jun 2025 04:29:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2ACC6B042C; Wed, 4 Jun 2025 00:29:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DB916B042F; Wed, 4 Jun 2025 00:29:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1546B0433; Wed, 4 Jun 2025 00:29:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 77EE56B042C for ; Wed, 4 Jun 2025 00:29:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6896F1A01F7 for ; Wed, 4 Jun 2025 04:29:22 +0000 (UTC) X-FDA: 83516438964.30.7F14E4B Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf12.hostedemail.com (Postfix) with ESMTP id 9B4D640004 for ; Wed, 4 Jun 2025 04:29:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=y2PZtQwP; spf=pass (imf12.hostedemail.com: domain of jyescas@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749011360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FGNSBEf0AD284oSE13H/FFAffi0rYgrIINmsLvBpAlI=; b=JjgzqQ4+pqLNDI/DMlVA2W39200y4/eZdgzKm0ckLXw/u/aliwU5uW2W2NEes97ipFbh3i kd1+R7bYqfQm1QfPjz1dpnA6ng6okQxBHNCqndNcArK5ONmLZdUDXXdYgZ+vi2iV6gIMoU Sk3pGQMeMxTlsS5cGDtdCf3GsJMJIwE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=y2PZtQwP; spf=pass (imf12.hostedemail.com: domain of jyescas@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749011360; a=rsa-sha256; cv=none; b=4eQ2zPRGdNlpEYOi0UjLe5OYUbn1gHuHzi3JsOgNveRwbwJq+Nfdj51ErKWsDma3hdmeNX A6o3tXNg4Vfi1pqJYZYvAEPn7FsoPASEjV9GIC+GJnHp6k/wPOT6ENqpmDlnM/wsfiE8kl Q+m29LirKvWvJX5kfQhywXqCwDsEnR0= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-235ca5eba8cso125955ad.0 for ; Tue, 03 Jun 2025 21:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749011359; x=1749616159; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FGNSBEf0AD284oSE13H/FFAffi0rYgrIINmsLvBpAlI=; b=y2PZtQwPxlzfeVL6QUV3Br1++jiox5XFRJcq/EBhOgUt2Ua/Lw23QnfdfqDc4Ii10k zGEaUzfdFjkPB0Mdwja9R5tpRqiyHvCBg4XLPG9EKj57NSjVwq4ZJByUSnueymOkbpsi IWntSRQsvSniCmE6mRAVYbRpPL+Ytn4iCU02gCE+nutOOJbJ55wsHrg0n52dmnMIdSTH HF0Gp6rXL9DEhoeD70/KsZSgXIyy0sS7TZo02F+IACBl7++5abcP03kx0kfQBwvLrUWU Njp2oJWKFPhfUnsHQYn/LCbjNMMheSaUWnlrAGsQanBUZLOeurAJNO3NhuhSLW3eTyz8 6DaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749011359; x=1749616159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FGNSBEf0AD284oSE13H/FFAffi0rYgrIINmsLvBpAlI=; b=sBBteaCI0HA5a52faMRScPxzcoq8VGkTbc3xDNgjwK/CTT5CAIjz3AvFRx4qv6gQqu yk4cYY0FTtpaES5JMHIMldYWE56L6btjkcmL0xmOoG0x7s3tGjpMd6txCLFjN5F9XWOT ksne+ADb/Av7Scf5ZkoOTh8rYRqHbVYg8hQE2FnGa2sxXVV89eJX4BB4Gi3LaQHaMT3m bmH4YmV+uZfXDdsBqKIvLty/j5DdqajVDdksiT4VJBLY67+1mZXOSKnDkOXzfsBw6G3f bLR2krvBVtXVO35HTcdwJUrJDyZjZ43KilwA5VfjT+RlYpJ3N34T+4rZZklMuzLHqy/O OBbA== X-Forwarded-Encrypted: i=1; AJvYcCWpTO1yBjy4SlESuXtZ3mlE6H/j3tfm5OFpZDhAQC+aI8fp99VI9kuhGlvYWEh0uGh04ecPyZ3+IA==@kvack.org X-Gm-Message-State: AOJu0YyH011pJG4GuNSRUlc4Xsqw3myYRwsEFUFx/qOouEBlKaaiYtl1 8NP/CmaWb2DtorW7E7CMkqxLO8eP1sJvKugODfH/MY1TmOxjztQjv7NIf91/onNXkcjCaKIxrJE s9gOkHLVFFGzzLPLfv2ccG1TopvfwNLZ7cnIUrMEi X-Gm-Gg: ASbGncvD0dz9myES07L7c4+24Ltn+sihMVhJjGWIwpicFjstduDh1gg4DgLV1oEibTw XFBDFeRSqoxLudNl9bt0oF87vhHiJ5Q8gcK0SLVIZG1VhYY1xYZ8gNOfO7G7owMiXnNmHAbz+kE xB46sILlOIteWugvL5CcO/1Y24SHGh1TLziyBA01y1JPU93UqzQh+Z4TsS8LD00LFRiOvt17ZxC oGLMw== X-Google-Smtp-Source: AGHT+IHy/g9C8sI0sjL+N9l9hpzfx35P0wqLjEKU9oirnFb5JVmTK0JdB84muXaLwaPVMYaPK0IuUbGE5zc7poSJqyw= X-Received: by 2002:a17:903:41c5:b0:234:c2e7:a0e7 with SMTP id d9443c01a7336-235df7bed95mr1828935ad.4.1749011359087; Tue, 03 Jun 2025 21:29:19 -0700 (PDT) MIME-Version: 1.0 References: <20250603154843.1565239-1-ziy@nvidia.com> In-Reply-To: <20250603154843.1565239-1-ziy@nvidia.com> From: Juan Yescas Date: Tue, 3 Jun 2025 21:29:03 -0700 X-Gm-Features: AX0GCFsUhw_kYI1BgM3xj3T5QLJPcCPGMcq_7qHbZq4EEuyDApPMnZU8AKcfntI Message-ID: Subject: Re: [PATCH] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_ORDER_CEIL. To: Zi Yan Cc: david@redhat.com, Liam.Howlett@oracle.com, akpm@linux-foundation.org, isaacmanjarres@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, masahiroy@kernel.org, mhocko@suse.com, minchan@kernel.org, rppt@kernel.org, surenb@google.com, tjmercier@google.com, vbabka@suse.cz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9B4D640004 X-Stat-Signature: off9j495zznkrd8yrithmcumsdx4jzrs X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749011360-403129 X-HE-Meta: U2FsdGVkX18U/aHc7UVQ+pK7WnGqJYIX/kL3gLzuwwgDm/UFNb/iiUmYP57FIwJy5htUpqNzd+/MFnqQuF9dAsSuvqpG2WT4sJ+7W4MuxsIv/WlJpaRwh8SdZJPT7Uc4u2/+IykhoA/3wk2RVRlxE7WA7La07YtPL3KqsMi4xPgwipWe87a3rc9EIESIGbuK301zJ7bYSbIQrtdifdrY7u7QsBZnL1lL9Kon8Cu0IHl6lEGq0k3HpvavnGGDtjk9OJKkGCP7v4sOXqLmWnewM3j6pOsKeFolzbXteo5XH+sjVjARXxV/quSOlPtq/RuBkndVW/SrYYgelwbxvW5fBXDVim2daxc2ts2HerESl83L/zTDArgwcjP2B3WTBKNpBG7EP2cp5G+Ir2geKz8FniHYwVuOUAVhnriT1rO6VthxcoG9NSuqITRcgIR5w8b3HFSwVv8zI2WPFq8q+FcTzI+MCPCgZM8GgYyD5syfEm/hIjSOGddsls4do60kBUHPBI0pV1O2pPac+N70iNpppT8Mo0icgsIc2XiZCVIu6qEbulMTNtqjRZoGjEetfl8ymn3wiF5e2rf21H0wbhL+bKZk39YBbxvTWRDNShdydUdRkzZuXwQecjQ6eaaYJQPJd686Ejfwh7IQFmq6eW0H4Jju2oUvgYRrPzdK7sJEDbR81lK3d1p/JBLV5RRPrz+iJjjxZCMmkXx7pCFbuyDA8BCwnmYHEi9Kdbl/CWKcOVhNWU5AI4vUfVjvgj0Uwfl80pPlyg60QSIvrdqQwCR4A0L47beK8A2s5yugDEKqDP07E9yZ/eRZxb2elqjx8mdZjqsp5OjdeU3R2pn5m9eRnNyRud4ZC/rFuhRvHCDC4XZAT5VXyfFWH5QrtDaMbFSHjueC6FJ6HDcDliUvwVHrCQ2hfJSmEFcZKPrHaQ/yoEsF84FAvkSVGqKixyEYybesbmdc4Yi7JnA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 3, 2025 at 8:49=E2=80=AFAM Zi Yan wrote: > > The config is in fact an additional upper limit of pageblock_order, so > rename it to avoid confusion. > > Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page bloc= k order") > Signed-off-by: Zi Yan > --- > include/linux/mmzone.h | 14 +++++++------- > include/linux/pageblock-flags.h | 8 ++++---- > mm/Kconfig | 15 ++++++++------- > 3 files changed, 19 insertions(+), 18 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 283913d42d7b..523b407e63e8 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -38,19 +38,19 @@ > #define NR_PAGE_ORDERS (MAX_PAGE_ORDER + 1) > > /* Defines the order for the number of pages that have a migrate type. *= / > -#ifndef CONFIG_PAGE_BLOCK_ORDER > -#define PAGE_BLOCK_ORDER MAX_PAGE_ORDER > +#ifndef CONFIG_PAGE_BLOCK_ORDER_CEIL > +#define PAGE_BLOCK_ORDER_CEIL MAX_PAGE_ORDER > #else > -#define PAGE_BLOCK_ORDER CONFIG_PAGE_BLOCK_ORDER > -#endif /* CONFIG_PAGE_BLOCK_ORDER */ > +#define PAGE_BLOCK_ORDER_CEIL CONFIG_PAGE_BLOCK_ORDER_CEIL > +#endif /* CONFIG_PAGE_BLOCK_ORDER_CEIL */ > > /* > * The MAX_PAGE_ORDER, which defines the max order of pages to be alloca= ted > - * by the buddy allocator, has to be larger or equal to the PAGE_BLOCK_O= RDER, > + * by the buddy allocator, has to be larger or equal to the PAGE_BLOCK_O= RDER_CEIL, > * which defines the order for the number of pages that can have a migra= te type > */ > -#if (PAGE_BLOCK_ORDER > MAX_PAGE_ORDER) > -#error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > +#if (PAGE_BLOCK_ORDER_CEIL > MAX_PAGE_ORDER) > +#error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER_CEIL > #endif > > /* > diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-fl= ags.h > index e73a4292ef02..e7a86cd238c2 100644 > --- a/include/linux/pageblock-flags.h > +++ b/include/linux/pageblock-flags.h > @@ -41,18 +41,18 @@ extern unsigned int pageblock_order; > * Huge pages are a constant size, but don't exceed the maximum allocati= on > * granularity. > */ > -#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_= ORDER, PAGE_BLOCK_ORDER) > +#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_= ORDER, PAGE_BLOCK_ORDER_CEIL) > > #endif /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */ > > #elif defined(CONFIG_TRANSPARENT_HUGEPAGE) > > -#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORD= ER, PAGE_BLOCK_ORDER) > +#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORD= ER, PAGE_BLOCK_ORDER_CEIL) > > #else /* CONFIG_TRANSPARENT_HUGEPAGE */ > > -/* If huge pages are not used, group by PAGE_BLOCK_ORDER */ > -#define pageblock_order PAGE_BLOCK_ORDER > +/* If huge pages are not used, group by PAGE_BLOCK_ORDER_CEIL */ > +#define pageblock_order PAGE_BLOCK_ORDER_CEIL > > #endif /* CONFIG_HUGETLB_PAGE */ > > diff --git a/mm/Kconfig b/mm/Kconfig > index eccb2e46ffcb..3b27e644bd1f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1017,8 +1017,8 @@ config ARCH_FORCE_MAX_ORDER > # the default page block order is MAX_PAGE_ORDER (10) as per > # include/linux/mmzone.h. > # > -config PAGE_BLOCK_ORDER > - int "Page Block Order" > +config PAGE_BLOCK_ORDER_CEIL > + int "Page Block Order Upper Limit" > range 1 10 if ARCH_FORCE_MAX_ORDER =3D 0 > default 10 if ARCH_FORCE_MAX_ORDER =3D 0 > range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER !=3D 0 > @@ -1026,12 +1026,13 @@ config PAGE_BLOCK_ORDER > help > The page block order refers to the power of two number of pages= that > are physically contiguous and can have a migrate type associate= d to > - them. The maximum size of the page block order is limited by > - ARCH_FORCE_MAX_ORDER. > + them. The maximum size of the page block order is at least limi= ted by > + ARCH_FORCE_MAX_ORDER/MAX_PAGE_ORDER. > > - This config allows overriding the default page block order when= the > - page block order is required to be smaller than ARCH_FORCE_MAX_= ORDER > - or MAX_PAGE_ORDER. > + This config adds a new upper limit of default page block > + order when the page block order is required to be smaller than > + ARCH_FORCE_MAX_ORDER/MAX_PAGE_ORDER or other limits > + (see include/linux/pageblock-flags.h for details). > > Reducing pageblock order can negatively impact THP generation > success rate. If your workloads uses THP heavily, please use th= is > -- > 2.47.2 Acked-by: Juan Yescas Thanks Juan >