From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx135.postini.com [74.125.245.135]) by kanga.kvack.org (Postfix) with SMTP id 94ACC6B0027 for ; Thu, 14 Mar 2013 20:21:45 -0400 (EDT) Received: by mail-oa0-f51.google.com with SMTP id h2so2897204oag.10 for ; Thu, 14 Mar 2013 17:21:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1363283435-7666-4-git-send-email-kirill.shutemov@linux.intel.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-4-git-send-email-kirill.shutemov@linux.intel.com> Date: Fri, 15 Mar 2013 08:21:44 +0800 Message-ID: Subject: Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read() From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > There's only one caller of do_generic_file_read() and the only actor is > file_read_actor(). No reason to have a callback parameter. > This cleanup is not urgent if it nukes no barrier for THP cache. Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org